Skip to contentSkip to conversation

tracing/filters: Fix to make system filter work

PATCH In review Li Zefan 2 participants 3 messages Oct 28, 2009 – Oct 29, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 tracing/filters: Fix to make system filter work

commit fce29d15b59245597f7f320db4a9f2be0f5fb512 ("tracing/filters: Refactor subsystem filter code") broke system filter accidentally.

---
 kernel/trace/trace_events_filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/trace_events_filter.c +1 -1
index 21d3475..50504cb 100644
@@ -1230,12 +1230,12 @@ static int replace_system_preds(struct event_subsystem *system,
 				struct filter_parse_state *ps,
 				char *filter_string)
 {
-	struct event_filter *filter = system->filter;
 	struct ftrace_event_call *call;
 	bool fail = true;
 	int err;
 
 	list_for_each_entry(call, &ftrace_events, list) {
+		struct event_filter *filter = call->filter;
 
 		if (!call->define_fields)
 			continue;
Signature · 1 line
1.6.3
maintainer
#1 lore raw
Quoted 3 lines · Li Zefan

commit fce29d15b59245597f7f320db4a9f2be0f5fb512 ("tracing/filters: Refactor subsystem filter code") broke system filter accidentally.

Thanks Li!

I'll pull this in and send it off to Ingo, in case he has not already done so.

-- Steve

#2 lore raw
In reply to Li Zefan
Commit-ID:  3ed67776fc23061180896086a206a02be649dd26
Gitweb:     http://git.kernel.org/tip/3ed67776fc23061180896086a206a02be649dd26
Author:     Li Zefan <[email protected]>
AuthorDate: Wed, 28 Oct 2009 17:37:01 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 29 Oct 2009 08:53:20 +0100

tracing/filters: Fix to make system filter work

commit fce29d15b59245597f7f320db4a9f2be0f5fb512 ("tracing/filters: Refactor subsystem filter code") broke system filter accidentally.

Cc Steven Rostedt <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Tom Zanussi <[email protected]>

LKML-Reference: <[email protected]>

---
 kernel/trace/trace_events_filter.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/trace/trace_events_filter.c +1 -1
index 21d3475..50504cb 100644
@@ -1230,12 +1230,12 @@ static int replace_system_preds(struct event_subsystem *system,
 				struct filter_parse_state *ps,
 				char *filter_string)
 {
-	struct event_filter *filter = system->filter;
 	struct ftrace_event_call *call;
 	bool fail = true;
 	int err;
 
 	list_for_each_entry(call, &ftrace_events, list) {
+		struct event_filter *filter = call->filter;
 
 		if (!call->define_fields)
 			continue;