Skip to contentSkip to conversation

opensm/osm_sa.c: don't ignore failure in osm_mgrp_add_port()

PATCH Applied Yevgeny Kliteynik 2 participants 2 messages Oct 28, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore

Yevgeny Kliteynik

author
#0 lore raw

PATCH 1/1 opensm/osm_sa.c: don't ignore failure in osm_mgrp_add_port()

Hi Sasha,

Small fix in loading SA DB: don't ignore failure in osm_mgrp_add_port() - require clients re-registration.

Signed-off-by Yevgeny Kliteynik <[email protected]>
---
 opensm/opensm/osm_sa.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
opensm/opensm/osm_sa.c +4 -3
index a124a45..7b9340d 100644
@@ -1002,9 +1002,10 @@ int osm_sa_db_file_load(osm_opensm_t * p_osm)
 			port = osm_get_port_by_guid(&p_osm->subn, guid);
 			if (port &&
 			    cl_qmap_get(&p_mgrp->mcm_port_tbl, guid) ==
-			    cl_qmap_end(&p_mgrp->mcm_port_tbl))
-				osm_mgrp_add_port(&p_osm->subn, &p_osm->log,
-						  p_mgrp, port, &mcmr, proxy);
+			    cl_qmap_end(&p_mgrp->mcm_port_tbl) &&
+			    !osm_mgrp_add_port(&p_osm->subn, &p_osm->log,
+						p_mgrp, port, &mcmr, proxy))
+				rereg_clients = 1;
 		} else if (!strncmp(p, "Service Record:", 15)) {
 			ib_service_record_t s_rec;
 			uint32_t modified_time, lease_period;
Signature · 7 lines
1.5.1.4


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4AE814E3.4090405-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org