Skip to contentSkip to conversation

Explicitly truncate bswap operand to uint32_t

PATCH Superseded Benjamin Kramer 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore

Benjamin Kramer

author
#0 lore raw

PATCH 1/1 Explicitly truncate bswap operand to uint32_t

There are some places in git where a long is passed to htonl/ntohl. llvm doesn't support matching operands of different bitwidths intentionally. This patch fixes the build with llvm-gcc (and clang) on x86_64.

Signed-off-by Benjamin Kramer <[email protected]>

---
See also:
* http://llvm.org/bugs/show_bug.cgi?id=3373
* http://lkml.org/lkml/2009/1/23/261

 compat/bswap.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
compat/bswap.h +1 -1
index 5cc4acb..52fc7b6 100644
@@ -24,7 +24,7 @@ static inline uint32_t default_swab32(uint32_t val)
 	if (__builtin_constant_p(x)) { \
 		__res = default_swab32(x); \
 	} else { \
-		__asm__("bswap %0" : "=r" (__res) : "0" (x)); \
+		__asm__("bswap %0" : "=r" (__res) : "0" ((uint32_t)(x))); \
 	} \
 	__res; })
Signature · 1 line
1.6.5.2.102.g442a9