Skip to contentSkip to conversation

perf-record & perf-report in root directory: can't find binaries for symbol resolution

PATCH Alan Jenkins 1 participant 1 message Oct 31, 2009 perf events

lore
Share & tools
lore
#0 lore raw

Hi,

When I ran perf record & report in the root directory, I noticed that perf couldn't find any binaries. Both addresses and the actual names of the binaries were printed as raw hex values:

# Overhead          Command  Shared Object  Symbol
# ........  ...............  .............  ......
#
    14.23%         modprobe       b777ce85  [.] 0x000000b777ce85
                |
                |--9.52%-- 0x804cad2
                |          0x8049b32

Strace showed that perf report was trying to open ".sbin/modprobe". I found a one-line fix, which should at least explain my problem:

---------------------------------------------

Quoted 1 line

From a2eb15237fee2276fc8e388f9e15409ed7caf9e1 Mon Sep 17 00:00:00 2001

From: Alan Jenkins <[email protected]>
Date: Fri, 30 Oct 2009 14:12:30 +0000
Subject: [PATCH] perf tools: fix test for whether pathnames can be shortened

The intention is to consider the pair (filename, cwd) and shorten the filename if it lives under cwd. E.g. ("/src/foo", "/src") -> "./foo".

Make the test more specific to exclude these unintended consequences:

    ("/src/foo", "/") -> ".src/foo"
    ("/src/foo", "/s") -> ".rc/foo"
---
 tools/perf/util/map.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
tools/perf/util/map.c +1 -1
index 804e023..bd17703 100644
@@ -31,7 +31,7 @@ static int strcommon(const char *pathname, char *cwd, int cwdlen)
 		if (cwd) {
 			int n = strcommon(filename, cwd, cwdlen);
 
-			if (n == cwdlen) {
+			if (n == cwdlen && filename[n] == '/') {
 				snprintf(newfilename, sizeof(newfilename),
 					 ".%s", filename + n);
 				filename = newfilename;
Signature · 1 line
1.6.3.2