Skip to contentSkip to conversation

opensm/osm_sa_mcmember_record.c: fsmall code optimization

PATCH Applied Yevgeny Kliteynik 2 participants 2 messages Nov 1, 2009 – Nov 2, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore

Yevgeny Kliteynik

author
#0 lore raw

PATCH 1/1 opensm/osm_sa_mcmember_record.c: fsmall code optimization

Further optimization in comparison to zero mgid -
use existing function to check whether the mgid
is all zero.

Signed-off-by Yevgeny Kliteynik <[email protected]>
---
 opensm/opensm/osm_sa_mcmember_record.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
opensm/opensm/osm_sa_mcmember_record.c +1 -7
index 18dc22c..4ae6be6 100644
@@ -731,7 +731,6 @@ static ib_api_status_t mcmr_rcv_create_new_mgrp(IN osm_sa_t * sa,
 						OUT osm_mgrp_t ** pp_mgrp)
 {
 	ib_net16_t mlid;
-	unsigned zero_mgid = 1;
 	uint8_t scope;
 	ib_gid_t *p_mgid;
 	ib_api_status_t status = IB_SUCCESS;

@@ -739,11 +738,6 @@ static ib_api_status_t mcmr_rcv_create_new_mgrp(IN osm_sa_t * sa,
 
 	OSM_LOG_ENTER(sa->p_log);
 
-	/* but what if the given MGID was not 0 ? */
-	if (p_recvd_mcmember_rec->mgid.unicast.prefix != 0 ||
-	    p_recvd_mcmember_rec->mgid.unicast.interface_id != 0)
-		zero_mgid = 0;
-
 	/*
 	   we allocate a new mlid number before we might use it
 	   for MGID ...

@@ -761,7 +755,7 @@ static ib_api_status_t mcmr_rcv_create_new_mgrp(IN osm_sa_t * sa,
 		"Obtained new mlid 0x%X\n", cl_ntoh16(mlid));
 
 	/* we need to create the new MGID if it was not defined */
-	if (zero_mgid) {
+	if (!ib_gid_is_notzero(&p_recvd_mcmember_rec->mgid)) {
 		/* create a new MGID */
 		char gid_str[INET6_ADDRSTRLEN];
Signature · 6 lines
1.5.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4AEE0DDB.3050606-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org