Skip to contentSkip to conversation

DaVinci EMAC: correct param for ISR

PATCH Applied Tonyliu 2 participants 2 messages Nov 3, 2009 – Nov 4, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Tonyliu

author
#0 lore raw

PATCH 1/1 DaVinci EMAC: correct param for ISR

Quoted 1 line

From bf855d3a1f824ab87933a64c9fc93f859b064e92 Mon Sep 17 00:00:00 2001

From: Tonyliu <[email protected]>
Date: Wed, 28 Oct 2009 11:06:48 +0800
Subject: [PATCH 1/1] DaVinci EMAC: correct param for ISR

emac_irq is declared as:

static irqreturn_t emac_irq(int irq, void *dev_id)

{
       struct net_device *ndev = (struct net_device *)dev_id;
       struct emac_priv *priv = netdev_priv(ndev);
    ... 

	Clearly emac_irq() needs "struct net_device *" as "void *dev_id", so correct this.
Signed-off-by Tonyliu <[email protected]>
---
 drivers/net/davinci_emac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/davinci_emac.c +1 -1
index a876dce..4cf80ec 100644
@@ -2217,7 +2217,7 @@ void emac_poll_controller(struct net_device *ndev)
 	struct emac_priv *priv = netdev_priv(ndev);
 
 	emac_int_disable(priv);
-	emac_irq(ndev->irq, priv);
+	emac_irq(ndev->irq, ndev);
 	emac_int_enable(priv);
 }
 #endif
Signature · 1 line
1.5.5.4
maintainer Applied
#1 lore raw

From: Tonyliu <[email protected]>
Date: Tue, 03 Nov 2009 09:52:22 +0800

Quoted 5 lines

Subject: [PATCH 1/1] DaVinci EMAC: correct param for ISR

emac_irq is declared as:

static irqreturn_t emac_irq(int irq, void *dev_id)

Quoted 8 lines
{
       struct net_device *ndev = (struct net_device *)dev_id;
       struct emac_priv *priv = netdev_priv(ndev);
    ... 

	Clearly emac_irq() needs "struct net_device *" as "void *dev_id", so correct this.
Signed-off-by Tonyliu <[email protected]>

Applied to net-2.6, thank you.