Skip to contentSkip to conversation

tmscsim: Missing parentheses in dc390_init_hw()?

PATCH Roel Kluin 2 participants 2 messages Nov 3, 2009 SCSI

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

Same oddness, are there parentheses missing here?

Thanks, Roel

drivers/scsi/tmscsim.c +2 -2
index 9a42734..25e6d63 100644
@@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index)
 
 	/* Negation */
 	DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */
-		(dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
-		 NEGATE_REQACKDATA : 0);
+		((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
+		 NEGATE_REQACKDATA : 0));
 	
 	/* Clear Transfer Count High: ID */
 	DC390_write8(CtcReg_High, 0);
#1 lore raw
Quoted 9 lines · Roel Kluin

Same oddness, are there parentheses missing here?

Thanks, Roel

drivers/scsi/tmscsim.c +0 -0
index 9a42734..25e6d63 100644

drivers/scsi/tmscsim.c static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index) · line 2412

Quoted 7 lines
drivers/scsi/tmscsim.c +2 -2
@@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index)
 
 	/* Negation */
 	DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */
-		(dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
-		 NEGATE_REQACKDATA : 0);
+		((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
+		 NEGATE_REQACKDATA : 0));

This one looks more possible ... but given it's hw init, the original meaning is also possible ... and supported by the fact that the hw works.

James