Don't build SSB modules when SSB isn't present
PATCH 1/1 Don't build SSB modules when SSB isn't present
From: Philip A Prindeville <[email protected]>
If you're building for a platform that has (for example) no SSB, then having a single knob to turn to disable this is a major win. Especially if more devices get add later that are SSB-based.
Tested.
--- config.mk | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-)
config.mk +8 -6
@@ -9,6 +9,8 @@ ifeq ($(wildcard $(KLIB_BUILD)/.config),) CONFIG_PCI=y CONFIG_USB=y CONFIG_PCMCIA=y + CONFIG_SSB_POSSIBLE=y + CONFIG_SSB=m else include $(KLIB_BUILD)/.config endif
@@ -218,6 +220,11 @@ CONFIG_IPW2200_QOS=y # # % echo 1 > /sys/bus/pci/drivers/ipw2200/*/rtap_iface +ifneq ($(CONFIG_SSB),) +# Sonics Silicon Backplane +CONFIG_SSB_SPROM=y +# CONFIG_SSB_DEBUG=y + CONFIG_SSB_BLOCKIO=y CONFIG_SSB_PCIHOST_POSSIBLE=y CONFIG_SSB_PCIHOST=y
@@ -229,6 +236,7 @@ endif # CONFIG_SSB_DEBUG=y CONFIG_SSB_DRIVER_PCICORE_POSSIBLE=y CONFIG_SSB_DRIVER_PCICORE=y +endif CONFIG_P54_PCI=m
@@ -397,12 +405,6 @@ CONFIG_WL1251_SPI=m CONFIG_WL1251_SDIO=m CONFIG_WL1271=m -# Sonics Silicon Backplane -CONFIG_SSB_POSSIBLE=y -CONFIG_SSB=m -CONFIG_SSB_SPROM=y -# CONFIG_SSB_DEBUG=y - ifdef CONFIG_COMPAT_WIRELESS_27 CONFIG_LIBERTAS=n else
Luis R. Rodriguez
AppliedQuoted 5 lines · Philip A. Prindeville
From: Philip A Prindeville <[email protected]>
If you're building for a platform that has (for example) no SSB, then having a single knob to turn to disable this is a major win. Especially if more devices get add later that are SSB-based.
Applied, thanks. Just one comment below.
Quoted 10 lines
Signed-off-by Philip A Prindeville <[email protected]>---
config.mk | 14 ++++++++------1 files changed, 8 insertions(+), 6 deletions(-)config.mk +0
-0@@ -9,6 +9,8 @@ ifeq ($(wildcard $(KLIB_BUILD)/.config),)
Quoted 5 lines
CONFIG_PCI=y
CONFIG_USB=y
CONFIG_PCMCIA=y
+CONFIG_SSB_POSSIBLE=y
+CONFIG_SSB=m
This works only if you don't have SSB on your kernel as otherwise I believe regardless of this you'll end up coming ssb. So if you want to enable not compiling ssb we'd have to use another config option like CONFIG_COMPAT_26_SSB and use that in the makefile. But another easier option is to just enable *only* want you want in compat-wireless by using ./scripts/driver-select. In the future we may want to take porting the kernel's existing kconfig over and using mconf for example to enable menuconfig. But to get that working right we'd need to invent our own kconfig entries and replaces the kernels's with our own. An issue might also be in trying to ensure the new invented kconfig won't bust a kernel with its own kconfig entries.
Luis