Skip to contentSkip to conversation

mac80211: fix broadcast frame handling for 4-addr AP VLANs

PATCH New Felix Fietkau 1 participant 1 message Nov 11, 2009 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: fix broadcast frame handling for 4-addr AP VLANs

Without this patch, broadcast frames from the station behind a 4-addr AP VLAN would be reflected back to the source. Fix this by checking the 4-addr flag before bridging multicast frames in the cell.

---
I hadn't noticed that v2 of my mac80211 4-addr patch had been merged already, so here's the fix from v3 as a separate patch

net/mac80211/rx.c +1 -1
@@ -1292,7 +1292,7 @@ ieee80211_deliver_skb(struct ieee80211_r
 	if ((sdata->vif.type == NL80211_IFTYPE_AP ||
 	     sdata->vif.type == NL80211_IFTYPE_AP_VLAN) &&
 	    !(sdata->flags & IEEE80211_SDATA_DONT_BRIDGE_PACKETS) &&
-	    (rx->flags & IEEE80211_RX_RA_MATCH)) {
+	    (rx->flags & IEEE80211_RX_RA_MATCH) && !rx->sdata->use_4addr) {
 		if (is_multicast_ether_addr(ehdr->h_dest)) {
 			/*
 			 * send multicast frames both to higher layers in