Skip to contentSkip to conversation

jffs2: Fix error return in jffs2_do_read_inode_internal()

PATCH In review Roel Kluin 2 participants 2 messages Nov 12, 2009 – Nov 13, 2009

Subsystems (2)
Memory technology devices (MTD) Journalling flash file system V2 (JFFS2)
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 jffs2: Fix error return in jffs2_do_read_inode_internal()

The returned error should stay negative

Signed-off-by Roel Kluin <[email protected]>
---
 fs/jffs2/readinode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/jffs2/readinode.c +1 -1
index 1a80301..9c26738 100644
@@ -1284,7 +1284,7 @@ static int jffs2_do_read_inode_internal(struct jffs2_sb_info *c,
 				f->target = NULL;
 				mutex_unlock(&f->sem);
 				jffs2_do_clear_inode(c, f);
-				return -ret;
+				return ret;
 			}
 
 			f->target[je32_to_cpu(latest_node->csize)] = '\0';
#1 lore raw
Quoted 6 lines · Roel Kluin

The returned error should stay negative

Signed-off-by Roel Kluin <[email protected]>
---
 fs/jffs2/readinode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Taken to my l2-mtd-2.6 tree, thanks.

Signature · 2 lines
Best Regards,
Artem Bityutskiy (Артём Битюцкий)