Skip to contentSkip to conversation

x86: Don't put iommu_shutdown_noop() in init section

PATCH In review Hiroshi Shimamoto 2 participants 3 messages Nov 16, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Don't put iommu_shutdown_noop() in init section

From: Hiroshi Shimamoto <[email protected]>

It causes kernel panic on shutdown or reboot.

---
 arch/x86/kernel/x86_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/x86_init.c +1 -1
index 80f3ae2..d11c5ff 100644
@@ -20,7 +20,7 @@ void __cpuinit x86_init_noop(void) { }
 void __init x86_init_uint_noop(unsigned int unused) { }
 void __init x86_init_pgd_noop(pgd_t *unused) { }
 int __init iommu_init_noop(void) { return 0; }
-void __init iommu_shutdown_noop(void) { }
+void iommu_shutdown_noop(void) { }
 
 /*
  * The platform setup functions are preset with the default functions
Signature · 1 line
1.6.3.3
#2 lore raw
In reply to Hiroshi Shimamoto
Commit-ID:  62ad33f67003b9a7b6013f0511579b9805e11626
Gitweb:     http://git.kernel.org/tip/62ad33f67003b9a7b6013f0511579b9805e11626
Author:     Hiroshi Shimamoto <[email protected]>
AuthorDate: Mon, 16 Nov 2009 11:44:30 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 16 Nov 2009 08:58:51 +0100

x86: Don't put iommu_shutdown_noop() in init section

It causes kernel panic on shutdown or reboot.

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/x86_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/x86_init.c +1 -1
index 80f3ae2..d11c5ff 100644
@@ -20,7 +20,7 @@ void __cpuinit x86_init_noop(void) { }
 void __init x86_init_uint_noop(unsigned int unused) { }
 void __init x86_init_pgd_noop(pgd_t *unused) { }
 int __init iommu_init_noop(void) { return 0; }
-void __init iommu_shutdown_noop(void) { }
+void iommu_shutdown_noop(void) { }
 
 /*
  * The platform setup functions are preset with the default functions