Skip to contentSkip to conversation

radio-si470x: fix SYSCONFIG1 register set on si470x_start()

PATCH In review Joonyoung Shim 2 participants 5 messages Nov 18, 2009 – Dec 2, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 radio-si470x: fix SYSCONFIG1 register set on si470x_start()

We should use the or operation to set value to the SYSCONFIG1 register on si470x_start().

---
 drivers/media/radio/si470x/radio-si470x-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/si470x/radio-si470x-common.c +1 -1
index f33315f..09f631a 100644
@@ -357,7 +357,7 @@ int si470x_start(struct si470x_device *radio)
 		goto done;
 
 	/* sysconfig 1 */
-	radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
+	radio->registers[SYSCONFIG1] |= SYSCONFIG1_DE;
 	retval = si470x_set_register(radio, SYSCONFIG1);
 	if (retval < 0)
 		goto done;
Signature · 1 line
1.6.0.4
#1 lore raw

Hi,

what is the advantage in not setting SYSCONFIG1 into a known state?

Bye,
Toby

Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim:

Quoted 22 lines

We should use the or operation to set value to the SYSCONFIG1 register on si470x_start().

---
 drivers/media/radio/si470x/radio-si470x-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/si470x/radio-si470x-common.c +1 -1
index f33315f..09f631a 100644
@@ -357,7 +357,7 @@ int si470x_start(struct si470x_device *radio)
 		goto done;
 
 	/* sysconfig 1 */
-	radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
+	radio->registers[SYSCONFIG1] |= SYSCONFIG1_DE;
 	retval = si470x_set_register(radio, SYSCONFIG1);
 	if (retval < 0)
 		goto done;
#2 lore raw

Hi, Tobias.

Quoted 4 lines · Tobias Lorenz

Hi,

what is the advantage in not setting SYSCONFIG1 into a known state?

At patch 3/3, i am setting the SYSCONFIG1 register for RDS interrupt in i2c probe function, so i need this patch. Do you have other idea?

Quoted 27 lines

Bye,
Toby

Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim:

Quoted 22 lines

We should use the or operation to set value to the SYSCONFIG1 register on si470x_start().

---
 drivers/media/radio/si470x/radio-si470x-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/si470x/radio-si470x-common.c +1 -1
index f33315f..09f631a 100644
@@ -357,7 +357,7 @@ int si470x_start(struct si470x_device *radio)
 		goto done;
 
 	/* sysconfig 1 */
-	radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
+	radio->registers[SYSCONFIG1] |= SYSCONFIG1_DE;
 	retval = si470x_set_register(radio, SYSCONFIG1);
 	if (retval < 0)
 		goto done;
#3 lore raw

Hi,

ok, understood this problem.
So, why not set this in si470x_fops_open directly after the si470x_start? It seems more appropriate to enable the RDS interrupt after starting the radio.

Bye the way, you pointed me to a bug. Instead of always setting de-emphasis in si470x_start:
radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
This should only be done, if requested by module parameter:
radio->registers[SYSCONFIG1] = (de << 11) & SYSCONFIG1_DE; /* DE */

Bye,
Toby

Am Mittwoch 02 Dezember 2009 00:54:15 schrieb Joonyoung Shim:

Quoted 39 lines

Hi, Tobias.

Quoted 4 lines · Tobias Lorenz

Hi,

what is the advantage in not setting SYSCONFIG1 into a known state?

At patch 3/3, i am setting the SYSCONFIG1 register for RDS interrupt in i2c probe function, so i need this patch. Do you have other idea?

Quoted 27 lines

Bye,
Toby

Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim:

Quoted 22 lines

We should use the or operation to set value to the SYSCONFIG1 register on si470x_start().

---
 drivers/media/radio/si470x/radio-si470x-common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/radio/si470x/radio-si470x-common.c +1 -1
index f33315f..09f631a 100644
@@ -357,7 +357,7 @@ int si470x_start(struct si470x_device *radio)
 		goto done;
 
 	/* sysconfig 1 */
-	radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
+	radio->registers[SYSCONFIG1] |= SYSCONFIG1_DE;
 	retval = si470x_set_register(radio, SYSCONFIG1);
 	if (retval < 0)
 		goto done;
#4 lore raw
Quoted 6 lines · Tobias Lorenz

Hi,

ok, understood this problem.
So, why not set this in si470x_fops_open directly after the si470x_start? It seems more appropriate to enable the RDS interrupt after starting the radio.

OK, it makes sense. I will move it in si470x_fops_open.

Quoted 5 lines

Bye the way, you pointed me to a bug. Instead of always setting de-emphasis in si470x_start:
radio->registers[SYSCONFIG1] = SYSCONFIG1_DE;
This should only be done, if requested by module parameter:
radio->registers[SYSCONFIG1] = (de << 11) & SYSCONFIG1_DE; /* DE */

Ah, That's right.

Thanks.