libselinux: selabel_*() support for database objects
PATCH 1/1 libselinux: selabel_*() support for database objects
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The specfile shall be described as follows:
------------------------
#
# The specfile for database objects
# (for SE-PostgreSQL)
#
# <object class> <object name> <security context> #
db_database * system_u:object_r:sepgsql_db_t:s0
db_schema *.pg_catalog system_u:obejct_r:sepgsql_sys_schema_t:s0 db_schema *.* system_u:object_r:sepgsql_schema_t:s0
db_table *.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0 db_table *.*.* system_u:object_r:sepgsql_table_t:s0
------------------------
- All the characters after the '#' are ignored.
- Wildcards ('*' and '?') are available.
- It returns the first match security context.
Note that hierarchy of the namespace of database objects depends on RDBMS. So, author of the specfile needs to write correct patterns which are suitable for the target RDBMS. The patched selabel_*() interfaces don't have any heuristics for the namespace hierarchy to be suitable for widespread RDBMSs. In the case of SE-PgSQL, when we lookup an expected security context for the 'my_table' table in the 'public' schema and 'postgres' database, the caller shall provide 'postgres.public.my_table' as a key.
In the default, it tries to read a specfile which maps database objects and security context from the /etc/selinux/$POLICYTYPE/contexts/sepgsql_contexts. Note that when another RDBMS uses this interface, it needs to give an explicit SELABEL_OPT_PATH option on the selabel_open().
libselinux/include/selinux/label.h +11 -0
@@ -29,6 +29,8 @@ struct selabel_handle;#define SELABEL_CTX_MEDIA 1/* x contexts */ #define SELABEL_CTX_X 2 +/* db objects */ +#define SELABEL_CTX_DB 3/* * Available options
@@ -116,6 +118,15 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_X_POLYPROP 6#define SELABEL_X_POLYSELN 7 +/* DB backend */ +#define SELABEL_DB_DATABASE 1 +#define SELABEL_DB_SCHEMA 2 +#define SELABEL_DB_TABLE 3 +#define SELABEL_DB_COLUMN 4 +#define SELABEL_DB_TUPLE 5 +#define SELABEL_DB_PROCEDURE 6 +#define SELABEL_DB_SEQUENCE 7 +#define SELABEL_DB_BLOB 8 #ifdef __cplusplus }
libselinux/include/selinux/selinux.h +1 -0
@@ -487,6 +487,7 @@ extern const char *selinux_media_context_path(void);extern const char *selinux_virtual_domain_context_path (void );extern const char *selinux_virtual_image_context_path (void );extern const char *selinux_x_context_path (void ); +extern const char *selinux_sepgsql_context_path (void );extern const char *selinux_contexts_path (void );extern const char *selinux_securetty_types_path (void );extern const char *selinux_booleans_path (void );
libselinux/man/man3/selabel_open.3 +7 -3
@@ -72,15 +72,19 @@ Note that an invalid context may not be treated as an error unless it is actuall .TP .B SELABEL_CTX_FILE File contexts backend, described in -.BR selabel_file (3). +.BR selabel_file (5). .TP .B SELABEL_CTX_MEDIA Media contexts backend, described in -.BR selabel_media (3). +.BR selabel_media (5). .TP .B SELABEL_CTX_X X Windows contexts backend, described in -.BR selabel_x (3). +.BR selabel_x (5). +.TP +.B SELABEL_CTX_DB +Database objects contexts backend, described in +.BR selabel_db (5). .SH "RETURN VALUE" A non-NULL handle value is returned on success. On error, NULL is returned and
libselinux/man/man3/selinux_binary_policy_path.3 +4 -0
@@ -29,6 +29,8 @@ extern const char *selinux_usersconf_path(void); extern const char *selinux_x_context_path(void); +extern const char *selinux_sepgsql_context_path(void); + extern const char *selinux_file_context_path(void); extern const char *selinux_media_context_path(void);
@@ -66,6 +68,8 @@ selinux_usersconf_path() - file containing mapping between Linux Users and SELin .sp selinux_x_context_path() - file containing configuration for XSELinux extension .sp +selinux_sepgsql_context_path() - file containing configuration for SE-PostgreSQL +.sp selinux_netfilter_context_path - default netfilter context .sp selinux_file_context_path() - default sysstem file contexts configuration
libselinux/man/man5/selabel_db.5 new file +93 -0
93 lines not on this page · raw message
libselinux/src/file_path_suffixes.h +1 -0
@@ -23,3 +23,4 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") +S_ (SEPGSQL_CONTEXTS ,"/contexts/sepgsql_contexts" )
libselinux/src/label.c +2 -1
@@ -22,7 +22,8 @@ typedef int (*selabel_initfunc)(struct selabel_handle *rec,static selabel_initfunc initfuncs[] = { &selabel_file_init, &selabel_media_init, - &selabel_x_init + &selabel_x_init, + &selabel_db_init, }; typedef struct selabel_sub {
libselinux/src/label_db.c new file +334 -0
334 lines not on this page · raw message
libselinux/src/label_internal.h +2 -0
@@ -23,6 +23,8 @@ int selabel_media_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; int selabel_x_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; +int selabel_db_init(struct selabel_handle *rec, + struct selinux_opt *opts, unsigned nopts) hidden;/* * Labeling internal structures
libselinux/src/selinux_config.c +8 -1
@@ -44,7 +44,8 @@#define VIRTUAL_DOMAIN 21#define VIRTUAL_IMAGE 22#define FILE_CONTEXT_SUBS 23 -#define NEL 24 +#define SEPGSQL_CONTEXTS 24 +#define NEL 25/* Part of one-time lazy init */ static pthread_once_t once =PTHREAD_ONCE_INIT ;
@@ -422,3 +423,9 @@ const char * selinux_file_context_subs_path(void) {hidden_def (selinux_file_context_subs_path) +const char *selinux_sepgsql_context_path() +{ +return get_path (SEPGSQL_CONTEXTS ); +} + +hidden_def (selinux_sepgsql_context_path)
libselinux/src/selinux_internal.h +1 -0
@@ -73,6 +73,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_path) hidden_proto(selinux_check_passwd_access) hidden_proto(selinux_check_securetty_context)
Signature · 7 lines
OSS Platform Development Division, NEC KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 5 lines · KaiGai Kohei
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The patch is whitespace damaged, can you re-send it as a text attachment.
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 7 lines · Eamon Walsh
Quoted 3 lines · KaiGai Kohei
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The patch is whitespace damaged, can you re-send it as a text attachment.
Does the attached one still damaged?
Signature · 1 line
KaiGai Kohei <[email protected]>
include/selinux/label.h | 11 + include/selinux/selinux.h | 1 man/man3/selabel_open.3 | 10 - man/man3/selinux_binary_policy_path.3 | 6 man/man5/selabel_db.5 | 93 +++++++++ src/file_path_suffixes.h | 1 src/label.c | 3 src/label_db.c | 334 ++++++++++++++++++++++++++++++++++ src/label_internal.h | 2 src/selinux_config.c | 9 src/selinux_internal.h | 1 11 files changed, 466 insertions(+), 5 deletions(-)
Quoted 10 lines · KaiGai Kohei
Quoted 6 lines · Eamon Walsh
Quoted 3 lines · KaiGai Kohei
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The patch is whitespace damaged, can you re-send it as a text attachment.
Does the attached one still damaged?
Sorry, my careless misses. It didn't attach the patch body.
The attached one contains the patch with tab-indents.
Thanks,
Signature · 2 lines
OSS Platform Development Division, NEC KaiGai Kohei <[email protected]>
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The specfile shall be described as follows:
------------------------
#
# The specfile for database objects
# (for SE-PostgreSQL)
#
# <object class> <object name> <security context> #
db_database * system_u:object_r:sepgsql_db_t:s0
db_schema *.pg_catalog system_u:obejct_r:sepgsql_sys_schema_t:s0 db_schema *.* system_u:object_r:sepgsql_schema_t:s0
db_table *.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0 db_table *.*.* system_u:object_r:sepgsql_table_t:s0
------------------------
- All the characters after the '#' are ignored.
- Wildcards ('*' and '?') are available.
- It returns the first match security context.
Note that hierarchy of the namespace of database objects depends on RDBMS. So, author of the specfile needs to write correct patterns which are suitable for the target RDBMS. The patched selabel_*() interfaces don't have any heuristics for the namespace hierarchy to be suitable for widespread RDBMSs. In the case of SE-PgSQL, when we lookup an expected security context for the 'my_table' table in the 'public' schema and 'postgres' database, the caller shall provide 'postgres.public.my_table' as a key.
In the default, it tries to read a specfile which maps database objects and security context from the /etc/selinux/$POLICYTYPE/contexts/sepgsql_contexts. Note that when another RDBMS uses this interface, it needs to give an explicit SELABEL_OPT_PATH option on the selabel_open().
--
include/selinux/label.h | 11 + include/selinux/selinux.h | 1 man/man3/selabel_open.3 | 10 - man/man3/selinux_binary_policy_path.3 | 4 man/man5/selabel_db.5 | 93 +++++++++ src/file_path_suffixes.h | 1 src/label.c | 3 src/label_db.c | 334 ++++++++++++++++++++++++++++++++++ src/label_internal.h | 2 src/selinux_config.c | 9 src/selinux_internal.h | 1 11 files changed, 464 insertions(+), 5 deletions(-)
libselinux/include/selinux/label.h +11 -0
@@ -29,6 +29,8 @@ struct selabel_handle;#define SELABEL_CTX_MEDIA 1/* x contexts */ #define SELABEL_CTX_X 2 +/* db objects */ +#define SELABEL_CTX_DB 3/* * Available options
@@ -116,6 +118,15 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_X_POLYPROP 6#define SELABEL_X_POLYSELN 7 +/* DB backend */ +#define SELABEL_DB_DATABASE 1 +#define SELABEL_DB_SCHEMA 2 +#define SELABEL_DB_TABLE 3 +#define SELABEL_DB_COLUMN 4 +#define SELABEL_DB_TUPLE 5 +#define SELABEL_DB_PROCEDURE 6 +#define SELABEL_DB_SEQUENCE 7 +#define SELABEL_DB_BLOB 8 #ifdef __cplusplus }
libselinux/include/selinux/selinux.h +1 -0
@@ -487,6 +487,7 @@ extern const char *selinux_media_context_path(void);extern const char *selinux_virtual_domain_context_path (void );extern const char *selinux_virtual_image_context_path (void );extern const char *selinux_x_context_path (void ); +extern const char *selinux_sepgsql_context_path (void );extern const char *selinux_contexts_path (void );extern const char *selinux_securetty_types_path (void );extern const char *selinux_booleans_path (void );
libselinux/man/man3/selabel_open.3 +7 -3
@@ -72,15 +72,19 @@ Note that an invalid context may not be treated as an error unless it is actuall .TP .B SELABEL_CTX_FILE File contexts backend, described in -.BR selabel_file (3). +.BR selabel_file (5). .TP .B SELABEL_CTX_MEDIA Media contexts backend, described in -.BR selabel_media (3). +.BR selabel_media (5). .TP .B SELABEL_CTX_X X Windows contexts backend, described in -.BR selabel_x (3). +.BR selabel_x (5). +.TP +.B SELABEL_CTX_DB +Database objects contexts backend, described in +.BR selabel_db (5). .SH "RETURN VALUE" A non-NULL handle value is returned on success. On error, NULL is returned and
libselinux/man/man3/selinux_binary_policy_path.3 +4 -0
@@ -29,6 +29,8 @@ extern const char *selinux_usersconf_path(void); extern const char *selinux_x_context_path(void); +extern const char *selinux_sepgsql_context_path(void); + extern const char *selinux_file_context_path(void); extern const char *selinux_media_context_path(void);
@@ -66,6 +68,8 @@ selinux_usersconf_path() - file containing mapping between Linux Users and SELin .sp selinux_x_context_path() - file containing configuration for XSELinux extension .sp +selinux_sepgsql_context_path() - file containing configuration for SE-PostgreSQL +.sp selinux_netfilter_context_path - default netfilter context .sp selinux_file_context_path() - default sysstem file contexts configuration
libselinux/man/man5/selabel_db.5 new file +93 -0
93 lines not on this page · raw message
libselinux/src/file_path_suffixes.h +1 -0
@@ -23,3 +23,4 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") +S_ (SEPGSQL_CONTEXTS ,"/contexts/sepgsql_contexts" )
libselinux/src/label.c +2 -1
@@ -22,7 +22,8 @@ typedef int (*selabel_initfunc)(struct selabel_handle *rec,static selabel_initfunc initfuncs[] = { &selabel_file_init, &selabel_media_init, - &selabel_x_init + &selabel_x_init, + &selabel_db_init, }; typedef struct selabel_sub {
libselinux/src/label_db.c new file +334 -0
334 lines not on this page · raw message
libselinux/src/label_internal.h +2 -0
@@ -23,6 +23,8 @@ int selabel_media_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; int selabel_x_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; +int selabel_db_init(struct selabel_handle *rec, + struct selinux_opt *opts, unsigned nopts) hidden;/* * Labeling internal structures
libselinux/src/selinux_config.c +8 -1
@@ -44,7 +44,8 @@#define VIRTUAL_DOMAIN 21#define VIRTUAL_IMAGE 22#define FILE_CONTEXT_SUBS 23 -#define NEL 24 +#define SEPGSQL_CONTEXTS 24 +#define NEL 25/* Part of one-time lazy init */ static pthread_once_t once =PTHREAD_ONCE_INIT ;
@@ -422,3 +423,9 @@ const char * selinux_file_context_subs_path(void) {hidden_def (selinux_file_context_subs_path) +const char *selinux_sepgsql_context_path() +{ +return get_path (SEPGSQL_CONTEXTS ); +} + +hidden_def (selinux_sepgsql_context_path)
libselinux/src/selinux_internal.h +1 -0
@@ -73,6 +73,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_path) hidden_proto(selinux_check_passwd_access) hidden_proto(selinux_check_securetty_context)
Eamon Walsh
Acked-byQuoted 13 lines · KaiGai Kohei
Quoted 11 lines · KaiGai Kohei
Quoted 9 lines · Eamon Walsh
Quoted 4 lines · KaiGai Kohei
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The patch is whitespace damaged, can you re-send it as a text attachment.
Quoted 9 lines
Quoted 3 lines
Does the attached one still damaged?
Sorry, my careless misses. It didn't attach the patch body.
The attached one contains the patch with tab-indents.
Thanks,
Looks good to me,
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 21 lines · Eamon Walsh
Quoted 20 lines · KaiGai Kohei
Quoted 4 lines · KaiGai Kohei
Quoted 2 lines · Eamon Walsh
On 11/19/2009 03:21 AM, KaiGai Kohei wrote:
Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
This patch allows selabel_*() interfaces to provide an expected security context for the given database object identified by its name and object class. It is necessary to implement a feature something like the restorecon on databases.
The patch is whitespace damaged, can you re-send it as a text attachment.
Does the attached one still damaged?
Sorry, my careless misses. It didn't attach the patch body.
The attached one contains the patch with tab-indents.
Quoted 7 lines
Quoted 2 lines
Thanks,
Looks good to me,
Acked-by Eamon Walsh<[email protected]>
What is the current status of the patch?
Thanks,
Signature · 6 lines
KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample sepgsql_contexts file so I can test this?
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 12 lines · Eamon Walsh
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample
sepgsql_contextsfile so I can test this?
Regarding the sepgsql_contexts name, is this functionality targeted only for sepgsql, or would another DBMS be able to us it (e.g, Trusted RUBIX)? if others would be able to use the functionality, would each DBMS have their own *_contexts file, or would all use sepgsql_contexts?
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 16 lines · Andy Warner
Quoted 12 lines · Eamon Walsh
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample
sepgsql_contextsfile so I can test this?
Quoted 5 lines
Regarding the
sepgsql_contextsname, is this functionality targeted only for sepgsql, or would another DBMS be able to us it (e.g, Trusted RUBIX)? if others would be able to use the functionality, would each DBMS have their own*_contextsfile, or would all usesepgsql_contexts?
It allows to give a path to be parsed using SELABEL_OPT_PATH option. The "sepgsql_context" is just a default.
Thanks,
Signature · 6 lines
KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 10 lines · Eamon Walsh
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample
sepgsql_contextsfile so I can test this?
The attached selabel-test.conf is an example specfile, and the selabel-test.c is a sample program to lookup an expected security context for the given name.
$ gcc selabel-test.c -o selabel-test -lselinux \
-I repo/selinux/libselinux/include/ \
-L repo/selinux/libselinux/src/
$ ./selabel-test selabel-test.conf db_table postgres.pg_catalog.pg_class
"postgres.pg_catalog.pg_class" => "system_u:object_r:sepgsql_sysobj_t:s0"
$ ./selabel-test selabel-test.conf db_table postgres.pg_public.my_table
"postgres.pg_public.my_table" => "system_u:object_r:sepgsql_table_t:s0"
$ ./selabel-test selabel-test.conf db_table foovarbaz
failed to lookup : "foovarbaz" (No such file or directory)In PostgreSQL, its namespace has the following structure:
<database>.<schema>.(<table>|<view>|<procedure>|...)
So, the example specfile defines the following lines:
db_table *.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0
It informs all tables under the "pg_catalog" schema should be labeled as "system_u:object_r:sepgsql_sysobj_t:s0".
Andy, in rubix, the specfile should be described as follows:
db_table *.*.*.* system_u:object_r:rubix_table_t:s0
The library just does pattern matching without any assumption of database architecture.
I also noticed the previous patch allows to lookup an expected security context for the db_tuple object class, but tuples don't have their name basically, so I removed it.
And, it didn't support an upcoming db_view object class, I added it instead.
Thanks,
Signature · 1 line
KaiGai Kohei <[email protected]>
--
libselinux/include/selinux/label.h | 11 +++++++++++ libselinux/include/selinux/selinux.h | 1 + libselinux/man/man3/selabel_open.3 | 10 +++++++--- libselinux/man/man3/selinux_binary_policy_path.3 | 4 ++++ libselinux/src/file_path_suffixes.h | 1 + libselinux/src/label.c | 3 ++- libselinux/src/label_internal.h | 2 ++ libselinux/src/selinux_config.c | 9 ++++++++- libselinux/src/selinux_internal.h | 1 + 9 files changed, 37 insertions(+), 5 deletions(-)
libselinux/include/selinux/label.h +11 -0
@@ -29,6 +29,8 @@ struct selabel_handle;#define SELABEL_CTX_MEDIA 1/* x contexts */ #define SELABEL_CTX_X 2 +/* db objects */ +#define SELABEL_CTX_DB 3/* * Available options
@@ -116,6 +118,15 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_X_POLYPROP 6#define SELABEL_X_POLYSELN 7 +/* DB backend */ +#define SELABEL_DB_DATABASE 1 +#define SELABEL_DB_SCHEMA 2 +#define SELABEL_DB_TABLE 3 +#define SELABEL_DB_COLUMN 4 +#define SELABEL_DB_SEQUENCE 5 +#define SELABEL_DB_VIEW 6 +#define SELABEL_DB_PROCEDURE 7 +#define SELABEL_DB_BLOB 8 #ifdef __cplusplus }
libselinux/include/selinux/selinux.h +1 -0
@@ -487,6 +487,7 @@ extern const char *selinux_media_context_path(void);extern const char *selinux_virtual_domain_context_path (void );extern const char *selinux_virtual_image_context_path (void );extern const char *selinux_x_context_path (void ); +extern const char *selinux_sepgsql_context_path (void );extern const char *selinux_contexts_path (void );extern const char *selinux_securetty_types_path (void );extern const char *selinux_booleans_path (void );
libselinux/man/man3/selabel_open.3 +7 -3
@@ -72,15 +72,19 @@ Note that an invalid context may not be treated as an error unless it is actuall .TP .B SELABEL_CTX_FILE File contexts backend, described in -.BR selabel_file (3). +.BR selabel_file (5). .TP .B SELABEL_CTX_MEDIA Media contexts backend, described in -.BR selabel_media (3). +.BR selabel_media (5). .TP .B SELABEL_CTX_X X Windows contexts backend, described in -.BR selabel_x (3). +.BR selabel_x (5). +.TP +.B SELABEL_CTX_DB +Database objects contexts backend, described in +.BR selabel_db (5). .SH "RETURN VALUE" A non-NULL handle value is returned on success. On error, NULL is returned and
libselinux/man/man3/selinux_binary_policy_path.3 +4 -0
@@ -29,6 +29,8 @@ extern const char *selinux_usersconf_path(void); extern const char *selinux_x_context_path(void); +extern const char *selinux_sepgsql_context_path(void); + extern const char *selinux_file_context_path(void); extern const char *selinux_media_context_path(void);
@@ -66,6 +68,8 @@ selinux_usersconf_path() - file containing mapping between Linux Users and SELin .sp selinux_x_context_path() - file containing configuration for XSELinux extension .sp +selinux_sepgsql_context_path() - file containing configuration for SE-PostgreSQL +.sp selinux_netfilter_context_path - default netfilter context .sp selinux_file_context_path() - default system file contexts configuration
libselinux/src/file_path_suffixes.h +1 -0
@@ -23,3 +23,4 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") +S_ (SEPGSQL_CONTEXTS ,"/contexts/sepgsql_contexts" )
libselinux/src/label.c +2 -1
@@ -22,7 +22,8 @@ typedef int (*selabel_initfunc)(struct selabel_handle *rec,static selabel_initfunc initfuncs[] = { &selabel_file_init, &selabel_media_init, - &selabel_x_init + &selabel_x_init, + &selabel_db_init, }; typedef struct selabel_sub {
libselinux/src/label_internal.h +2 -0
@@ -23,6 +23,8 @@ int selabel_media_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; int selabel_x_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; +int selabel_db_init(struct selabel_handle *rec, + struct selinux_opt *opts, unsigned nopts) hidden;/* * Labeling internal structures
libselinux/src/selinux_config.c +8 -1
@@ -44,7 +44,8 @@#define VIRTUAL_DOMAIN 21#define VIRTUAL_IMAGE 22#define FILE_CONTEXT_SUBS 23 -#define NEL 24 +#define SEPGSQL_CONTEXTS 24 +#define NEL 25/* Part of one-time lazy init */ static pthread_once_t once =PTHREAD_ONCE_INIT ;
@@ -422,3 +423,9 @@ const char * selinux_file_context_subs_path(void) {hidden_def (selinux_file_context_subs_path) +const char *selinux_sepgsql_context_path() +{ +return get_path (SEPGSQL_CONTEXTS ); +} + +hidden_def (selinux_sepgsql_context_path)
libselinux/src/selinux_internal.h +1 -0
@@ -73,6 +73,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_path) hidden_proto(selinux_check_passwd_access) hidden_proto(selinux_check_securetty_context)
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
#include <selinux/selinux.h>
#include <selinux/label.h>
int main(int argc, char *argv[])
{
struct selabel_handle *handle;
struct selinux_opt options[1];
security_context_t context;
int tclass;
if (argc != 4)
{
fprintf(stderr, "usage: %s <sepc file> <tclass> <name>\n", argv[0]);
return 1;
}
/* config file to be parsed */
options[0].type = SELABEL_OPT_PATH;
options[0].value = argv[1];
handle = selabel_open(SELABEL_CTX_DB, options, 1);
if (!handle)
{
fprintf(stderr, "selabel_open() failed : %s\n", strerror(errno));
return 1;
}
/* tclass name to type value */
if (strcmp(argv[2], "db_database") == 0)
tclass = SELABEL_DB_DATABASE;
else if (strcmp(argv[2], "db_schema") == 0)
tclass = SELABEL_DB_SCHEMA;
else if (strcmp(argv[2], "db_table") == 0)
tclass = SELABEL_DB_TABLE;
else if (strcmp(argv[2], "db_column") == 0)
tclass = SELABEL_DB_COLUMN;
else if (strcmp(argv[2], "db_sequence") == 0)
tclass = SELABEL_DB_SEQUENCE;
else if (strcmp(argv[2], "db_view") == 0)
tclass = SELABEL_DB_VIEW;
else if (strcmp(argv[2], "db_procedure") == 0)
tclass = SELABEL_DB_PROCEDURE;
else if (strcmp(argv[2], "db_blob") == 0)
tclass = SELABEL_DB_BLOB;
else
{
fprintf(stderr, "unknown object class : %s\n", argv[2]);
return 1;
}
/* looking up spec file */
if (selabel_lookup(handle, &context, argv[3], tclass) < 0)
{
fprintf(stderr, "failed to lookup : \"%s\" (%s)\n",
argv[3], strerror(errno));
return 1;
}
printf("\"%s\" => \"%s\"\n", argv[3], context);
freecon(context);
selabel_close(handle);
return 0;
}#
# The specfile for database objects
# (for SE-PostgreSQL)
#
# <object class> <object name> <security context>
#db_database * system_u:object_r:sepgsql_db_t:s0
db_schema *.pg_catalog system_u:obejct_r:sepgsql_sys_schema_t:s0 db_schema *.* system_u:object_r:sepgsql_schema_t:s0
db_table *.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0 db_table *.*.* system_u:object_r:sepgsql_table_t:s0
db_column *.pg_catalog.*.* system_u:object_r:sepgsql_sysobj_t:s0 db_column *.*.*.* system_u:object_r:sepgsql_table_t:s0
db_sequence *.*.* system_u:object_r:sepgsql_sequence_t:s0
db_view *.*.* system_u:object_r:sepgsql_view_t:s0
db_procedure *.pg_catalog.* system_u:object_r:sepgsql_proc_t:s0 db_procedure *.*.* system_u:object_r:sepgsql_user_proc_t:s0
db_blob *.* system_u:object_r:sepgsql_blob_t:s0
Quoted 42 lines · KaiGai Kohei
Quoted 11 lines · Eamon Walsh
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample
sepgsql_contextsfile so I can test this?The attached selabel-test.conf is an example specfile, and the
selabel-test.cis a sample program to lookup an expected security context for the given name.$ gcc selabel-test.c -o selabel-test -lselinux \ -I repo/selinux/libselinux/include/ \ -L repo/selinux/libselinux/src/ $ ./selabel-test selabel-test.conf db_table postgres.pg_catalog.pg_class "postgres.pg_catalog.pg_class" => "system_u:object_r:sepgsql_sysobj_t:s0" $ ./selabel-test selabel-test.conf db_table postgres.pg_public.my_table "postgres.pg_public.my_table" => "system_u:object_r:sepgsql_table_t:s0" $ ./selabel-test selabel-test.conf db_table foovarbaz failed to lookup : "foovarbaz" (No such file or directory)In PostgreSQL, its namespace has the following structure:
<database>.<schema>.(<table>|<view>|<procedure>|...)So, the example specfile defines the following lines:
db_table*.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0It informs all tables under the "
pg_catalog" schema should be labeled as "system_u:object_r:sepgsql_sysobj_t:s0".Andy, in rubix, the specfile should be described as follows:
db_table*.*.*.* system_u:object_r:rubix_table_t:s0The library just does pattern matching without any assumption of database architecture.
Quoted 7 lines
I also noticed the previous patch allows to lookup an expected security context for the
db_tupleobject class, but tuples don't have their name basically, so I removed it.
And, it didn't support an upcomingdb_viewobject class, I added it instead.Thanks,
This patch is missing the new files label_db.c and selabel_db.5.
Also, in the previous patch, the file selabel_db.c had two instances of trailing whitespace: lines 20 and 55. Please fix those up and re-send.
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 48 lines · Eamon Walsh
Quoted 47 lines · KaiGai Kohei
Quoted 11 lines · Eamon Walsh
Quoted 5 lines · KaiGai Kohei
What is the current status of the patch?
Thanks,
Can you send me a sample
sepgsql_contextsfile so I can test this?The attached selabel-test.conf is an example specfile, and the
selabel-test.cis a sample program to lookup an expected security context for the given name.$ gcc selabel-test.c -o selabel-test -lselinux \ -I repo/selinux/libselinux/include/ \ -L repo/selinux/libselinux/src/ $ ./selabel-test selabel-test.conf db_table postgres.pg_catalog.pg_class "postgres.pg_catalog.pg_class" => "system_u:object_r:sepgsql_sysobj_t:s0" $ ./selabel-test selabel-test.conf db_table postgres.pg_public.my_table "postgres.pg_public.my_table" => "system_u:object_r:sepgsql_table_t:s0" $ ./selabel-test selabel-test.conf db_table foovarbaz failed to lookup : "foovarbaz" (No such file or directory)In PostgreSQL, its namespace has the following structure:
<database>.<schema>.(<table>|<view>|<procedure>|...)So, the example specfile defines the following lines:
db_table*.pg_catalog.* system_u:object_r:sepgsql_sysobj_t:s0It informs all tables under the "
pg_catalog" schema should be labeled as "system_u:object_r:sepgsql_sysobj_t:s0".Andy, in rubix, the specfile should be described as follows:
db_table*.*.*.* system_u:object_r:rubix_table_t:s0The library just does pattern matching without any assumption of database architecture.
I also noticed the previous patch allows to lookup an expected security context for the
db_tupleobject class, but tuples don't have their name basically, so I removed it.
And, it didn't support an upcomingdb_viewobject class, I added it instead.
Quoted 9 lines
Quoted 2 lines
Thanks,
This patch is missing the new files
label_db.cand selabel_db.5.Also, in the previous patch, the file
selabel_db.chad two instances of trailing whitespace: lines 20 and 55. Please fix those up and re-send.
Oops, sorry for the stupid misses.
The attached one is the revised patch.
Thanks,
Signature · 1 line
KaiGai Kohei <[email protected]>
libselinux/include/selinux/label.h | 11 + libselinux/include/selinux/selinux.h | 1 + libselinux/man/man3/selabel_open.3 | 10 +- libselinux/man/man3/selinux_binary_policy_path.3 | 4 + libselinux/man/man5/selabel_db.5 | 93 ++++++ libselinux/src/file_path_suffixes.h | 1 + libselinux/src/label.c | 3 +- libselinux/src/label_db.c | 334 ++++++++++++++++++++++ libselinux/src/label_internal.h | 2 + libselinux/src/selinux_config.c | 9 +- libselinux/src/selinux_internal.h | 1 + 11 files changed, 464 insertions(+), 5 deletions(-)
libselinux/include/selinux/label.h +11 -0
@@ -29,6 +29,8 @@ struct selabel_handle;#define SELABEL_CTX_MEDIA 1/* x contexts */ #define SELABEL_CTX_X 2 +/* db objects */ +#define SELABEL_CTX_DB 3/* * Available options
@@ -116,6 +118,15 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_X_POLYPROP 6#define SELABEL_X_POLYSELN 7 +/* DB backend */ +#define SELABEL_DB_DATABASE 1 +#define SELABEL_DB_SCHEMA 2 +#define SELABEL_DB_TABLE 3 +#define SELABEL_DB_COLUMN 4 +#define SELABEL_DB_SEQUENCE 5 +#define SELABEL_DB_VIEW 6 +#define SELABEL_DB_PROCEDURE 7 +#define SELABEL_DB_BLOB 8 #ifdef __cplusplus }
libselinux/include/selinux/selinux.h +1 -0
@@ -487,6 +487,7 @@ extern const char *selinux_media_context_path(void);extern const char *selinux_virtual_domain_context_path (void );extern const char *selinux_virtual_image_context_path (void );extern const char *selinux_x_context_path (void ); +extern const char *selinux_sepgsql_context_path (void );extern const char *selinux_contexts_path (void );extern const char *selinux_securetty_types_path (void );extern const char *selinux_booleans_path (void );
libselinux/man/man3/selabel_open.3 +7 -3
@@ -72,15 +72,19 @@ Note that an invalid context may not be treated as an error unless it is actuall .TP .B SELABEL_CTX_FILE File contexts backend, described in -.BR selabel_file (3). +.BR selabel_file (5). .TP .B SELABEL_CTX_MEDIA Media contexts backend, described in -.BR selabel_media (3). +.BR selabel_media (5). .TP .B SELABEL_CTX_X X Windows contexts backend, described in -.BR selabel_x (3). +.BR selabel_x (5). +.TP +.B SELABEL_CTX_DB +Database objects contexts backend, described in +.BR selabel_db (5). .SH "RETURN VALUE" A non-NULL handle value is returned on success. On error, NULL is returned and
libselinux/man/man3/selinux_binary_policy_path.3 +4 -0
@@ -29,6 +29,8 @@ extern const char *selinux_usersconf_path(void); extern const char *selinux_x_context_path(void); +extern const char *selinux_sepgsql_context_path(void); + extern const char *selinux_file_context_path(void); extern const char *selinux_media_context_path(void);
@@ -66,6 +68,8 @@ selinux_usersconf_path() - file containing mapping between Linux Users and SELin .sp selinux_x_context_path() - file containing configuration for XSELinux extension .sp +selinux_sepgsql_context_path() - file containing configuration for SE-PostgreSQL +.sp selinux_netfilter_context_path - default netfilter context .sp selinux_file_context_path() - default system file contexts configuration
libselinux/man/man5/selabel_db.5 new file +93 -0
93 lines not on this page · raw message
libselinux/src/file_path_suffixes.h +1 -0
@@ -23,3 +23,4 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") +S_ (SEPGSQL_CONTEXTS ,"/contexts/sepgsql_contexts" )
libselinux/src/label.c +2 -1
@@ -22,7 +22,8 @@ typedef int (*selabel_initfunc)(struct selabel_handle *rec,static selabel_initfunc initfuncs[] = { &selabel_file_init, &selabel_media_init, - &selabel_x_init + &selabel_x_init, + &selabel_db_init, }; typedef struct selabel_sub {
libselinux/src/label_db.c new file +334 -0
334 lines not on this page · raw message
libselinux/src/label_internal.h +2 -0
@@ -23,6 +23,8 @@ int selabel_media_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; int selabel_x_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; +int selabel_db_init(struct selabel_handle *rec, + struct selinux_opt *opts, unsigned nopts) hidden;/* * Labeling internal structures
libselinux/src/selinux_config.c +8 -1
@@ -44,7 +44,8 @@#define VIRTUAL_DOMAIN 21#define VIRTUAL_IMAGE 22#define FILE_CONTEXT_SUBS 23 -#define NEL 24 +#define SEPGSQL_CONTEXTS 24 +#define NEL 25/* Part of one-time lazy init */ static pthread_once_t once =PTHREAD_ONCE_INIT ;
@@ -422,3 +423,9 @@ const char * selinux_file_context_subs_path(void) {hidden_def (selinux_file_context_subs_path) +const char *selinux_sepgsql_context_path() +{ +return get_path (SEPGSQL_CONTEXTS ); +} + +hidden_def (selinux_sepgsql_context_path)
libselinux/src/selinux_internal.h +1 -0
@@ -73,6 +73,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_path) hidden_proto(selinux_check_passwd_access) hidden_proto(selinux_check_securetty_context)
On 03/08/2010 08:42 PM, KaiGai Kohei wrote:
libselinux/src/label_db.c new file +4 -0
@@ -0,0 +1,334 @@ +/* +* Media contexts backend for DB objects +* +* Author: KaiGai Kohei <[email protected]>
[snip]
+static int
+process_line(const char *path, char *line_buf, unsigned int line_num,
+ catalog_t *catalog)
+{
+ spec_t *spec = &catalog->specs[catalog->nspec];
+ char *type, *key, *context, *temp;
+ int items;
+
+ /* Cut off comments */
+ temp = strchr(line_buf, '#');
+ if (temp)
+ *temp = '\0';
+
+ /*
+ * Every entry must have the following format
+ * <object class> <object name> <security context>
+ */
+ type = key = context = temp = NULL;
+ items = sscanf(line_buf, "%as %as %as %as",
+ &type, &key, &context, &temp);
What is the meaning of the fourth "temp" argument here. Aren't lines only supposed to have three entries? Please remove this if it is not needed.
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 37 lines · Eamon Walsh
On 03/08/2010 08:42 PM, KaiGai Kohei wrote:
libselinux/src/label_db.c new file +24
-0@@ -0,0 +1,334 @@ +/* +* Media contexts backend for DB objects +* +* Author: KaiGai Kohei<[email protected]> +static int +process_line(const char *path, char *line_buf, unsigned int line_num, +catalog_t *catalog) +{ +spec_t *spec =&catalog->specs[catalog->nspec]; +char *type, *key, *context, *temp; +int items; + +/* Cut off comments */ + temp =strchr (line_buf,'#' ); +if (temp) + *temp ='\0' ; + +/* +* Every entry must have the following format +*<object class> <object name> <security context> +*/ + type = key = context = temp =NULL ; + items =sscanf (line_buf,"%as %as %as %as" , + &type,&key,&context,&temp);
Quoted 2 lines
What is the meaning of the fourth "temp" argument here. Aren't lines only supposed to have three entries? Please remove this if it is not needed.
If the line has four or more elements, we want to raise an error, rather than ignoring it.
If here is not the fourth %as, sscanf() does not return 4, does it?
Thanks,
Signature · 6 lines
KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 11 lines · KaiGai Kohei
Quoted 3 lines · Eamon Walsh
What is the meaning of the fourth "temp" argument here. Aren't lines only supposed to have three entries? Please remove this if it is not needed.
If the line has four or more elements, we want to raise an error, rather than ignoring it.
If here is not the fourth %as,sscanf()does not return 4, does it?Thanks,
OK, that makes sense.
I don't see any other issues with the patches. Unless Andy has any concerns, I will push them later today or tomorrow.
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 13 lines · Eamon Walsh
Quoted 11 lines · KaiGai Kohei
Quoted 4 lines · Eamon Walsh
What is the meaning of the fourth "temp" argument here. Aren't lines only supposed to have three entries? Please remove this if it is not needed.
If the line has four or more elements, we want to raise an error, rather than ignoring it.
If here is not the fourth %as,sscanf()does not return 4, does it?
Quoted 9 lines
Quoted 3 lines
Thanks,
OK, that makes sense.
I don't see any other issues with the patches. Unless Andy has any concerns, I will push them later today or tomorrow.
What is implemented looks fine to me. Just a few comments and questions.
Only thing that may keep us from fully using this functionality is that because there is not support for db_schema and db_catalog objects, it can't fully cover our labeled objects (correct?). Our naming scheme is database.catalog.schema.table, so I am guessing only the database and table could be labeled explicitly through the *_contexts file. It would probably confuse our customers to be able to assign contexts to some objects but not others. This might delay our use of it until the new DB object classes come out.
We currently overload the dir object class to cover our catalog and schema objects. This is not great, but the best choice we have to cover those objects. KaiGai, is it possible to actually use a dir object class within the *_contexts file? I acknowledge overloading/mixing these object classes (db and OS) is controversial and not the best solution, but I am curious if it would be technically possible under this patch. Or, does it restrict its functionality to only db objects?
Lastly, regarding tuples, I noticed the ability to label tuples was removed because tuples are not named. Would it be useful to label all tuples under an object (e.g., table) as follows. I am sure you considered this, just curious of your thoughts:
db_tuple *.pg_catalog.pg_table.* system_u:object_r:sepgsql_tuple_t:s0
So that all tuples under the *.pg_catalog.pg_table table would have a context of system_u:object_r:sepgsql_tuple_t:s0. Or, is the fact that you are not able to use anything other than * as the tuple's name simply make things too messy? I would assume there would be a similar issue in constructing a key value for a tuple in the call to selabel_lookup.
Andy
Quoted 2 lines
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 28 lines · Andy Warner
Quoted 13 lines · Eamon Walsh
Quoted 11 lines · KaiGai Kohei
Quoted 4 lines · Eamon Walsh
What is the meaning of the fourth "temp" argument here. Aren't lines only supposed to have three entries? Please remove this if it is not needed.
If the line has four or more elements, we want to raise an error, rather than ignoring it.
If here is not the fourth %as,sscanf()does not return 4, does it?Quoted 9 lines
Quoted 3 lines
Thanks,
OK, that makes sense.
I don't see any other issues with the patches. Unless Andy has any concerns, I will push them later today or tomorrow.
What is implemented looks fine to me. Just a few comments and questions.
Quoted 8 lines
Only thing that may keep us from fully using this functionality is that because there is not support for
db_schemaanddb_catalogobjects, it can't fully cover our labeled objects (correct?). Our naming scheme is database.catalog.schema.table, so I am guessing only the database and table could be labeled explicitly through the*_contextsfile. It would probably confuse our customers to be able to assign contexts to some objects but not others. This might delay our use of it until the new DB object classes come out.
The purpose of this functionality is to provide dbms hints what label should be assigned on database objects when we initialize the database, like /sbin/restorecon on filesystem.
We still need definitions of db_schema and db_catalog object class for the correct access controls. If we ask SELinux any required permissions within undefined object class, it returns either allowed or denied depending on /selinux/deny_unknown.
I want to use this functionality to assign preferable security context on all the database objects on global initialization. PostgreSQL set up an empty database using /usr/bin/initdb command. It inserts various kind of tuples into system catalogs which mean schemas, tables, columns... Unfortunatelly, when initdb insert tuples of system tables, tuples of schema and databases are not inserted yet. So, it needs to insert tuples without any labels, then they need to be relabeled, like /sbin/restorecon.
Of course, it can be used to give a hint of the default security context to be assigned on the database, but it is not the only purpose.
BTW, rubix has four layers of its namespace. It seems to me you worry about it, but don't need to worry about.
Its pattern matching logic is just using fnmatch(). So, if you describe your configuration file with four layers namespace, we don't need to modify libselinux anything.
example)
db_table *.my_catalog.my_schema.* system_u:object_r:my_rubix_table_t:s0
Quoted 7 lines
We currently overload the dir object class to cover our catalog and schema objects. This is not great, but the best choice we have to cover those objects. KaiGai, is it possible to actually use a dir object class within the
*_contextsfile? I acknowledge overloading/mixing these object classes (db and OS) is controversial and not the best solution, but I am curious if it would be technically possible under this patch. Or, does it restrict its functionality to only db objects?
It is not possible, because selabel_lookup() takes the 'key' argument which is one of the SELABEL_DB_*.
If you abuse db_schema/db_catalog object class until upstream policy does not have these definitions, you can lookup a matched entry with SELABEL_DB_SCHEMA for abused dir class.
Quoted 5 lines
Lastly, regarding tuples, I noticed the ability to label tuples was removed because tuples are not named. Would it be useful to label all tuples under an object (e.g., table) as follows. I am sure you considered this, just curious of your thoughts:
Quoted 7 lines
db_tuple*.pg_catalog.pg_table.* system_u:object_r:sepgsql_tuple_t:s0So that all tuples under the *.pg_catalog.pg_table table would have a context of system_u:object_r:sepgsql_tuple_t:s0. Or, is the fact that you are not able to use anything other than * as the tuple's name simply make things too messy? I would assume there would be a similar issue in constructing a key value for a tuple in the call to
selabel_lookup.
Hmm. Indeed, it makes sense.
I'll add db_tuple again. Please wait for a while.
Thanks,
Signature · 6 lines
KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 7 lines
Quoted 7 lines
Lastly, regarding tuples, I noticed the ability to label tuples was removed because tuples are not named. Would it be useful to label all tuples under an object (e.g., table) as follows. I am sure you considered this, just curious of your thoughts:
db_tuple*.pg_catalog.pg_table.* system_u:object_r:sepgsql_tuple_t:s0
Quoted 8 lines
Quoted 5 lines
So that all tuples under the *.pg_catalog.pg_table table would have a context of system_u:object_r:sepgsql_tuple_t:s0. Or, is the fact that you are not able to use anything other than * as the tuple's name simply make things too messy? I would assume there would be a similar issue in constructing a key value for a tuple in the call to
selabel_lookup.Hmm. Indeed, it makes sense.
I'll adddb_tupleagain. Please wait for a while.
The attached patch supports initial labeling of db_tuple class again.
If DBMS identifies tuples using the relation which owns the tuples, libselinux can return a hint of the security context to be assigned.
Below are only differences from the previous patch.
libselinux/include/selinux/label.h +1 -0
@@ -127,6 +127,7 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_DB_VIEW 6#define SELABEL_DB_PROCEDURE 7#define SELABEL_DB_BLOB 8 +#define SELABEL_DB_TUPLE 9 #ifdef __cplusplus }
libselinux/src/label_db.c +2 -0
@@ -136,6 +136,8 @@ process_line(const char *path, char *line_buf, unsigned int line_num, spec->type =SELABEL_DB_PROCEDURE ; else if (!strcmp(type, "db_blob")) spec->type =SELABEL_DB_BLOB ; + else if (!strcmp(type, "db_tuple")) + spec->type =SELABEL_DB_TUPLE ; else { selinux_log(SELINUX_WARNING, "%s: line %d has invalid object type %s\n",
Signature · 1 line
KaiGai Kohei <[email protected]>
libselinux/include/selinux/label.h | 12 + libselinux/include/selinux/selinux.h | 1 + libselinux/man/man3/selabel_open.3 | 10 +- libselinux/man/man3/selinux_binary_policy_path.3 | 4 + libselinux/man/man5/selabel_db.5 | 93 ++++++ libselinux/src/file_path_suffixes.h | 1 + libselinux/src/label.c | 3 +- libselinux/src/label_db.c | 336 ++++++++++++++++++++++ libselinux/src/label_internal.h | 2 + libselinux/src/selinux_config.c | 9 +- libselinux/src/selinux_internal.h | 1 + 11 files changed, 467 insertions(+), 5 deletions(-)
libselinux/include/selinux/label.h +12 -0
@@ -29,6 +29,8 @@ struct selabel_handle;#define SELABEL_CTX_MEDIA 1/* x contexts */ #define SELABEL_CTX_X 2 +/* db objects */ +#define SELABEL_CTX_DB 3/* * Available options
@@ -116,6 +118,16 @@ void selabel_stats(struct selabel_handle *handle);#define SELABEL_X_POLYPROP 6#define SELABEL_X_POLYSELN 7 +/* DB backend */ +#define SELABEL_DB_DATABASE 1 +#define SELABEL_DB_SCHEMA 2 +#define SELABEL_DB_TABLE 3 +#define SELABEL_DB_COLUMN 4 +#define SELABEL_DB_SEQUENCE 5 +#define SELABEL_DB_VIEW 6 +#define SELABEL_DB_PROCEDURE 7 +#define SELABEL_DB_BLOB 8 +#define SELABEL_DB_TUPLE 9 #ifdef __cplusplus }
libselinux/include/selinux/selinux.h +1 -0
@@ -487,6 +487,7 @@ extern const char *selinux_media_context_path(void);extern const char *selinux_virtual_domain_context_path (void );extern const char *selinux_virtual_image_context_path (void );extern const char *selinux_x_context_path (void ); +extern const char *selinux_sepgsql_context_path (void );extern const char *selinux_contexts_path (void );extern const char *selinux_securetty_types_path (void );extern const char *selinux_booleans_path (void );
libselinux/man/man3/selabel_open.3 +7 -3
@@ -72,15 +72,19 @@ Note that an invalid context may not be treated as an error unless it is actuall .TP .B SELABEL_CTX_FILE File contexts backend, described in -.BR selabel_file (3). +.BR selabel_file (5). .TP .B SELABEL_CTX_MEDIA Media contexts backend, described in -.BR selabel_media (3). +.BR selabel_media (5). .TP .B SELABEL_CTX_X X Windows contexts backend, described in -.BR selabel_x (3). +.BR selabel_x (5). +.TP +.B SELABEL_CTX_DB +Database objects contexts backend, described in +.BR selabel_db (5). .SH "RETURN VALUE" A non-NULL handle value is returned on success. On error, NULL is returned and
libselinux/man/man3/selinux_binary_policy_path.3 +4 -0
@@ -29,6 +29,8 @@ extern const char *selinux_usersconf_path(void); extern const char *selinux_x_context_path(void); +extern const char *selinux_sepgsql_context_path(void); + extern const char *selinux_file_context_path(void); extern const char *selinux_media_context_path(void);
@@ -66,6 +68,8 @@ selinux_usersconf_path() - file containing mapping between Linux Users and SELin .sp selinux_x_context_path() - file containing configuration for XSELinux extension .sp +selinux_sepgsql_context_path() - file containing configuration for SE-PostgreSQL +.sp selinux_netfilter_context_path - default netfilter context .sp selinux_file_context_path() - default system file contexts configuration
libselinux/man/man5/selabel_db.5 new file +93 -0
93 lines not on this page · raw message
libselinux/src/file_path_suffixes.h +1 -0
@@ -23,3 +23,4 @@ S_(BINPOLICY, "/policy/policy") S_(VIRTUAL_DOMAIN, "/contexts/virtual_domain_context") S_(VIRTUAL_IMAGE, "/contexts/virtual_image_context") S_(FILE_CONTEXT_SUBS, "/contexts/files/file_contexts.subs") +S_ (SEPGSQL_CONTEXTS ,"/contexts/sepgsql_contexts" )
libselinux/src/label.c +2 -1
@@ -22,7 +22,8 @@ typedef int (*selabel_initfunc)(struct selabel_handle *rec,static selabel_initfunc initfuncs[] = { &selabel_file_init, &selabel_media_init, - &selabel_x_init + &selabel_x_init, + &selabel_db_init, }; typedef struct selabel_sub {
libselinux/src/label_db.c new file +336 -0
336 lines not on this page · raw message
libselinux/src/label_internal.h +2 -0
@@ -23,6 +23,8 @@ int selabel_media_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; int selabel_x_init(struct selabel_handle *rec, struct selinux_opt *opts, unsigned nopts) hidden; +int selabel_db_init(struct selabel_handle *rec, + struct selinux_opt *opts, unsigned nopts) hidden;/* * Labeling internal structures
libselinux/src/selinux_config.c +8 -1
@@ -44,7 +44,8 @@#define VIRTUAL_DOMAIN 21#define VIRTUAL_IMAGE 22#define FILE_CONTEXT_SUBS 23 -#define NEL 24 +#define SEPGSQL_CONTEXTS 24 +#define NEL 25/* Part of one-time lazy init */ static pthread_once_t once =PTHREAD_ONCE_INIT ;
@@ -422,3 +423,9 @@ const char * selinux_file_context_subs_path(void) {hidden_def (selinux_file_context_subs_path) +const char *selinux_sepgsql_context_path() +{ +return get_path (SEPGSQL_CONTEXTS ); +} + +hidden_def (selinux_sepgsql_context_path)
libselinux/src/selinux_internal.h +1 -0
@@ -73,6 +73,7 @@ hidden_proto(selinux_mkload_policy) hidden_proto(selinux_customizable_types_path) hidden_proto(selinux_media_context_path) hidden_proto(selinux_x_context_path) + hidden_proto(selinux_sepgsql_context_path) hidden_proto(selinux_path) hidden_proto(selinux_check_passwd_access) hidden_proto(selinux_check_securetty_context)
Quoted 13 lines · KaiGai Kohei
Quoted 13 lines
Quoted 13 lines
Lastly, regarding tuples, I noticed the ability to label tuples was removed because tuples are not named. Would it be useful to label all tuples under an object (e.g., table) as follows. I am sure you considered this, just curious of your thoughts:
db_tuple*.pg_catalog.pg_table.* system_u:object_r:sepgsql_tuple_t:s0So that all tuples under the *.pg_catalog.pg_table table would have a context of system_u:object_r:sepgsql_tuple_t:s0. Or, is the fact that you are not able to use anything other than * as the tuple's name simply make things too messy? I would assume there would be a similar issue in constructing a key value for a tuple in the call to
selabel_lookup.
Quoted 8 lines
Quoted 3 lines
Hmm. Indeed, it makes sense.
I'll adddb_tupleagain. Please wait for a while.The attached patch supports initial labeling of
db_tupleclass again.If DBMS identifies tuples using the relation which owns the tuples, libselinux can return a hint of the security context to be assigned.
I have committed this patch and released libselinux 2.0.93.
To follow up on Andy's concerns: the patch includes the db_tuple labeling keyword as you requested. But you also need support for db_catalog and db_schema object classes in the policy, is that correct? I can't see any reason not to add them, although I don't know what permissions they would need.
Signature · 8 lines
Eamon Walsh National Security Agency -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 23 lines · Eamon Walsh
Quoted 13 lines · KaiGai Kohei
Quoted 13 lines
Quoted 13 lines
Lastly, regarding tuples, I noticed the ability to label tuples was removed because tuples are not named. Would it be useful to label all tuples under an object (e.g., table) as follows. I am sure you considered this, just curious of your thoughts:
db_tuple*.pg_catalog.pg_table.* system_u:object_r:sepgsql_tuple_t:s0So that all tuples under the *.pg_catalog.pg_table table would have a context of system_u:object_r:sepgsql_tuple_t:s0. Or, is the fact that you are not able to use anything other than * as the tuple's name simply make things too messy? I would assume there would be a similar issue in constructing a key value for a tuple in the call to
selabel_lookup.Quoted 8 lines
Quoted 3 lines
Hmm. Indeed, it makes sense.
I'll adddb_tupleagain. Please wait for a while.The attached patch supports initial labeling of
db_tupleclass again.If DBMS identifies tuples using the relation which owns the tuples, libselinux can return a hint of the security context to be assigned.
Quoted 5 lines
I have committed this patch and released libselinux 2.0.93.
To follow up on Andy's concerns: the patch includes the
db_tuplelabeling keyword as you requested. But you also need support fordb_cataloganddb_schemaobject classes in the policy, is that correct?
Yes, correct. This update enables libselinux to provide a hint for initial labeling on some kind of database object class including ones which are not included yet.
Quoted 2 lines
I can't see any reason not to add them, although I don't know what permissions they would need.
Unfortunately, we are still under working to get support SELinux in PostgreSQL. It means here is a risk that its specifications are changed to unexpected form.
(However, I thought they misunderstood SE-PostgreSQL _replaces_ its existing permission checks and models, not an additional ones. It might be a reason why they concerned about security features.)
Andy, if your concern is mainly addressed to default security context under the catalog or schema object, here is a workaround hack.
The string_to_security_class() returns zero, if undefined object class was given, such as "db_schema". If we provide security_compute_create() a zero as object class code, it returns the target security context (expect for "user" field; it is copied from subject context) as new one.
It means, if we label the database as "system_u:object_r:sepgsql_db_t:s0", we can also apply this context for catalogs/schemas until the default policy does not have definition of db_schema/db_catalog classes.
e.g)
[kaigai@saba selinux]$ php -r 'echo selinux_compute_create("unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023","system_u:object_r:sepgsql_db_t:s0","db_catalog")."\n";' unconfined_u:object_r:sepgsql_db_t:s0
^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^
copied from copied from tcontext
scontext
Thanks,
Signature · 6 lines
KaiGai Kohei <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.