xfs: make several more functions static
PATCH 1/1 xfs: make several more functions static
Just minor housekeeping, a lot more functions can be trivially made static; others could if we reordered things a bit...
---
fs/xfs/linux-2.6/xfs_sync.c +1 -1
@@ -343,7 +343,7 @@ xfs_commit_dummy_trans(return error; } -int +STATIC intxfs_sync_fsdata (struct xfs_mount *mp,int flags)
fs/xfs/linux-2.6/xfs_sync.h +0 -1
@@ -37,7 +37,6 @@ void xfs_syncd_stop(struct xfs_mount *mp);int xfs_sync_attr (struct xfs_mount *mp,int flags);int xfs_sync_data (struct xfs_mount *mp,int flags); -int xfs_sync_fsdata (struct xfs_mount *mp,int flags);int xfs_quiesce_data (struct xfs_mount *mp);void xfs_quiesce_attr (struct xfs_mount *mp);
fs/xfs/xfs_attr.c +1 -1
@@ -196,7 +196,7 @@ xfs_attr_get(/* * Calculate how many blocks we need for the new attribute, */ -int +STATIC int xfs_attr_calc_size( struct xfs_inode *ip, int namelen,
fs/xfs/xfs_attr.h +0 -1
@@ -129,7 +129,6 @@ typedef struct xfs_attr_list_context {/* * Overall external interface routines. */ -int xfs_attr_calc_size (struct xfs_inode *,int ,int ,int *);int xfs_attr_inactive (struct xfs_inode *dp);int xfs_attr_fetch (struct xfs_inode *,struct xfs_name *,char *,int *,int );int xfs_attr_rmtval_get (struct xfs_da_args *args);
fs/xfs/xfs_bmap_btree.c +1 -1
@@ -335,7 +335,7 @@ xfs_bmbt_disk_set_allf(/* * Set all the fields in a bmap extent record from the uncompressed form. */ -void +STATIC voidxfs_bmbt_disk_set_all (xfs_bmbt_rec_t *r,xfs_bmbt_irec_t *s)
fs/xfs/xfs_bmap_btree.h +0 -1
@@ -231,7 +231,6 @@ extern void xfs_bmbt_set_startblock(xfs_bmbt_rec_host_t *r, xfs_fsblock_t v);extern void xfs_bmbt_set_startoff (xfs_bmbt_rec_host_t *r,xfs_fileoff_t v);extern void xfs_bmbt_set_state (xfs_bmbt_rec_host_t *r,xfs_exntst_t v); -extern void xfs_bmbt_disk_set_all (xfs_bmbt_rec_t *r,xfs_bmbt_irec_t *s);extern void xfs_bmbt_disk_set_allf (xfs_bmbt_rec_t *r,xfs_fileoff_t o,xfs_fsblock_t b,xfs_filblks_t c,xfs_exntst_t v);
fs/xfs/xfs_dir2_node.c +1 -1
@@ -65,7 +65,7 @@ static int xfs_dir2_node_addname_int(xfs_da_args_t *args,/* * Log entries from a freespace block. */ -void +STATIC void xfs_dir2_free_log_bests( xfs_trans_t *tp, /* transaction pointer */ xfs_dabuf_t *bp, /* freespace buffer */
fs/xfs/xfs_dir2_node.h +0 -2
@@ -75,8 +75,6 @@ xfs_dir2_db_to_fdindex(struct xfs_mount *mp, xfs_dir2_db_t db)return ((db) %XFS_DIR2_MAX_FREE_BESTS (mp)); } -extern void xfs_dir2_free_log_bests (struct xfs_trans *tp,struct xfs_dabuf *bp, -int first,int last);extern int xfs_dir2_leaf_to_node (struct xfs_da_args *args,struct xfs_dabuf *lbp);extern xfs_dahash_t xfs_dir2_leafn_lasthash (struct xfs_dabuf *bp,int *count);
fs/xfs/xfs_log_priv.h +0 -5
@@ -445,14 +445,9 @@ typedef struct log {/* common routines */ extern xfs_lsn_t xlog_assign_tail_lsn (struct xfs_mount *mp); -extern int xlog_find_tail (xlog_t *log, -xfs_daddr_t *head_blk, -xfs_daddr_t *tail_blk);extern int xlog_recover (xlog_t *log);extern int xlog_recover_finish (xlog_t *log);extern void xlog_pack_data (xlog_t *log,xlog_in_core_t *iclog,int ); -extern struct xfs_buf *xlog_get_bp (xlog_t *,int ); -extern void xlog_put_bp (struct xfs_buf *);extern kmem_zone_t *xfs_log_ticket_zone;
fs/xfs/xfs_log_recover.c +3 -3
@@ -67,7 +67,7 @@ STATIC void xlog_recover_check_summary(xlog_t *); ((bbs + (log)->l_sectbb_mask + 1) & ~(log)->l_sectbb_mask) : (bbs) )#define XLOG_SECTOR_ROUNDDOWN_BLKNO (log, bno) ((bno) & ~(log)->l_sectbb_mask) -xfs_buf_t * +STATIC xfs_buf_t *xlog_get_bp (xlog_t *log,int nbblks)
@@ -87,7 +87,7 @@ xlog_get_bp(return xfs_buf_get_noaddr (BBTOB (nbblks), log->l_mp->m_logdev_targp); } -void +STATIC_INLINE voidxlog_put_bp (xfs_buf_t *bp) {
@@ -810,7 +810,7 @@ xlog_find_head(* We could speed up search by using current head_blk buffer, but it is not * available. */ -int +STATIC int xlog_find_tail( xlog_t *log, xfs_daddr_t *head_blk,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 2 lines · Eric Sandeen
Just minor housekeeping, a lot more functions can be trivially made static; others could if we reordered things a bit...
Only one minor comment:
fs/xfs/xfs_log_recover.c xlog_get_bp( · line 93
Quoted 5 lines
fs/xfs/xfs_log_recover.c +1
-1-void +STATIC_INLINE voidxlog_put_bp (xfs_buf_t *bp) {
I'd change that as STATIC as Christoph's recent patch removed STATIC_INLINE. gcc will inline it for us if it's a win....
Cheers,
Dave.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 6 lines · Dave Chinner
Quoted 2 lines · Eric Sandeen
Just minor housekeeping, a lot more functions can be trivially made static; others could if we reordered things a bit...
Only one minor comment:
Quoted 8 lines
fs/xfs/xfs_log_recover.c xlog_get_bp( · line 93
Quoted 5 lines
fs/xfs/xfs_log_recover.c +1
-1-void +STATIC_INLINE voidxlog_put_bp (xfs_buf_t *bp) {I'd change that as STATIC as Christoph's recent patch removed
STATIC_INLINE. gcc will inline it for us if it's a win....
Oops, ok, thanks for looking at it.
-Eric
Quoted 3 lines
Cheers,
Dave.
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs