thinkpad-acpi: should error return be nagative?
PATCH 1/1 thinkpad-acpi: should error return be nagative?
The returned error should be negative
--- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Is this maybe required?
drivers/platform/x86/thinkpad_acpi.c +1 -1
@@ -6313,7 +6313,7 @@ static int brightness_write(char *buf)* Doing it this way makes the syscall restartable in case of EINTR */ rc =brightness_set (level); -return (rc == -EINTR )?ERESTARTSYS : rc; +return (rc == -EINTR )? -ERESTARTSYS : rc; }static struct ibm_struct brightness_driver_data = {
Quoted 8 lines · Roel Kluin
The returned error should be negative
Signed-off-by Roel Kluin <[email protected]>--- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Is this maybe required?
Yes, it is. Thank you for noticing this.
I will queue it, and send it in during the merge window, and also to -stable so that it can go into 2.6.31.y and 2.6.32.y.
Andrew, if you'd rather send it to Linus right now since it is an obvious one-char fix, well, I'd not oppose it at all :-)
Quoted 18 lines
drivers/platform/x86/thinkpad_acpi.c +1
-2@@ -6313,7 +6313,7 @@ static int brightness_write(char *buf)* Doing it this way makes the syscall restartable in case of EINTR */ rc =brightness_set (level); -return (rc == -EINTR )?ERESTARTSYS : rc; +return (rc == -EINTR )? -ERESTARTSYS : rc; }static struct ibm_struct brightness_driver_data = { --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 4 lines
"One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
Len Brown
Appliedapplied
thanks,
Len Brown, Intel Open Source Technology Center