Skip to contentSkip to conversation

r8192U_core: test for negative error in rtl8192_rx_isr()?

PATCH Applied Roel Kluin 2 participants 2 messages Nov 20, 2009 – Dec 18, 2009 Staging

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 r8192U_core: test for negative error in rtl8192_rx_isr()?

The error tested for is negative

---
 drivers/staging/rtl8192su/r8192U_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Is this maybe required?

drivers/staging/rtl8192su/r8192U_core.c +1 -1
index 66274d7..b492ff5 100644
@@ -1501,7 +1501,7 @@ static void rtl8192_rx_isr(struct urb *urb)
         urb->context = skb;
         skb_queue_tail(&priv->rx_queue, skb);
         err = usb_submit_urb(urb, GFP_ATOMIC);
-	if(err && err != EPERM)
+	if(err && err != -EPERM)
 		printk("can not submit rxurb, err is %x,URB status is %x\n",err,urb->status);
 }
 
#1 lore raw

patch staging-rtl8192su-fix-test-for-negative-error-in-rtl8192_rx_isr.patch added to gregkh-2.6 tree

This is a note to let you know that I've just added the patch titled

Subject: Staging: rtl8192su: fix test for negative error in rtl8192_rx_isr()

to my gregkh-2.6 tree. Its filename is

    staging-rtl8192su-fix-test-for-negative-error-in-rtl8192_rx_isr.patch

This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/

Quoted 1 line

From [email protected] Fri Dec 18 10:10:01 2009

From: Roel Kluin <[email protected]>
Date: Fri, 20 Nov 2009 20:12:33 +0100
Subject: Staging: rtl8192su: fix test for negative error in rtl8192_rx_isr()
To: Greg Kroah-Hartman <[email protected]>, [email protected], Andrew Morton <[email protected]>, LKML <[email protected]>, [email protected]
Message-ID: <[email protected]>

The error tested for is negative

---
 drivers/staging/rtl8192su/r8192U_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192su/r8192U_core.c +1 -1
@@ -1501,7 +1501,7 @@ static void rtl8192_rx_isr(struct urb *u
         urb->context = skb;
         skb_queue_tail(&priv->rx_queue, skb);
         err = usb_submit_urb(urb, GFP_ATOMIC);
-	if(err && err != EPERM)
+	if(err && err != -EPERM)
 		printk("can not submit rxurb, err is %x,URB status is %x\n",err,urb->status);
 }