igb: fix misinterpreted return value of pci_enable_msix

From: Stefan Assmann <[email protected]>

In the igb driver a return value of 0 of function pci_enable_msix is interpreted as an error case. The correct behaviour is to check < 0 for error values.

Signed-off-by Stefan Assmann <[email protected]>

---
 drivers/net/igb/igb_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/igb/igb_main.c +0 -0

index bb1a6ee..745481d 100644

Quoted 16 lines · Stefan Assmann

From: Stefan Assmann <[email protected]>

In the igb driver a return value of 0 of function pci_enable_msix is interpreted as an error case. The correct behaviour is to check < 0 for error values.

Signed-off-by Stefan Assmann <[email protected]>

---
 drivers/net/igb/igb_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/igb/igb_main.c +0 -0

index bb1a6ee..745481d 100644

drivers/net/igb/igb_main.c static void igb_set_interrupt_capability(struct igb_adapter *adapter) · line 699

Quoted 7 lines

drivers/net/igb/igb_main.c +1 -1

@@ -694,7 +694,7 @@ static void igb_set_interrupt_capability(struct igb_adapter *adapter)
 	err = pci_enable_msix(adapter->pdev,
 			      adapter->msix_entries,
 			      numvecs);
-	if (err == 0)
+	if (err < 0)
 		goto out;
 

The existing code looks correct to me:

      if (err == 0)
            goto out;

      igb_reset_interrupt_capability(adapter);

      /* If we can't do MSI-X, try MSI * */

msi_only:

so the "goto out" appears to be the "success" case.