app launchers should NOT modify /proc/sys/vm
P.S. Sorry if this comes through twice. Dreamhost mail server was having issues...
Currently, the navit (routing app) launcher script modifies /proc/sys/vm/overcommit_memory without ever setting it back. This change should -if at all- should only be done with serious evaluation on the respective devices IMHO. I don't want to introduce random OOM process killings for everyone because apps start using the RAM the kernel has promised to them.
Do I get the OK to remove the launcher which is only doing this hackery? I will follow up on this mail with a patch that you can ACK.
spaetz
Commit introducing this:
http://cgit.openembedded.net/cgit.cgi/openembedded/commit/?id=742fb4ae71e6a7e655385086ba9edebbf00b6ebd
author Matthias Hentges <[email protected]>
committer Matthias Hentges <[email protected]> 2008-01-05
commit 742fb4ae71e6a7e655385086ba9edebbf00b6ebd
--- a/dev/null
+++ b/packages/navit/files/navit.launcher
...
+ if test "$USER" = "root"
+ then
+ echo "Enabling low-mem workaround..."
+ echo 1 > /proc/sys/vm/overcommit_memory
PATCH 1/1 navit: Do not set /proc/sys/vm/overcommit in an app launcher, especially not without ever changing it back.
* This reverts parts of 742fb4ae71e6a7e655385086ba9edebbf00b6ebd
* If someone wants to do use this, it should be done on a more finegrained distro basis
--- recipes/navit/files/navit.launcher | 30 ------------------------------ recipes/navit/navit.inc | 4 ---- 2 files changed, 0 insertions(+), 34 deletions(-) delete mode 100644 recipes/navit/files/navit.launcher
recipes/navit/files/navit.launcher deleted +0 -30
@@ -1,30 +0,0 @@ -#! /bin/sh -# -# Copyright Matthias Hentges <[email protected]> (c) 2008 -# License: GPL (see http://www.gnu.org/licenses/gpl.txt for a copy of the license) -# -# Filename: navit.launcher -# Date: 20080105 (YMD) -# -################################################################################# -# -# 20080105 - v0.0.1 - Initial release - -# On devices with low memory (< 512Mb?) Navit will segfault on start. -# This can be worked around by doing -# "echo 1 > /proc/sys/vm/overcommit_memory" - -if test "`cat /proc/meminfo | grep ^MemTotal | awk '{print $2}'`" -lt "500000" -then - if test "$USER" = "root" - then - echo "Enabling low-mem workaround..." - echo 1 > /proc/sys/vm/overcommit_memory - else - echo "I need root-privs to enable the low-mem workaround!" - fi -fi - -navit.real $* - -
recipes/navit/navit.inc +0 -4
@@ -15,7 +15,6 @@ FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug" SRC_URI_append = " \ file://navit.desktop \ - file://navit.launcher \ file://navit.png \ "
@@ -25,8 +24,5 @@ do_install_append() { install -d ${D}${datadir}/pixmaps/ install -m 0644 ${WORKDIR}/navit.png ${D}${datadir}/pixmaps/ - mv ${D}${bindir}/navit ${D}${bindir}/navit.real - install -m 0755 ${WORKDIR}/navit.launcher ${D}${bindir}/navit - rm ${D}${libdir}/${PN}/*/*.la }
Signature · 1 line
1.6.3.3
Re: [PATCH] navit: Do not set /proc/sys/vm/overcommit in an app launcher, especially not without ever changing it back.
Hello all,
Quoted 3 lines · Sebastian Spaeth
* This reverts parts of
742fb4ae71e6a7e655385086ba9edebbf00b6ebd
* If someone wants to do use this, it should be done on a more finegrained distro basis
+1 for the reverting patch.
Agreed with the remark this belongs in distro policy.
recipes/navit/files/navit.launcher line 15
Quoted 5 lines
recipes/navit/files/navit.launcher deleted +0
-3-# On devices with low memory (< 512Mb?) Navit will segfault on start. -# This can be worked around by doing -# "echo 1 > /proc/sys/vm/overcommit_memory"
Regards,
Signature · 1 line
Leon