Skip to contentSkip to conversation

samsung: fix DMC1_MEM_CFG for s3c64xx

PATCH New Seunghyeon Rhee (이승현) 3 participants 8 messages Nov 28, 2009 – Dec 5, 2009 Arm Samsung Exynos

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to contorl CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is obsearved that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
 include/s3c6400.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/s3c6400.h +1 -1
index e527c08..7229ea6 100644
@@ -817,7 +817,7 @@
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
-#define DMC1_MEM_CFG	0x80010012	/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG	0x00010012	/* Chip1, Burst4, Row/Column bit */
 #define DMC1_MEM_CFG2	0xB45
 #define DMC1_CHIP0_CFG	0x150F8		/* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
 #define DMC_DDR_32_CFG	0x0 		/* 32bit, DDR */
Signature · 8 lines
1.6.2.5


-- 
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007  F +82-2-6442-6462
M +82-10-2790-0657
#1 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

Dear Seunghyeon Rhee,

2009/11/28 "Seunghyeon Rhee (???)" <[email protected]>:

Quoted 32 lines

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to contorl CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is obsearved that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
?include/s3c6400.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

include/s3c6400.h +0 -0
index e527c08..7229ea6 100644
@@ -817,7 +817,7 @@

?/*----------------------------------------------------------------------- ?* Physical Memory Map
?*/

include/s3c6400.h +1 -1
-#define DMC1_MEM_CFG ? 0x80010012 ? ? ?/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG ? 0x00010012 ? ? ?/* Chip1, Burst4, Row/Column bit */

?#define DMC1_MEM_CFG2 ?0xB45
?#define DMC1_CHIP0_CFG 0x150F8 ? ? ? ? /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */ ?#define DMC_DDR_32_CFG 0x0 ? ? ? ? ? ? /* 32bit, DDR */
--
1.6.2.5

Quoted 6 lines

--
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 ?F +82-2-6442-6462
M +82-10-2790-0657

Please rebase this patch.
s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#2 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

Minkyu Kang ? ?:

Quoted 47 lines

Dear Seunghyeon Rhee,

2009/11/28 "Seunghyeon Rhee (???)" <[email protected]>:

Quoted 32 lines

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to contorl CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is obsearved that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
 include/s3c6400.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/s3c6400.h +1 -2
index e527c08..7229ea6 100644
@@ -817,7 +817,7 @@
 /*-----------------------------------------------------------------------
 * Physical Memory Map
 */
-#define DMC1_MEM_CFG   0x80010012      /* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG   0x00010012      /* Chip1, Burst4, Row/Column bit */
 #define DMC1_MEM_CFG2  0xB45
 #define DMC1_CHIP0_CFG 0x150F8         /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
 #define DMC_DDR_32_CFG 0x0             /* 32bit, DDR */
--

1.6.2.5

Quoted 7 lines

--
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 F +82-2-6442-6462
M +82-10-2790-0657

Please rebase this patch.
s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h

Quoted 3 lines

Thanks
Minkyu Kang

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to control CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is observed that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
 include/asm-arm/arch-s3c64xx/s3c6400.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-arm/arch-s3c64xx/s3c6400.h +2 -2
index e527c08..10b3324 100644
@@ -817,9 +817,9 @@
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
-#define DMC1_MEM_CFG	0x80010012	/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG	0x00010012	/* burst 4, 13-bit row, 10-bit col */
 #define DMC1_MEM_CFG2	0xB45
-#define DMC1_CHIP0_CFG	0x150F8		/* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
+#define DMC1_CHIP0_CFG	0x150F8		/* 0x5000_0000~0x57ff_ffff (128 MiB) */
 #define DMC_DDR_32_CFG	0x0 		/* 32bit, DDR */
 
 /* Memory Parameters */
Signature · 8 lines
1.6.2.5



Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007  F +82-2-6442-6462
M +82-10-2790-0657
#3 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

In reply to Minkyu Kang

Minkyu Kang worte:

Quoted 47 lines

Dear Seunghyeon Rhee,

2009/11/28 "Seunghyeon Rhee" <[email protected]>:

Quoted 32 lines

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to contorl CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is obsearved that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
 include/s3c6400.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/s3c6400.h +1 -2
index e527c08..7229ea6 100644
@@ -817,7 +817,7 @@
 /*-----------------------------------------------------------------------
 * Physical Memory Map
 */
-#define DMC1_MEM_CFG   0x80010012      /* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG   0x00010012      /* Chip1, Burst4, Row/Column bit */
 #define DMC1_MEM_CFG2  0xB45
 #define DMC1_CHIP0_CFG 0x150F8         /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
 #define DMC_DDR_32_CFG 0x0             /* 32bit, DDR */
--

1.6.2.5

Quoted 7 lines

--
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 F +82-2-6442-6462
M +82-10-2790-0657

Please rebase this patch.
s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h

Quoted 3 lines

Thanks
Minkyu Kang

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to control CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is observed that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
 include/asm-arm/arch-s3c64xx/s3c6400.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
include/asm-arm/arch-s3c64xx/s3c6400.h +2 -2
index e527c08..10b3324 100644
@@ -817,9 +817,9 @@
 /*-----------------------------------------------------------------------
  * Physical Memory Map
  */
-#define DMC1_MEM_CFG	0x80010012	/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG	0x00010012	/* burst 4, 13-bit row, 10-bit col */
 #define DMC1_MEM_CFG2	0xB45
-#define DMC1_CHIP0_CFG	0x150F8		/* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
+#define DMC1_CHIP0_CFG	0x150F8		/* 0x5000_0000~0x57ff_ffff (128 MiB) */
 #define DMC_DDR_32_CFG	0x0 		/* 32bit, DDR */
 
 /* Memory Parameters */
Signature · 7 lines
1.6.2.5


Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007  F +82-2-6442-6462
M +82-10-2790-0657
#4 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

Dear Seunghyyeon Rhee,

2009/12/3 Seunghyeon Rhee <[email protected]>:

Quoted 87 lines

Minkyu Kang worte:

Quoted 47 lines

Dear Seunghyeon Rhee,

2009/11/28 "Seunghyeon Rhee" <[email protected]>:

Quoted 32 lines

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to contorl CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is obsearved that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
?include/s3c6400.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

include/s3c6400.h +0 -0
index e527c08..7229ea6 100644
@@ -817,7 +817,7 @@

?/*----------------------------------------------------------------------- ?* Physical Memory Map
?*/

include/s3c6400.h +1 -1
-#define DMC1_MEM_CFG ? 0x80010012 ? ? ?/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG ? 0x00010012 ? ? ?/* Chip1, Burst4, Row/Column bit */

?#define DMC1_MEM_CFG2 ?0xB45
?#define DMC1_CHIP0_CFG 0x150F8 ? ? ? ? /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */ ?#define DMC_DDR_32_CFG 0x0 ? ? ? ? ? ? /* 32bit, DDR */
--
1.6.2.5

Quoted 7 lines

--
Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 ?F +82-2-6442-6462
M +82-10-2790-0657

Please rebase this patch.
s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h

Quoted 3 lines

Thanks
Minkyu Kang

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to control CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is observed that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

---
?include/asm-arm/arch-s3c64xx/s3c6400.h | ? ?4 ++-- ?1 files changed, 2 insertions(+), 2 deletions(-)

include/asm-arm/arch-s3c64xx/s3c6400.h +0 -0
index e527c08..10b3324 100644
@@ -817,9 +817,9 @@

?/*----------------------------------------------------------------------- ?* Physical Memory Map
?*/

include/asm-arm/arch-s3c64xx/s3c6400.h +1 -1
-#define DMC1_MEM_CFG ? 0x80010012 ? ? ?/* Chip1, Burst4, Row/Column bit */
+#define DMC1_MEM_CFG ? 0x00010012 ? ? ?/* burst 4, 13-bit row, 10-bit col */

?#define DMC1_MEM_CFG2 ?0xB45

include/asm-arm/arch-s3c64xx/s3c6400.h +1 -1
-#define DMC1_CHIP0_CFG 0x150F8 ? ? ? ? /* 0x4000_0000 ~ 0x43ff_ffff (64MB) */
+#define DMC1_CHIP0_CFG 0x150F8 ? ? ? ? /* 0x5000_0000~0x57ff_ffff (128 MiB) */

?#define DMC_DDR_32_CFG 0x0 ? ? ? ? ? ? /* 32bit, DDR */

?/* Memory Parameters */
--
1.6.2.5

Quoted 5 lines

Seunghyeon Rhee, Ph.D. / Director
LPM Technology Inc.
T +82-70-8255-6007 ?F +82-2-6442-6462
M +82-10-2790-0657

applied to u-boot-samsung

Thanks
Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net
#7 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

In reply to Seunghyeon Rhee

Dear Seunghyeon Rhee,

Quoted 8 lines · In message <[email protected]> you wrote:
Quoted 8 lines

Dear Seunghyeon Rhee,

2009/11/28 "Seunghyeon Rhee" <[email protected]>:

Quoted 3 lines

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit

...

Quoted 17 lines
Quoted 6 lines

Please rebase this patch.
s3c6400.h is moved to include/asm-arm/arch-s3c64xx/s3c6400.h

Thanks
Minkyu Kang

The MSB of DMC1_MEM_CFG can be set to '1' for separate CKE control for S3C6400. In the configuration of SMDK6400, however, two 16-bit mDDR (SAMSUNG K4X51163) chips are used in parallel to form 32-bit memory bus and there is no need to control CKE for each chip separately. AFAIK, CKE1 is not at all connected. Only CKE0 is used. Futhermore, it should be '0' always for S3C6410. When tested with a board which has a S3C6410 and the same memory configuration, a side effect is observed that u-boot command "reset" doesn't work leading to system hang. Leaving the bit clear is safe in most cases.

Quoted 4 lines
---
 include/asm-arm/arch-s3c64xx/s3c6400.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Is this a patch re-submission or what? If yes, then please:

1) add a version to the subject (like "[PATCH v2]"
2) add a description of what has been changed below (!) the "---" line
3) and make sure thsat the commit message can be used - the one above is definitely unusable.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it.    -- Edsger Dijkstra
#5 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

In reply to Minkyu Kang

Dear Minkyu Kang,

Quoted 1 line · In message <[email protected]> you…

...

Quoted 1 line

applied to u-boot-samsung

Thanks for clean9ing up the original poster's mess of a commit message. But please feel free to reject such horribly formatted submissions.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb mu? man das
Wahre unerm?dlich in Worten wiederholen.                     - Goethe
#6 lore raw

PATCH 1/1 samsung: fix DMC1_MEM_CFG for s3c64xx

Dear Wolfgang,

2009/12/5 Wolfgang Denk <[email protected]>:

Quoted 10 lines

Dear Minkyu Kang,

Quoted 1 line · In message <[email protected]> you…

...

Quoted 1 line

applied to u-boot-samsung

Thanks for clean9ing up the original poster's mess of a commit message. But please feel free to reject such horribly formatted submissions.

Ok. I will.
Thanks in advice.

Quoted 12 lines

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Der Irrtum wiederholt sich immerfort in der Tat. ?Deshalb mu? man das Wahre unerm?dlich in Worten wiederholen. ? ? ? ? ? ? ? ? ? ? - Goethe

Minkyu Kang

Signature · 2 lines
from. prom.
www.promsoft.net