Skip to contentSkip to conversation

Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h

PATCH helight 3 participants 4 messages Nov 30, 2009 – Dec 1, 2009

lore
Share & tools
lore

helight

author
#0 lore raw

acpi_sfi_table_parse() should be __init. tested on x86 system!

warning msg:

WARNING: vmlinux.o(.text+0x322e69): Section mismatch in reference from the function acpi_sfi_table_parse() to the function .init.text:acpi_table_parse() The function acpi_sfi_table_parse() references
the function __init acpi_table_parse().
This is often because acpi_sfi_table_parse lacks a __init
annotation or the annotation of acpi_table_parse is wrong.

---
include/linux/sfi_acpi.h | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/sfi_acpi.h +1 -1
index c4a5a8c..631af63 100644
@@ -66,7 +66,7 @@ extern int sfi_acpi_table_parse(char *signature, char *oem_id,
                               char *oem_table_id,
                               int (*handler)(struct acpi_table_header *));
 
-static inline int acpi_sfi_table_parse(char *signature,
+static inline int __init acpi_sfi_table_parse(char *signature,
                               int (*handler)(struct acpi_table_header *))

{
if (!acpi_table_parse(signature, handler))
@@ -83,7 +83,7 @@ static inline int sfi_acpi_table_parse(char *signature, char *oem_id,

       return -1;
}

-static inline int acpi_sfi_table_parse(char *signature, +static inline int __init acpi_sfi_table_parse(char *signature,
int (*handler)(struct acpi_table_header *))

{
       return acpi_table_parse(signature, handler);
Signature · 6 lines
1.6.5.3

-- 
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
#1 lore raw

Hi Len,

Do you want to take this one or should I?

-hpa

Quoted 1 line · helight

acpi_sfi_table_parse() should be __init. tested on x86 system!

#2 lore raw
Quoted 4 lines · H. Peter Anvin

Hi Len,

Do you want to take this one or should I?

ooh! both ok!thing is that we fix the problem!

Quoted 9 lines

-hpa

Quoted 2 lines · helight

acpi_sfi_table_parse() should be __init. tested on x86 system!

Signature · 3 lines
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org
author
#3 lore raw
In reply to H. Peter Anvin
Quoted 4 lines · H. Peter Anvin

Hi Len,

Do you want to take this one or should I?

ooh! both ok!thing is that we fix the problem!

Quoted 9 lines

-hpa

Quoted 2 lines · helight

acpi_sfi_table_parse() should be __init. tested on x86 system!

Signature · 3 lines
---------------------------------
Zhenwen Xu - Open and Free
Home Page:	http://zhwen.org