Give better message for pvmove when all data is skipped
PATCH 1/1 Give better message for pvmove when all data is skipped
Just a little thing - better message in pvmove, maybe :) BZ #500898/#500899
Peter
tools/pvmove.c +10 -0
@@ -180,6 +180,7 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,struct lv_list *lvl;uint32_t log_count =0 ;int lv_found =0 ; +int lv_skipped =0 ;/* FIXME Cope with non-contiguous => splitting existing segments */ if (!(lv_mirr = lv_create_empty("pvmove%d", NULL,
@@ -209,22 +210,27 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd, lv_found =1 ; }if (lv_is_origin (lv) ||lv_is_cow (lv)) { + lv_skipped =1 ;log_print ("Skipping snapshot-related LV %s" , lv->name);continue ; }if (lv->status &MIRRORED ) { + lv_skipped =1 ;log_print ("Skipping mirror LV %s" , lv->name);continue ; }if (lv->status &MIRROR_LOG ) { + lv_skipped =1 ;log_print ("Skipping mirror log LV %s" , lv->name);continue ; }if (lv->status &MIRROR_IMAGE ) { + lv_skipped =1 ;log_print ("Skipping mirror image LV %s" , lv->name);continue ; }if (lv->status &LOCKED ) { + lv_skipped =1 ;log_print ("Skipping locked LV %s" , lv->name);continue ; }
@@ -240,6 +246,10 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,/* Is temporary mirror empty? */ if (!lv_mirr->le_count) { +if (lv_skipped) +log_error ("All data on source PV skipped. " +"It contains locked, hidden or " +"non-top level LVs only." );log_error ("No data to move for %s" , vg->name);return NULL ; }
PATCH 1/1 Give better message for pvmove when all data is skipped
Quoted 2 lines · Peter Rajnoha
Just a little thing - better message in pvmove, maybe :) BZ #500898/#500899
("mention skipped LVs in pvmove error message")
Ack.
tools/pvmove.c static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd, · line 252
Quoted 3 lines
tools/pvmove.c +3
-0+log_error ("All data on source PV skipped. " +"It contains locked, hidden or " +"non-top level LVs only." );
This message probably need some better formulation (remove lvm internals?), please contact our lvm language dept. ;-)
Milan
--
mbroz at redhat.com