Skip to contentSkip to conversation

libxenlight resend: get state for one domain

PATCH In review Andres Lagar-Cavilla 3 participants 4 messages Dec 2, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 7/7 libxenlight resend: get state for one domain

Simple function to get the dominfo state of a single domain.

# HG changeset patch
# User Andres Lagar-Cavilla <[email protected]> # Date 1259285614 18000
# Node ID 39484f864ecb79a6541aee97748c8887f4e6f0cd # Parent a5f6b5cd5472fe914b57ef8aa7a97887c2aa9aab Simple function to get the dominfo state of a single domain.

libxl.c +20 -0
diff -r a5f6b5cd5472 -r 39484f864ecb libxl.c
@@ -362,6 +362,26 @@ static int libxl_save_device_model(struc
     return 0;
 }
 
+xc_dominfo_t *libxl_domain_info(struct libxl_ctx *ctx, uint32_t domid)
+{
+    xc_dominfo_t *info;
+    int rc;
+
+    info = (xc_dominfo_t *) calloc(1, sizeof(xc_dominfo_t));
+    if (!info) {
+        return NULL;
+    }
+
+    rc = xc_domain_getinfo(ctx->xch, domid, 1, info);
+    if (rc != 1) {
+        free(info);
+        XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "Failed to get info for domain %u", 
+                        domid);
+        return NULL;
+    }
+
+    return info;
+}
 int libxl_domain_suspend(struct libxl_ctx *ctx, libxl_domain_suspend_info *info,
                          uint32_t domid, int fd)
 {
libxl.h +1 -0
diff -r a5f6b5cd5472 -r 39484f864ecb libxl.h
@@ -283,6 +283,7 @@ int libxl_console_attach(struct libxl_ct
 
 struct libxl_dominfo * libxl_domain_list(struct libxl_ctx *ctx, int *nb_domain);
 xc_dominfo_t * libxl_domain_infolist(struct libxl_ctx *ctx, int *nb_domain);
+xc_dominfo_t * libxl_domain_info(struct libxl_ctx *ctx, uint32_t domid);
 
 typedef struct libxl_device_model_starting libxl_device_model_starting;
 int libxl_create_device_model(struct libxl_ctx *ctx,

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#2 lore raw
In reply to Andres Lagar-Cavilla
Quoted 3 lines · Andres Lagar-Cavilla

Simple function to get the dominfo state of a single domain.

the function is buggy. you need to check that you got the right domain before returning the domaininfo. the hypercall returns the first domain from the domid given. i.e. if domid is not available, domid+n might be returned.

Signature · 1 line
Vincent
#3 lore raw

PATCH 7/7 libxenlight meta-resend: get state for one domain

In reply to Andres Lagar-Cavilla

Simple function to get the dominfo state of a single domain.

# HG changeset patch
# User Andres Lagar-Cavilla <[email protected]> # Date 1259857202 18000
# Node ID 3588737e991624290d499c2804959af14b8128de # Parent 7315ca037a680d18a6c23d030139b5389a73000b Simple function to get the dominfo state of a single domain.

libxl.c +25 -0
diff -r 7315ca037a68 -r 3588737e9916 libxl.c
@@ -334,6 +334,31 @@ static int libxl_save_device_model(struc
     return 0;
 }
 
+xc_dominfo_t *libxl_domain_info(struct libxl_ctx *ctx, uint32_t domid)
+{
+    xc_dominfo_t *info;
+    int rc;
+
+    info = (xc_dominfo_t *) calloc(1, sizeof(xc_dominfo_t));
+    if (!info) {
+        return NULL;
+    }
+    rc = xc_domain_getinfo(ctx->xch, domid, 1, info);
+    if (rc != 1) {
+        free(info);
+        XL_LOG_ERRNO(ctx, XL_LOG_ERROR, "Failed to get info for domain %u", 
+                        domid);
+        return NULL;
+    }
+    if (info->domid != domid) {
+        free(info);
+        XL_LOG(ctx, XL_LOG_ERROR, "Failed to get info for domain %u"
+                        ", seems to not exist anymore", domid);
+        return NULL;
+    }
+
+    return info;
+}
 int libxl_domain_suspend(struct libxl_ctx *ctx, libxl_domain_suspend_info *info,
                          uint32_t domid, int fd)
 {
libxl.h +1 -0
diff -r 7315ca037a68 -r 3588737e9916 libxl.h
@@ -276,6 +276,7 @@ int libxl_console_attach(struct libxl_ct
 
 struct libxl_dominfo * libxl_domain_list(struct libxl_ctx *ctx, int *nb_domain);
 xc_dominfo_t * libxl_domain_infolist(struct libxl_ctx *ctx, int *nb_domain);
+xc_dominfo_t * libxl_domain_info(struct libxl_ctx *ctx, uint32_t domid);
 
 typedef struct libxl_device_model_starting libxl_device_model_starting;
 int libxl_create_device_model(struct libxl_ctx *ctx,

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel