Skip to contentSkip to conversation

xfs_io: enable missing functions

PATCH In review Eric Sandeen 2 participants 2 messages Dec 2, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs_io: enable missing functions

madvise and mincore were never hooked up to init_commands().

Further, there is no HAVE_INJECT test in the configure scripts, so just remove that test (and keep the existing unconditional inject_init() prototype.

---

io/init.c +2 -0
index 6539a55..f8fc25d 100644
@@ -64,6 +64,8 @@ init_commands(void)
 	help_init();
 	imap_init();
 	inject_init();
+	madvise_init();
+	mincore_init();
 	mmap_init();
 	open_init();
 	parent_init();
io/io.h +0 -6
index 43754ca..630897d 100644
@@ -112,12 +112,6 @@ extern void		fadvise_init(void);
 #define fadvise_init()	do { } while (0)
 #endif
 
-#ifdef HAVE_INJECT
-extern void		inject_init(void);
-#else
-#define inject_init()	do { } while (0)
-#endif
-
 #ifdef HAVE_RESBLKS
 extern void		resblks_init(void);
 #else

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eric Sandeen

madvise and mincore were never hooked up to init_commands().

Further, there is no HAVE_INJECT test in the configure scripts, so just remove that test (and keep the existing unconditional inject_init() prototype.

Hmm, maybe Nathan still has an idea what it's for, probably some IRIX build.

Anyway, the madvise and mincore wireup looks good. Note entirely sure what they do in xfs_io, though - they're VM syscalls not filesystem and don't cause I/O normally.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs