Skip to contentSkip to conversation

ocfs2: explicit declare uninitialized var in user_cluster_connect()

PATCH New Coly Li 2 participants 2 messages Dec 3, 2009 – Dec 18, 2009 OCFS2

lore
Share & tools
lore

Coly Li

author
#0 lore raw

PATCH 1/1 ocfs2: explicit declare uninitialized var in user_cluster_connect()

This patch explicitly declares an uninitialized local variable in user_cluster_connect(), to remove a compiling warning.

---
 fs/ocfs2/stack_user.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/ocfs2/stack_user.c +1 -1
index ff4c798..da78a2a 100644
@@ -814,7 +814,7 @@ static int fs_protocol_compare(struct ocfs2_protocol_version *existing,
 static int user_cluster_connect(struct ocfs2_cluster_connection *conn)
 {
 	dlm_lockspace_t *fsdlm;
-	struct ocfs2_live_connection *control;
+	struct ocfs2_live_connection *uninitialized_var(control);
 	int rc = 0;
 
 	BUG_ON(conn == NULL);
Signature · 2 lines
Coly Li
SuSE Labs
#1 lore raw

PATCH 1/1 ocfs2: explicit declare uninitialized var in user_cluster_connect()

Quoted 1 line · Coly Li

This patch explicitly declares an uninitialized local variable in user_cluster_connect(), to remove a compiling warning.

This is now in the 'merge-window' branch of ocfs2.git.

Joel

Signature · 9 lines
"Can any of you seriously say the Bill of Rights could get through
 Congress today?  It wouldn't even get out of committee."
	- F. Lee Bailey

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127