Skip to contentSkip to conversation

ath9k: fix tx status reporting

PATCH Felix Fietkau 1 participant 1 message Dec 5, 2009 Qualcomm Atheros ATH9K wireless driver

lore
Share & tools
lore
#0 lore raw

This patch fixes a bug in ath9k's tx status check, which caused mac80211 to consider regularly transmitted unicast frames as un-acked.
When checking the ts_status field for errors, it needs to be masked with ATH9K_TXERR_FILT, because this field also contains other fields like ATH9K_TX_ACKED.
Without this patch, AP mode is pretty much unusable, as hostapd checks the ACK status for the frames that it injects.

---

drivers/net/wireless/ath/ath9k/xmit.c +1 -1
@@ -2078,7 +2078,7 @@ static void ath_tx_processq(struct ath_s
 				&txq->axq_q, lastbf->list.prev);
 
 		txq->axq_depth--;
-		txok = (ds->ds_txstat.ts_status == 0);
+		txok = !(ds->ds_txstat.ts_status & ATH9K_TXERR_FILT);
 		txq->axq_tx_inprogress = false;
 		spin_unlock_bh(&txq->axq_lock);