dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()
Subsystems (2)
PATCH 1/1 dasd: PTR_ERR return of wrong pointer in dasd_alias_make_device_known_to_lcu()
Return the PTR_ERR of the correct pointer.
Signed-off-by Roel Kluin <[email protected]>
--- drivers/s390/block/dasd_alias.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Unless I am mistaken?
drivers/s390/block/dasd_alias.c +1 -1
@@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)spin_unlock_irqrestore (&aliastree.lock, flags); newlcu =_allocate_lcu (uid);if (IS_ERR (newlcu)) -return PTR_ERR (lcu); +return PTR_ERR (newlcu);spin_lock_irqsave (&aliastree.lock, flags); lcu =_find_lcu (server, uid);if (!lcu) {
Quoted 14 lines · On Mon, 07 Dec 2009 14:18:40 +0100 Roel Kluin <[email protected]> wrote:
Return the
PTR_ERRof the correct pointer.Signed-off-by Roel Kluin <[email protected]>--- drivers/s390/block/dasd_alias.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Unless I am mistaken?
drivers/s390/block/dasd_alias.c +0
-0
drivers/s390/block/dasd_alias.c int dasd_alias_make_device_known_to_lcu(struct dasd_device *device) · line 223
Quoted 8 lines
drivers/s390/block/dasd_alias.c +1
-1@@ -217,7 +217,7 @@ int dasd_alias_make_device_known_to_lcu(struct dasd_device *device)spin_unlock_irqrestore (&aliastree.lock, flags); newlcu =_allocate_lcu (uid);if (IS_ERR (newlcu)) -return PTR_ERR (lcu); +return PTR_ERR (newlcu);spin_lock_irqsave (&aliastree.lock, flags); lcu =_find_lcu (server, uid);if (!lcu) {
You are not mistaken. I'll add the patch to the queue. Thanks.
Signature · 4 lines
blue skies, Martin. "Reality continues to ruin my life." - Calvin.