Skip to contentSkip to conversation

x86, mce: fix wrong change in mce_create_device

PATCH In review Hidetoshi Seto 1 participant 2 messages Dec 8, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86, mce: fix wrong change in mce_create_device

commit cebe182033f156b430952370fb0f9dbe6e89b081 had an unnecessary, wrong change. Fix it.

---
 arch/x86/kernel/cpu/mcheck/mce.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/mce.c +1 -1
index a96e5cd..a8aacd4 100644
@@ -1929,7 +1929,7 @@ error2:
 		sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[j].attr);
 error:
 	while (--i >= 0)
-		sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[i].attr);
+		sysdev_remove_file(&per_cpu(mce_dev, cpu), mce_attrs[i]);
 
 	sysdev_unregister(&per_cpu(mce_dev, cpu));
 
Signature · 1 line
1.6.5.5
#1 lore raw

[tip:x86/urgent] x86, mce: fix confusion between bank attributes and mce attributes

Commit-ID:  5c0e9f28da84c68ce0ae68b7a75faaf862e156e2
Gitweb:     http://git.kernel.org/tip/5c0e9f28da84c68ce0ae68b7a75faaf862e156e2
Author:     Hidetoshi Seto <[email protected]>
AuthorDate: Tue, 8 Dec 2009 16:52:44 +0900
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Tue, 8 Dec 2009 12:11:20 -0800

x86, mce: fix confusion between bank attributes and mce attributes

Commit cebe182033f156b430952370fb0f9dbe6e89b081 had an unnecessary, wrong change: &mce_banks[i].attr is equivalent to the former bank_attrs[i], not to mce_attrs[i].

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/mcheck/mce.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mcheck/mce.c +1 -1
index a96e5cd..a8aacd4 100644
@@ -1929,7 +1929,7 @@ error2:
 		sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[j].attr);
 error:
 	while (--i >= 0)
-		sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[i].attr);
+		sysdev_remove_file(&per_cpu(mce_dev, cpu), mce_attrs[i]);
 
 	sysdev_unregister(&per_cpu(mce_dev, cpu));