Skip to contentSkip to conversation

opensm/libvendor//osm_vendor_ibumad_sa.c: uninitialized fields

PATCH In review Yevgeny Kliteynik 1 participant 2 messages Dec 9, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 opensm/libvendor//osm_vendor_ibumad_sa.c: uninitialized fields

Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-Path: [email protected]
X-OriginalArrivalTime: 09 Dec 2009 00:05:42.0455 (UTC) FILETIME=[590C3C70:01CA7863]

Taking care of couple of uninitialized fields.
Discovered with 'osmtest -f a' - bad things
start to happen when a packet is dropped, and
osmtest should really get a timeout.

---
 opensm/libvendor/osm_vendor_ibumad_sa.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
opensm/libvendor/osm_vendor_ibumad_sa.c +2 -0
index e05a5ef..78f2bce 100644
@@ -241,6 +241,8 @@ osmv_bind_sa(IN osm_vendor_t * const p_vend,
 	bind_info.is_report_processor = FALSE;
 	bind_info.send_q_size = OSM_SM_DEFAULT_QP1_RCV_SIZE;
 	bind_info.recv_q_size = OSM_SM_DEFAULT_QP1_SEND_SIZE;
+	bind_info.timeout = OSM_DEFAULT_TRANS_TIMEOUT_MILLISEC;
+	bind_info.retries = OSM_DEFAULT_RETRY_COUNT;
 
 	/* allocate the new sa bind info */
 	p_sa_bind_info =
Signature · 6 lines
1.5.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4B1EEBDA.5070501-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw

Hi Sasha,

Quoted 4 lines · Yevgeny Kliteynik

Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-Path: [email protected]
X-OriginalArrivalTime: 09 Dec 2009 00:05:42.0455 (UTC) FILETIME=[590C3C70:01CA7863]

No idea where did this header came from.
I'll try to re-send the patch.

-- Yevgeny

Quoted 15 lines

Taking care of couple of uninitialized fields. Discovered with 'osmtest -f a' - bad things start to happen when a packet is dropped, and osmtest should really get a timeout.

---
  opensm/libvendor/osm_vendor_ibumad_sa.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
opensm/libvendor/osm_vendor_ibumad_sa.c +0 -0
index e05a5ef..78f2bce 100644

opensm/libvendor/osm_vendor_ibumad_sa.c osmv_bind_sa(IN osm_vendor_t * const p_vend, · line 248

Quoted 8 lines
opensm/libvendor/osm_vendor_ibumad_sa.c +2 -0
@@ -241,6 +241,8 @@ osmv_bind_sa(IN osm_vendor_t * const p_vend,
  	bind_info.is_report_processor = FALSE;
  	bind_info.send_q_size = OSM_SM_DEFAULT_QP1_RCV_SIZE;
  	bind_info.recv_q_size = OSM_SM_DEFAULT_QP1_SEND_SIZE;
+	bind_info.timeout = OSM_DEFAULT_TRANS_TIMEOUT_MILLISEC;
+	bind_info.retries = OSM_DEFAULT_RETRY_COUNT;
 
  	/* allocate the new sa bind info */
  	p_sa_bind_info =

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html