Skip to contentSkip to conversation

trace_syscalls: fix SYSCALL_DEFINE0

PATCH In review Lai Jiangshan 2 participants 2 messages Dec 9, 2009 – Dec 14, 2009 ABI/API

lore
Share & tools
lore
#0 lore raw

PATCH 2/10 trace_syscalls: fix SYSCALL_DEFINE0

struct syscall_metadata variable name in SYSCALL_DEFINE0 is not the same as SYSCALL_DEFINE1/2/3/4/5/6.

SYSCALL_TRACE_ENTER_EVENT() and SYSCALL_TRACE_EXIT_EVENT() expect struct syscall_metadata's name is __syscall_meta__XXXXXX as SYSCALL_DEFINE1/2/3/4/5/6 defines.

It causes event_enter_##sname->data points to a wrong place. (event_enter_##sname->data points to a dummy struct syscall_metadata)

It causes syscalls which are defined by SYSCALL_DEFINE0() can not be traced.

---

include/linux/syscalls.h +1 -1
index 55e7108..bee1d41 100644
@@ -196,7 +196,7 @@ struct perf_event_attr;
 	static const struct syscall_metadata __used		\
 	  __attribute__((__aligned__(4)))			\
 	  __attribute__((section("__syscalls_metadata")))	\
-	  __syscall_meta_##sname = {				\
+	  __syscall_meta__##sname = {				\
 		.name 		= "sys_"#sname,			\
 		.nb_args 	= 0,				\
 		.enter_event	= &event_enter__##sname,	\
Acked-by on v1 2/10
#1 lore raw
Quoted 20 lines · Lai Jiangshan

struct syscall_metadata variable name in SYSCALL_DEFINE0 is not the same as SYSCALL_DEFINE1/2/3/4/5/6.

SYSCALL_TRACE_ENTER_EVENT() and SYSCALL_TRACE_EXIT_EVENT() expect struct syscall_metadata's name is __syscall_meta__XXXXXX as SYSCALL_DEFINE1/2/3/4/5/6 defines.

It causes event_enter_##sname->data points to a wrong place. (event_enter_##sname->data points to a dummy struct syscall_metadata)

It causes syscalls which are defined by SYSCALL_DEFINE0() can not be traced.

---

include/linux/syscalls.h +0 -0
index 55e7108..bee1d41 100644

include/linux/syscalls.h struct perf_event_attr; · line 202

Quoted 8 lines
include/linux/syscalls.h +1 -1
@@ -196,7 +196,7 @@ struct perf_event_attr;
 	static const struct syscall_metadata __used		\
 	  __attribute__((__aligned__(4)))			\
 	  __attribute__((section("__syscalls_metadata")))	\
-	  __syscall_meta_##sname = {				\
+	  __syscall_meta__##sname = {				\
 		.name 		= "sys_"#sname,			\
 		.nb_args 	= 0,				\
 		.enter_event	= &event_enter__##sname,	\