Skip to contentSkip to conversation

cfq: Remove wait_request flag when idle time is being deleted

PATCH In review Gui Jianfeng 2 participants 2 messages Dec 10, 2009 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfq: Remove wait_request flag when idle time is being deleted

Hi Jens,

I post this patch a few month ago, it seems to get missing, repost again.

Remove wait_request flag when idle time is being deleted.

---
 block/cfq-iosched.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
block/cfq-iosched.c +1 -0
index 69ecee7..96f59ae 100644
@@ -3202,6 +3202,7 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
 			if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
 			    cfqd->busy_queues > 1) {
 				del_timer(&cfqd->idle_slice_timer);
+				cfq_clear_cfqq_wait_request(cfqq);
 				__blk_run_queue(cfqd->queue);
 			} else
 				cfq_mark_cfqq_must_dispatch(cfqq);
Signature · 1 line
1.5.4.rc3
#1 lore raw
Quoted 16 lines · Gui Jianfeng

Hi Jens,

I post this patch a few month ago, it seems to get missing, repost again.

Remove wait_request flag when idle time is being deleted.

---
 block/cfq-iosched.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
block/cfq-iosched.c +0 -0
index 69ecee7..96f59ae 100644

block/cfq-iosched.c cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq, · line 3208

Quoted 7 lines
block/cfq-iosched.c +1 -0
@@ -3202,6 +3202,7 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
 			if (blk_rq_bytes(rq) > PAGE_CACHE_SIZE ||
 			    cfqd->busy_queues > 1) {
 				del_timer(&cfqd->idle_slice_timer);
+				cfq_clear_cfqq_wait_request(cfqq);
 				__blk_run_queue(cfqd->queue);
 			} else
 				cfq_mark_cfqq_must_dispatch(cfqq);

Hmm weird, I think it may have gone missing in a badly done merge. I'll add it, thanks.

Signature · 1 line
Jens Axboe