Skip to contentSkip to conversation

Return value of print_graph_prologue

DISCUSSION Wenji Huang 2 participants 2 messages Dec 11, 2009

lore
Share & tools
lore
#0 lore raw

Hi,

I got confused about the return value of print_graph_prologue. See:

805 /* Latency format */
806 if (trace_flags & TRACE_ITER_LATENCY_FMT) {
807 ret = print_graph_lat_fmt(s, ent);
808 if (ret == TRACE_TYPE_PARTIAL_LINE)
809 return TRACE_TYPE_PARTIAL_LINE;
810 }
811
812 return 0;
813 }

But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's no difference between success and failure?

Should it be TRACE_TYPE_HANDLED ?

Regards,
Wenji

#1 lore raw
Quoted 14 lines · Wenji Huang

Hi,

I got confused about the return value of print_graph_prologue. See:

805 /* Latency format */
806 if (trace_flags & TRACE_ITER_LATENCY_FMT) {
807 ret = print_graph_lat_fmt(s, ent);
808 if (ret == TRACE_TYPE_PARTIAL_LINE)
809 return TRACE_TYPE_PARTIAL_LINE;
810 }
811
812 return 0;
813 }

Quoted 7 lines

But we have defined TRACE_TYPE_PARTIAL_LINE = 0. So there's no difference between success and failure?

Should it be TRACE_TYPE_HANDLED ?

Regards,
Wenji

Oh, good catch, I'm preparing a fix.

Thanks.