Skip to contentSkip to conversation

mlx4_core: return a negative error value

PATCH Applied Roel Kluin 2 participants 2 messages Dec 12, 2009 – Dec 14, 2009

Subsystems (2)
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 mlx4_core: return a negative error value

The return value should be negative.

---
 drivers/net/mlx4/sense.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

This is a cleanup, its only caller, mlx4_do_sense_ports() acts on any non-zero error values as well.

drivers/net/mlx4/sense.c +1 -1
index f36ae69..015fbe7 100644
@@ -53,7 +53,7 @@ static int mlx4_SENSE_PORT(struct mlx4_dev *dev, int port,
 
 	if (out_param > 2) {
 		mlx4_err(dev, "Sense returned illegal value: 0x%llx\n", out_param);
-		return EINVAL;
+		return -EINVAL;
 	}
 
 	*type = out_param;