broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()

PATCH Applied Roel Kluin 3 participants 3 messages Dec 16, 2009 – Dec 19, 2009

Subsystems (4)

Networking Network drivers Ethernet PHY Broadcom Ethernet PHY drivers

lore

Share & tools

lore

Roel Kluin

author

2009-12-16 13:00 UTC #0 lore raw

PATCH 1/1 broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()

If not signed read errors are ignored.

Signed-off-by Roel Kluin <[email protected]>

---
Found using coccinelle: http://coccinelle.lip6.fr/

drivers/net/phy/broadcom.c +2 -1

index f63c96a..c13cf64 100644
@@ -326,7 +326,8 @@ error:
 
 static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
 {
-	u32 val, orig;
+	u32 orig;
+	int val;
 	bool clk125en = true;
 
 	/* Abort if we are using an untested phy. */

Matt Carlson

Acked-by on v1 1/1

2009-12-18 01:41 UTC #1 lore raw

Quoted 3 lines · Roel Kluin

If not signed read errors are ignored.
Signed-off-by Roel Kluin <[email protected]>

Acked-by Matt Carlson <[email protected]>

Quoted 18 lines

---
Found using coccinelle: http://coccinelle.lip6.fr/

drivers/net/phy/broadcom.c +2 -1

index f63c96a..c13cf64 100644
@@ -326,7 +326,8 @@ error:
 
 static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
 {
-	u32 val, orig;
+	u32 orig;
+	int val;
 	bool clk125en = true;
 
 	/* Abort if we are using an untested phy. */

David Miller

maintainer Applied

2009-12-19 04:16 UTC #2 lore raw

From: "Matt Carlson" <[email protected]>
Date: Thu, 17 Dec 2009 17:41:39 -0800

Quoted 6 lines · Roel Kluin

Quoted 3 lines
If not signed read errors are ignored.
Signed-off-by Roel Kluin <[email protected]>
Acked-by Matt Carlson <[email protected]>

Applied, thanks.