Skip to contentSkip to conversation

kvm-ia64 spinlocks

DISCUSSION Avi Kivity 1 participant 1 message Dec 17, 2009

lore
Share & tools
lore

Avi Kivity

author
#0 lore raw
Quoted 5 lines · Tony

[resend with fixed vger address :-) ]

Len Brown pointed out that allmodconfig is broken for ia64 because of:

Quoted 8 lines

arch/ia64/kvm/vmm.c: In function 'vmm_spin_unlock':
arch/ia64/kvm/vmm.c:70: error: 'spinlock_t' has no member named 'raw_lock'

This is fall-out from the ia64 switch to ticket locks.

I'm not sure why KVM needs to implement its own locking mechanisms ... if it does need to roll its own, it should not depend on the base kernel spinlock_t type.

It does, parts of the ia64 vmm run in guest context.

Quoted 5 lines

One possible
solution is to just have KVM define its own vmm_spinlock_t type (see patch below).

Looks good. Changelog/signoff?

Quoted 2 lines

Or perhaps this code needs to implement ticket locks?

This will do for now, I believe.

Signature · 1 line
error compiling committee.c: too many arguments to function