posix_acl: Add the check items
PATCH v2 5/12 posix_acl: Add the check items
move the ACL validation check in to fs/posix_acl.c. Including nullpointer check and PTR_ERR check.
---
Signed-off-by Liuwenyi <[email protected]>
Cc "Theodore Ts'o" <[email protected]>
Cc Andreas Dilger <[email protected]>
Cc Al Viro <[email protected]>
Cc James Morris <[email protected]>
Cc Joel Becker <[email protected]>
Cc Serge Hallyn <[email protected]>
Cc Christoph Hellwig <[email protected]>
---
fs/ext4/acl.c +0 -0
@@ -430,13 +430,11 @@ ext4_xattr_set_acl(struct dentry *dentry, const
char *name, const void *value,
if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- error = posix_acl_valid(acl);
- if (error)
- goto release_and_out;
- }
+
+ error = posix_acl_valid(acl);
+ if (error)
+ goto release_and_out;
+
} else
acl = NULL;
Signature · 2 lines
Best Regards, Liuwenyi