qemu-kvm-0.12.1.1

ANNOUNCE Avi Kivity 5 participants 14 messages Dec 22, 2009 – Jan 4, 2010 1 message not in the archive KVM

Share & tools

Avi Kivity

author

2009-12-22 12:50 UTC #0 lore raw

qemu-kvm-0.12.1.1 is now available. This release is is based on the upstream qemu 0.12.1, plus kvm-specific enhancements. Please see the original qemu 0.12.1 release announcement for details.

This release can be used with the kvm kernel modules provided by your distribution kernel, or by the modules in the kvm-kmod package, such as kvm-kmod-2.6.32.

Changes from qemu-kvm-0.12.1
- fix build error due to missing kvm_save_mpstate() on some configurations
- fix option rom loading (fixes boot=on)

http://www.linux-kvm.org

Signature · 1 line

error compiling committee.c: too many arguments to function

Nikola Ciprich

2009-12-22 13:34 UTC #1 lore raw

sorry to bring bad news, but it still doesn't compile (at least for me):

[root@vmdev03 qemu-kvm-0.12.1.1]# make
LINK x86_64-softmmu/qemu-system-x86_64
machine.o: In function `cpu_pre_save':
/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

Quoted 23 lines · Avi Kivity

qemu-kvm-0.12.1.1 is now available. This release is is based on the upstream qemu 0.12.1, plus kvm-specific enhancements. Please see the original qemu 0.12.1 release announcement for details.
This release can be used with the kvm kernel modules provided by your distribution kernel, or by the modules in the kvm-kmod package, such as kvm-kmod-2.6.32.
Changes from qemu-kvm-0.12.1
- fix build error due to missing kvm_save_mpstate() on some configurations
- fix option rom loading (fixes boot=on)
http://www.linux-kvm.org
Signature · 6 lines
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 13 lines

-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: [email protected]
-------------------------------------

Avi Kivity

author

2009-12-22 13:43 UTC #2 lore raw

Quoted 10 lines · Nikola Ciprich

sorry to bring bad news, but it still doesn't compile (at least for me):
[root@vmdev03 qemu-kvm-0.12.1.1]# make
LINK x86_64-softmmu/qemu-system-x86_64
machine.o: In function `cpu_pre_save':
/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

Please provide details about your host.

Signature · 1 line

error compiling committee.c: too many arguments to function

Nikola Ciprich

2009-12-22 14:07 UTC #3 lore raw

CentOS5, all packages updated.
But I just noticed build fails only when configured with multiple targets, including some more exotic (based on fedora spec).
building just using x86_64-softmmu works fine for me.
n.

Quoted 21 lines · Avi Kivity

Quoted 9 lines · Nikola Ciprich
sorry to bring bad news, but it still doesn't compile (at least for me):
[root@vmdev03 qemu-kvm-0.12.1.1]# make
LINK x86_64-softmmu/qemu-system-x86_64
machine.o: In function `cpu_pre_save':
/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
Please provide details about your host.
Signature · 6 lines
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 13 lines

-------------------------------------
Ing. Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799
www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: [email protected]
-------------------------------------

Avi Kivity

author

2009-12-22 14:09 UTC #4 lore raw

Quoted 5 lines · Nikola Ciprich

CentOS5, all packages updated.
But I just noticed build fails only when configured with multiple targets, including some more exotic (based on fedora spec).
building just using x86_64-softmmu works fine for me.

Okay, so at least it works out of the box (no special configure option).

Hopefully someone will figure out why other targets cause it to fail - looks like some files are compiled with the wrong config.h.

Signature · 1 line

error compiling committee.c: too many arguments to function

A message that is not in the archive (sent off-list or not yet received): [email protected]

Nikola Ciprich

2009-12-25 12:44 UTC #6 lore raw

Hi Marcelo,
Avi has already fixed this particular problem in the meantime, but I checked and your patch fixes build problem as well.. thanks!
have a nice day
nik

Quoted 38 lines · Marcelo Tosatti

Quoted 16 lines · Nikola Ciprich
CentOS5, all packages updated.
But I just noticed build fails only when configured with multiple targets, including some more exotic (based on fedora spec).
building just using x86_64-softmmu works fine for me.
n.
Quoted 10 lines · Avi Kivity
Quoted 9 lines · Nikola Ciprich
sorry to bring bad news, but it still doesn't compile (at least for me):
[root@vmdev03 qemu-kvm-0.12.1.1]# make
LINK x86_64-softmmu/qemu-system-x86_64
machine.o: In function `cpu_pre_save':
/usr/src/redhat/BUILD/qemu-kvm-0.12.1.1/target-i386/machine.c:326: undefined reference to `kvm_save_mpstate'
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2
Nikola,
Can you please confirm the attached patch fixes the undefined reference problem for you?
Thanks
qemu-kvm.h +1 -0
index a81ff12..6b3e5a1 100644
@@ -1070,6 +1070,7 @@ void kvm_load_tsc(CPUState *env);
 #endif
 #define kvm_load_registers(env) do {} while(0)
 #define kvm_save_registers(env) do {} while(0)
+#define kvm_save_mpstate(env)   do {} while(0)
 #define qemu_kvm_cpu_stop(env) do {} while(0)
 static inline void kvm_init_vcpu(CPUState *env)
 {

Signature · 14 lines

-------------------------------------
Nikola CIPRICH
LinuxBox.cz, s.r.o.
28. rijna 168, 709 01 Ostrava

tel.:   +420 596 603 142
fax:    +420 596 621 273
mobil:  +420 777 093 799

www.linuxbox.cz

mobil servis: +420 737 238 656
email servis: [email protected]
-------------------------------------

Thomas Treutner

2009-12-23 08:17 UTC #7 lore raw

In reply to Avi Kivity

Quoted 3 lines · On Tuesday 22 December 2009 13:50:03 you wrote:

Changes from qemu-kvm-0.12.1
- fix build error due to missing kvm_save_mpstate() on some configurations
- fix option rom loading (fixes boot=on)

Doesn't compile for me with default settings (./configure && make):

  CC    x86_64-softmmu/i386-dis.o
  AR    x86_64-softmmu/libqemu.a
  LINK  x86_64-softmmu/qemu-system-x86_64

/usr/lib/libxenguest.a(xg_private.o): In function `unlock_pages':
(.text+0x470): multiple definition of unlock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.text+0x5d0): first defined here /usr/lib/libxenguest.a(xg_private.o): In function lock_pages':
(.text+0x4c0): multiple definition of `lock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.text+0x650): first defined here
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

Host is Debian Lenny AMD64 with all updates.

Package: libxen-dev
Status: install ok installed
Priority: extra
Section: libdevel
Installed-Size: 920
Maintainer: Debian Xen Team <[email protected]>
Architecture: amd64
Source: xen-3
Version: 3.2.1-2
Depends: libxenstore3.0 (= 3.2.1-2)
Description: Public headers and libs for Xen
This package contains the public headers and static libraries for Xen.

I did --disable-xen to make it work for now, don't need xen-related stuff.

kr,t

Avi Kivity

author

2009-12-23 08:52 UTC #8 lore raw

Quoted 11 lines · Thomas Treutner

Quoted 4 lines · On Tuesday 22 December 2009 13:50:03 you wrote:
Changes from qemu-kvm-0.12.1
- fix build error due to missing kvm_save_mpstate() on some configurations
- fix option rom loading (fixes boot=on)
Doesn't compile for me with default settings (./configure&& make):
   CC    x86_64-softmmu/i386-dis.o
   AR    x86_64-softmmu/libqemu.a
   LINK  x86_64-softmmu/qemu-system-x86_64

Quoted 11 lines

/usr/lib/libxenguest.a(xg_private.o): In function `unlock_pages':
(.text+0x470): multiple definition of unlock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.text+0x5d0): first defined here /usr/lib/libxenguest.a(xg_private.o): In function lock_pages':
(.text+0x4c0): multiple definition of `lock_pages' /usr/lib/libxenctrl.a(xc_private.o):(.text+0x650): first defined here
collect2: ld returned 1 exit status
make[1]: *** [qemu-system-x86_64] Error 1
make: *** [subdir-x86_64-softmmu] Error 2

It looks like a problem in the Xen library? Or maybe we're including the library twice.

There's no unlock_pages in qemu.

Can you rerun with V=1 to see the full command line?

Signature · 1 line

error compiling committee.c: too many arguments to function

Thomas Treutner

2009-12-23 10:15 UTC #9 lore raw

Quoted 6 lines · On Wednesday 23 December 2009 09:52:47 you wrote:

It looks like a problem in the Xen library? Or maybe we're including the library twice.
There's no unlock_pages in qemu.
Can you rerun with V=1 to see the full command line?

Please see here: http://pastebin.com/f4d79c982

(make -j8 vs. just make doesn't make a difference, tested that)...

kr,t

Avi Kivity

author

2009-12-23 10:24 UTC #10 lore raw

Quoted 5 lines · Thomas Treutner

Quoted 3 lines · On Wednesday 23 December 2009 09:52:47 you wrote:
It looks like a problem in the Xen library? Or maybe we're including the library twice.

Quoted 9 lines

Quoted 4 lines
There's no unlock_pages in qemu.
Can you rerun with V=1 to see the full command line?
Please see here: http://pastebin.com/f4d79c982
(make -j8 vs. just make doesn't make a difference, tested that)...

Please post a full log, after 'make clean'.

Signature · 1 line

error compiling committee.c: too many arguments to function

Thomas Treutner

2009-12-23 10:58 UTC #11 lore raw

Quoted 1 line · On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:

Please post a full log, after 'make clean'.

http://pastebin.com/f404c8648

kr,t

Avi Kivity

author

2009-12-23 11:38 UTC #12 lore raw

Quoted 7 lines · Thomas Treutner

Quoted 2 lines · On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
http://pastebin.com/f404c8648

Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.

Copying Gerd for an opinion.

Signature · 1 line

error compiling committee.c: too many arguments to function

Gerd Hoffmann

2010-01-04 15:22 UTC #13 lore raw

Quoted 7 lines · Avi Kivity

Quoted 4 lines · Thomas Treutner
Quoted 1 line · On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
http://pastebin.com/f404c8648
Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.

Indeed, there are (un)lock_pages functions in both libraries. It is fixed in xen 3.3+, where libxenguest doesn't has these functions any more.

/me also wonders why Debian seems to have only static xen libraries.
I think when linking against the shared libraries avoids this too as the functions are supposed to be library-internal.

Quoted 1 line

Copying Gerd for an opinion.

I think there isn't much we can do about this, it is clearly a xen bug.

Uhm, well, while thinking about it: The test app compiled and linked by configure should have failed in a simliar way, thereby automatically disabling xen support. I have no idea why it didn't ...

cheers,
Gerd

Michael S. Tsirkin

2010-01-04 15:55 UTC #14 lore raw

Quoted 17 lines · Gerd Hoffmann

Quoted 7 lines · Avi Kivity
Quoted 4 lines · Thomas Treutner
Quoted 1 line · On Wednesday 23 December 2009 11:24:04 Avi Kivity wrote:
Please post a full log, after 'make clean'.
http://pastebin.com/f404c8648
Oh, I missed it at first - looks like libxenguest and libxenctrl conflict.
Indeed, there are (un)lock_pages functions in both libraries. It is fixed in xen 3.3+, where libxenguest doesn't has these functions any more.
/me also wonders why Debian seems to have only static xen libraries. I think when linking against the shared libraries avoids this too as the functions are supposed to be library-internal.

Quoted 7 lines

Quoted 1 line
Copying Gerd for an opinion.
I think there isn't much we can do about this, it is clearly a xen bug.
Uhm, well, while thinking about it: The test app compiled and linked by configure should have failed in a simliar way, thereby automatically disabling xen support. I have no idea why it didn't ...

"static library" is in fact just an archive of objects. If you happen not to pull in the conflicting objects, you won't see the conflict.
So test file would have to call lock_pages/unlock_pages for config to detect the issue.

Quoted 6 lines

cheers,
Gerd
--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html