Skip to contentSkip to conversation

opensm/osm_mcast_mgr.c: fix osm_mcast_mgr_compute_max_hops for managed switch

PATCH Applied Yevgeny Kliteynik 2 participants 2 messages Dec 23, 2009 – Dec 24, 2009 1 message not in the archive InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 opensm/osm_mcast_mgr.c: fix osm_mcast_mgr_compute_max_hops for managed switch

If a certain mcast group has only one member, and this member is a switch, OSM fails to select this switch when trying to create spanning tree for this mcast group:

ERR 0A08: Unable to locate a suitable switch for group 0xC000 ERR 0A17: Unable to create spanning tree (IB_ERROR) for mlid 0xc000

---
V2: no need to handle the case with no
members in mcast group, it is already
handled by the caller function.

 opensm/opensm/osm_mcast_mgr.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
opensm/opensm/osm_mcast_mgr.c +3 -5
index 697fb58..6bcbec4 100644
@@ -215,11 +215,9 @@ static float osm_mcast_mgr_compute_max_hops(osm_sm_t * sm, cl_qlist_t * l,
 			max_hops = hops;
 	}
 
-	if (max_hops == 0)
-		/*
-		   We should be here if there aren't any ports in the group.
-		 */
-		max_hops = 10001;	/* see later - we use it to realize no hops */
+	/* Note that at this point we might get (max_hops == 0),
+	   which means that there's only one member in the mcast
+	   group, and it's the current switch */
 
 	OSM_LOG_EXIT(sm->p_log);
 	return (float)max_hops;
Signature · 6 lines
1.5.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 4B322CBC.1070805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw
Quoted 8 lines · Yevgeny Kliteynik

If a certain mcast group has only one member, and this member is a switch, OSM fails to select this switch when trying to create spanning tree for this mcast group:

ERR 0A08: Unable to locate a suitable switch for group 0xC000 ERR 0A17: Unable to create spanning tree (IB_ERROR) for mlid 0xc000

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html