Skip to contentSkip to conversation

atarilance: timeout ignored in lance_open()

PATCH In review Roel Kluin 1 participant 2 messages Dec 27, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 atarilance: timeout ignored in lance_open()

With `while (--limit > 0)' i reaches 0 after the loop, so upon timeout the error was not returned.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/niu.c +1 -1
index 8ce58c4..2aed2b3 100644
@@ -2844,7 +2844,7 @@ static int tcam_wait_bit(struct niu *np, u64 bit)
 			break;
 		udelay(1);
 	}
-	if (limit < 0)
+	if (limit <= 0)
 		return -ENODEV;
 
 	return 0;
author
#1 lore raw

Op 27-12-09 14:28, Roel Kluin schreef:

drivers/net/niu.c

Quoted 6 lines

With `while (--limit > 0)' i reaches 0 after the loop, so upon timeout the error was not returned.

Signed-off-by Roel Kluin <[email protected]>

---

drivers/net/niu.c +0 -0

Oops, forgot to update the subject, please ignore, I'll send another.

Roel