Skip to contentSkip to conversation

NUC900: Add extern header file support for some driver

PATCH New Wan ZongShun 4 participants 7 messages Jan 2, 2010 – Jan 5, 2010 1 message not in the archive

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Wan ZongShun

author
#0 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
(quoted diff) +0 -0

b/arch/arm/mach-w90x900/include/mach/clkdev.h
index 04b37a8..b35f4bc 100644

arch/arm/mach-w90x900/include/mach/clkdev.h +1 -0
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)
 
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char

*src,
+ unsigned char divider);
+
#endif

(quoted diff) +0 -0

b/arch/arm/mach-w90x900/include/mach/mfp.h
new file mode 100644
index 0000000..69a094a

arch/arm/mach-w90x900/include/mach/mfp.h new file +23 -0
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-w90x900/include/mach/mfp.h
+ *
+ * Copyright (c) 2008 Nuvoton technology corporation
+ * All rights reserved.
+ *
+ * Wan ZongShun <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ */
+#ifndef __ASM_ARM_MFP_H
+#define __ASM_ARM_MFP_H
+
+extern void mfp_set_groupf(struct device *dev);
+extern void mfp_set_groupc(struct device *dev);
+extern void mfp_set_groupi(struct device *dev);
+extern void mfp_set_groupg(struct device *dev);
+
+#endif /* __ASM_ARM_MFP_H */
Signature · 1 line
1.5.6.3

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

Dear Sergei,

You are right, and it reason from my mail client setting. Re-submit it.

Signed-off-by Wan ZongShun <[email protected]>
---
  arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
  arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
  2 files changed, 26 insertions(+), 0 deletions(-)

create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h

(quoted diff) +0 -0

b/arch/arm/mach-w90x900/include/mach/clkdev.h
index 04b37a8..b35f4bc 100644

arch/arm/mach-w90x900/include/mach/clkdev.h +3 -0
@@ -4,4 +4,7 @@
  #define __clk_get(clk) ({ 1; })
  #define __clk_put(clk) do { } while (0)
 
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char *src,
+							unsigned char divider);
+
  #endif
(quoted diff) +0 -0

b/arch/arm/mach-w90x900/include/mach/mfp.h
new file mode 100644
index 0000000..69a094a

arch/arm/mach-w90x900/include/mach/mfp.h new file +23 -0
@@ -0,0 +1,23 @@
+/*
+ * arch/arm/mach-w90x900/include/mach/mfp.h
+ *
+ * Copyright (c) 2008 Nuvoton technology corporation
+ * All rights reserved.
+ *
+ * Wan ZongShun <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ */
+#ifndef __ASM_ARM_MFP_H
+#define __ASM_ARM_MFP_H
+
+extern void mfp_set_groupf(struct device *dev);
+extern void mfp_set_groupc(struct device *dev);
+extern void mfp_set_groupi(struct device *dev);
+extern void mfp_set_groupg(struct device *dev);
+
+#endif /* __ASM_ARM_MFP_H */
Signature · 1 line
1.5.6.3
#3 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

In reply to Wan ZongShun
Quoted 18 lines · Wan ZongShun

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
arch/arm/mach-w90x900/include/mach/clkdev.h +0 -0
index 04b37a8..b35f4bc 100644

arch/arm/mach-w90x900/include/mach/clkdev.h line 10

Quoted 7 lines
arch/arm/mach-w90x900/include/mach/clkdev.h +3 -0
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)
 
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
 *src,
+							unsigned char divider);
+

hmm, why not have a 'struct clk' with a .set_rate method?

#4 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

In reply to Wan ZongShun
Quoted 18 lines · Wan ZongShun

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
arch/arm/mach-w90x900/include/mach/clkdev.h +0 -0
index 04b37a8..b35f4bc 100644

arch/arm/mach-w90x900/include/mach/clkdev.h line 10

Quoted 7 lines
arch/arm/mach-w90x900/include/mach/clkdev.h +3 -0
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)
 
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
 *src,
+							unsigned char divider);
+

I'd prefer it if this header didn't get used for non-clkdev<->plat code stuff.

#5 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

2010/1/5 Russell King - ARM Linux <[email protected]>

Quoted 23 lines · Wan ZongShun
Quoted 9 lines

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23

+++++++++++++++++++++++

Quoted 12 lines
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
arch/arm/mach-w90x900/include/mach/clkdev.h +0 -0
index 04b37a8..b35f4bc 100644
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)
Quoted 8 lines

arch/arm/mach-w90x900/include/mach/clkdev.h line 9

Quoted 3 lines
arch/arm/mach-w90x900/include/mach/clkdev.h +2 -0
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
 *src,
+                                                     unsigned char

divider);

arch/arm/mach-w90x900/include/mach/clkdev.h line 10

Quoted 1 line
arch/arm/mach-w90x900/include/mach/clkdev.h +1 -0
+

I'd prefer it if this header didn't get used for non-clkdev<->plat code stuff.

So, you mean I can use this header in the LCD driver of nuc900 plat?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100105/90efb3e7/attachment-0001.htm>

author
#6 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

2010/1/5 ?? <[email protected]>:

Quoted 36 lines

2010/1/5 Russell King - ARM Linux <[email protected]>

Quoted 24 lines · Wan ZongShun
Quoted 22 lines

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>

---
?arch/arm/mach-w90x900/include/mach/clkdev.h | ? ?3 +++ ?arch/arm/mach-w90x900/include/mach/mfp.h ? ?| ? 23
+++++++++++++++++++++++
?2 files changed, 26 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h

arch/arm/mach-w90x900/include/mach/clkdev.h +0 -0
index 04b37a8..b35f4bc 100644
@@ -4,4 +4,7 @@
 ?#define __clk_get(clk) ({ 1; })
 ?#define __clk_put(clk) do { } while (0)
Quoted 8 lines
Quoted 5 lines
arch/arm/mach-w90x900/include/mach/clkdev.h +2 -0
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned char
 *src,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? unsigned char

divider);
+

I'd prefer it if this header didn't get used for non-clkdev<->plat code stuff.

Quoted 2 lines

So, you mean I can use this header in the LCD driver of?nuc900 plat?

Hmmm, I don't think so.

I think it is better to implement other API as Ben Dooks mentioned, but if you want to use
this API provided by me, we have to add the extern to other header file rather than the specific clkdev header file.

So, please wait me for new patch.

Signature · 10 lines
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com
#7 lore raw

PATCH 1/1 NUC900: Add extern header file support for some driver

Quoted 41 lines · Wan ZongShun

2010/1/5 ?? <[email protected]>:

Quoted 27 lines

2010/1/5 Russell King - ARM Linux <[email protected]>

Quoted 24 lines · Wan ZongShun
Quoted 22 lines

Dear Wang Qiang,

This patch provides a API for your LCD driver or other drivers, if you want to use those APIs, please include corresponding header file.

Signed-off-by Wan ZongShun <[email protected]>
---
 arch/arm/mach-w90x900/include/mach/clkdev.h |    3 +++
 arch/arm/mach-w90x900/include/mach/mfp.h    |   23
+++++++++++++++++++++++
 2 files changed, 26 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-w90x900/include/mach/mfp.h
arch/arm/mach-w90x900/include/mach/clkdev.h +0 -0
index 04b37a8..b35f4bc 100644
@@ -4,4 +4,7 @@
 #define __clk_get(clk) ({ 1; })
 #define __clk_put(clk) do { } while (0)
Quoted 1 line
Quoted 1 line

arch/arm/mach-w90x900/include/mach/clkdev.h line 7

Quoted 1 line
arch/arm/mach-w90x900/include/mach/clkdev.h +1 -0
+extern void nuc900_driver_clksrc_div(struct device *dev, unsigned

char

Quoted 10 lines
Quoted 7 lines
Quoted 4 lines
arch/arm/mach-w90x900/include/mach/clkdev.h +1 -0
 *src,
+                                                     unsigned char

divider);
+

I'd prefer it if this header didn't get used for non-clkdev<->plat code stuff.

So, you mean I can use this header in the LCD driver of nuc900 plat?

Quoted 8 lines

Hmmm, I don't think so.

I think it is better to implement other API as Ben Dooks mentioned, but if you want to use
this API provided by me, we have to add the extern to other header file rather than the specific clkdev header file.

So, please wait me for new patch.

Ok, thank you.
I can not display the Linux Logo correctly.
I debug the kernel, it gave the wrong size of logo cols x rows = 40 x 15.
Any Idea?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100105/d911113b/attachment-0001.htm>