MMC: Atmel choice under Kconfig

Just a nitpicking comment. Currently even if one doesn't actually have an atmel chip, the menu will include an entry Atmel SD/MMC Driver due to the following bit of drivers/mmc/host/kconfig

choice
prompt "Atmel SD/MMC Driver"
default MMC_ATMELMCI if AVR32
help
Choose which driver to use for the Atmel MCI Silicon

config MMC_AT91
tristate "AT91 SD/MMC Card Interface support" depends on ARCH_AT91
help
This selects the AT91 MCI controller.

If unsure, say N.

config MMC_ATMELMCI
tristate "Atmel Multimedia Card Interface support" depends on AVR32 || ARCH_AT91
help
This selects the Atmel Multimedia Card Interface driver. If you have an AT32 (AVR32) or AT91 platform with a Multimedia Card slot, say Y or M here.

If unsure, say N.

endchoice

Does anyone object to making adding a dependency on AVR32 || ARCH_AT91 to the 'choice' entry so as to clean up what everyone else sees?

Sorry for the noise if there is already a patch for this queued up somewhere.

Thanks,

Jonathan Cameron

Le 04/01/2010 17:21, Jonathan Cameron :

Yes, sure go-on.

No patch queued for this if I recall well...

Thanks, best regards,

Nicolas Ferre

---

This prevents those without an Atmel chip having a line in menuconfig etc which says "Atmel SD/MMC Driver" without any options.

 drivers/mmc/host/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

index e04b751..17ef22f 100644
@@ -162,6 +162,7 @@ config MMC_AU1X
 
 choice
 	prompt "Atmel SD/MMC Driver"
+	depends on AVR32 || ARCH_AT91
 	default MMC_ATMELMCI if AVR32
 	help
 	  Choose which driver to use for the Atmel MCI Silicon

1.6.4.4