k10temp: make PCI device ids constant
Subsystems (2)
PATCH 3/5 k10temp: make PCI device ids constant
From: Márton Németh <[email protected]>
The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make pci_device_id also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by Márton Németh <[email protected]>
Cc Julia Lawall <[email protected]>
---
drivers/hwmon/k10temp.c 2010-01-03 20:55:44.000000000 +0100 renamed from drivers/hwmon/k10temp.c 2009-12-27 12:20:18.000000000 +0100 +1 -1
@@ -169,7 +169,7 @@ static void __devexit k10temp_remove(str dev_set_drvdata(&pdev->dev, NULL); } -static struct pci_device_id k10temp_id_table[] = { +static const struct pci_device_id k10temp_id_table[] = { { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_10H_NB_MISC) }, { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_11H_NB_MISC) }, {}
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors