arm: suen3, suen3_v1, mgcoge2_arm_p1a support

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

include/configs/km-arm.h new file +0 -0

Quoted 8 lines · In message <[email protected]> you wrote:

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

...

Quoted 2 lines

include/configs/km-arm.h new file +0 -0

...

include/configs/km-arm.h line 179

Quoted 2 lines

include/configs/km-arm.h new file +2 -0

+#if 1 // test-only cramfs ...
+#define CONFIG_SYS_MAX_FLASH_SECT	256

Please do not add dead code (the "#if 1" here), and do not use C++ comments (please fix this globally).

include/configs/km-arm.h line 188

Quoted 8 lines

include/configs/km-arm.h new file +8 -0

+#ifndef __ASSEMBLY__
+typedef struct {
+	unsigned long size;			/* total bank size in bytes		*/
+	unsigned short sector_count;		/* number of erase units		*/
+	unsigned long flash_id;			/* combined device & manufacturer code	*/
+	unsigned long start[CONFIG_SYS_MAX_FLASH_SECT];   /* virtual sector start address */
+	unsigned char protect[CONFIG_SYS_MAX_FLASH_SECT]; /* sector protection status	*/
+} flash_info_t;

Lines way too long. Please fix globally.

Umm.. why cannot you use the struct flash_info_t as declared in "include/flash.h" ??

Quoted 5 lines

include/configs/km-arm.h line 179

Quoted 2 lines

include/configs/km-arm.h new file +2 -0

+#if 1 // test-only cramfs ...
+#define CONFIG_SYS_MAX_FLASH_SECT	256

Please do not add dead code (the "#if 1" here), and do not use C++ comments (please fix this globally).

Ups, sorry.

Quoted 3 lines

include/configs/km-arm.h

Quoted 3 lines

include/configs/km-arm.h new file +3 -0

+#ifndef __ASSEMBLY__
+typedef struct {
+	unsigned long size;			/* total bank size in bytes		

Quoted 1 line

Review

Quoted 1 line

(quoted diff) +1 -0

+	unsigned short sector_count;		/* number of erase units		

Quoted 1 line

Review

Quoted 1 line

(quoted diff) +1 -0

+	unsigned long flash_id;			/* combined device & manufacturer 

Quoted 8 lines

Quoted 3 lines

(quoted diff) +1 -0

+	unsigned long start[CONFIG_SYS_MAX_FLASH_SECT];   /* virtual sector

start address */ + unsigned char protect[CONFIG_SYS_MAX_FLASH_SECT]; /*
sector protection status */ +} flash_info_t;

Lines way too long. Please fix globally.

Umm.. why cannot you use the struct flash_info_t as declared in "include/flash.h" ??

Hmm.. I take a look at this point... Stefan? Maybe, you can help here, because this comes from your original port, I think.

Quoted 8 lines · In message <[email protected]> you wrote:

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

...

Quoted 2 lines

include/configs/km-arm.h new file +0 -0

...

include/configs/km-arm.h line 179

Quoted 2 lines

include/configs/km-arm.h new file +2 -0

+#if 1 // test-only cramfs ...
+#define CONFIG_SYS_MAX_FLASH_SECT	256

Please do not add dead code (the "#if 1" here), and do not use C++ comments (please fix this globally).

include/configs/km-arm.h line 188

Quoted 8 lines

include/configs/km-arm.h new file +8 -0

+#ifndef __ASSEMBLY__
+typedef struct {
+	unsigned long size;			/* total bank size in bytes		*/
+	unsigned short sector_count;		/* number of erase units		*/
+	unsigned long flash_id;			/* combined device & manufacturer code	*/
+	unsigned long start[CONFIG_SYS_MAX_FLASH_SECT];   /* virtual sector start address */
+	unsigned char protect[CONFIG_SYS_MAX_FLASH_SECT]; /* sector protection status	*/
+} flash_info_t;

Lines way too long. Please fix globally.

Umm.. why cannot you use the struct flash_info_t as declared in "include/flash.h" ??

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

Quoted 4 lines · Heiko Schocher

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

Quoted 5 lines

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

It seems like these are 2 different board.
If they are, please split this patch.

[PATCH 1/2] cramfs: make cramfs usable without a NOR flash

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

board/keymile/km_arm/km_arm.c new file +4 -0

+#if defined(CONFIG_CMD_SF)
+int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	u32 tmp;

board/keymile/km_arm/km_arm.c new file +4 -0

+	if ((strcmp(argv[1], "off") == 0)) {
+		printf("SPI FLASH disabled, NAND enabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_NF_IO2;

board/keymile/km_arm/km_arm.c new file +6 -0

+
+ulong bootcount_load (void)
+{
+	volatile ulong *save_addr;
+	volatile ulong size = 0;
+	int i;

Quoted 1 line · In message <[email protected]> you wrote:

[PATCH 1/2] cramfs: make cramfs usable without a NOR flash

I'm afraid I still don't understand how this is supposed to work.

Where would you store the cramfs on a system "without a NOR flash"? Are we talking about - say - a NAND storage device then?

Quoted 4 lines

common/cmd_cramfs.c +0 -0

@@ -119,7 +121,11 @@ int do_cramfs_load(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 	dev.id = &id;
 	part.dev = &dev;
 	/* fake the address offset */

common/cmd_cramfs.c int do_cramfs_load(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) · line 128

Quoted 5 lines

common/cmd_cramfs.c +4 -0

+#if !defined(CONFIG_SYS_NO_FLASH)
 	part.offset = addr - flash_info[id.num].start[0];
+#else
+	part.offset = addr;
+#endif

I understand that we now can have the cramfs image either in NOR flash _or_ in NAND.

What about systems that have both NOR _and_ NAND?

The cramfs image is located in RAM (where it first was copied from whenever), and then files are read from it with the "cramfsload" command ...

Quoted 5 lines

Quoted 5 lines

common/cmd_cramfs.c +4 -0

+#if !defined(CONFIG_SYS_NO_FLASH)
 	part.offset = addr - flash_info[id.num].start[0];
+#else
+	part.offset = addr;
+#endif

No, we can have it in ROM or in RAM.

Quoted 1 line

What about systems that have both NOR _and_ NAND?

Are there such systems, with cramfs support? Actual cramfs support in mainline is only for NOR devices ...

In message <[email protected]> you wrote:

Quoted 3 lines

Quoted 1 line

What about systems that have both NOR _and_ NAND?

Are there such systems, with cramfs support? Actual cramfs support in mainline is only for NOR devices ...

Yes, but I understand that you want to also support cramfs when not stored in NOR.

With your code I can read files from a cramfs image stored in RAM (when there is nor NOR flash), _or_ I can read it from NOR flash. Right?

But what about reading from files a cramfs image stored in RAM on a system that _has_ NOR flash? And being able to read files a cramfs image stored in NOR as well? It seems your code cannot do this.

I understand that the suggested patch is an improvement over the existing state (it adds the capability to read cramfs in RAM on NOR-les systems), but I think this restriction ("on NOR-less systems") should be lifted as well.

In other words: I think, the decision whether to use

	part.offset = addr - flash_info[id.num].start[0];
or
	part.offset = addr;

should be made at run time (based on the location of the image - in

Hello Tom,

Quoted 10 lines · Tom

Quoted 9 lines · Heiko Schocher

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

Quoted 2 lines

It seems like these are 2 different board.
If they are, please split this patch.

No, the mgcoge2_arm_p1a was just the first version of this Hardware, and the second and subsequent versions are renamed in suen3_x ...

bye
Heiko

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, February 01, 2010 1:07 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

Signed-off-by Holger Brunck <[email protected]>

Signed-off-by Stefan Roese <[email protected]>

Signed-off-by Heiko Schocher <[email protected]>

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)
- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

 MAINTAINERS                           |    2 +
 MAKEALL                               |    4 +
 Makefile                              |    8 +
 board/keymile/common/common.c         |   23 ++-
 board/keymile/km_arm/Makefile         |   51 +++++
 board/keymile/km_arm/config.mk        |   25 +++
 board/keymile/km_arm/km_arm.c         |  343 
+++++++++++++++++++++++++++++++++
 board/keymile/km_arm/sdramregs.txt    |   31 +++
 board/keymile/km_arm/sdramregs_v1.txt |   28 +++
 include/configs/km-arm.h              |  189 ++++++++++++++++++

 include/configs/mgcoge2_arm_p1a.h     |   96 +++++++++
 include/configs/suen3.h               |  103 ++++++++++
 include/configs/suen3_p1a.h           |   82 ++++++++
 include/configs/suen3_p1b_p1c.h       |  110 +++++++++++

board/keymile/common/common.c +16 -3

index ec27bda..33857c7 100644
@@ -35,6 +35,7 @@
 #include <libfdt.h>
 #endif
 
+#include "../common/common.h"
 #if defined(CONFIG_HARD_I2C) || defined(CONFIG_SOFT_I2C)
 #include <i2c.h>
 

@@ -395,7 +396,12 @@ static void setports (int gpio)
 #endif
 #endif
 
-#if defined(CONFIG_KM8XX)
+#if (defined(CONFIG_MACH_SUEN3) && defined(CONFIG_HARD_I2C))
+#error I2C bus resetsequence not implemented yet.
+#endif
+
+#if defined(CONFIG_KM8XX) || \
+	(defined(CONFIG_MACH_SUEN3) && defined(CONFIG_SOFT_I2C))
 static void set_sda (int state)
 {
 	I2C_SDA(state);

@@ -411,6 +417,12 @@ static int get_sda (void)
 	return I2C_READ;
 }
 
+#if defined(CONFIG_MACH_SUEN3)
+static int get_scl (void)
+{
+	return (kw_gpio_get_value(SUEN3_SCL_PIN) ? 1 : 0);
+}
+#else
 static int get_scl (void)
 {
 	int	val;

@@ -421,10 +433,11 @@ static int get_scl (void)
 
 	return ((val & SCL_BIT) == SCL_BIT);
 }
+#endif
 
 #endif
 
-#if !defined(CONFIG_KMETER1)
+#if !defined(CONFIG_KMETER1) && !defined(CONFIG_SUVD3)
 static void writeStartSeq (void)
 {
 	set_sda (1);

@@ -483,7 +496,7 @@ static int i2c_make_abort (void)
  */
 void i2c_init_board(void)
 {
-#if defined(CONFIG_KMETER1)
+#if defined(CONFIG_KMETER1) || defined(CONFIG_SUVD3)
 	struct fsl_i2c *dev;
 	dev = (struct fsl_i2c *) (CONFIG_SYS_IMMR + 
 CONFIG_SYS_I2C_OFFSET);

board/keymile/common/common.c +1 -1

 	uchar	dummy;

@@ -500,7 +513,7 @@ void i2c_init_board(void)
 	out_8 (&dev->cr, (I2C_CR_MEN));
 
 #else
-#if defined(CONFIG_HARD_I2C)
+#if defined(CONFIG_HARD_I2C) && !defined(CONFIG_MACH_SUEN3)
 	volatile immap_t *immap = (immap_t *)CONFIG_SYS_IMMR ;
 	volatile i2c8260_t *i2c	= (i2c8260_t *)&immap->im_i2c;
 

@@ -578,10 +591,12 @@ int fdt_get_node_and_value (void *blob,
 }

board/keymile/common/common.c +0 -0

 int board_eth_init (bd_t *bis)

{

board/keymile/km_arm/km_arm.c new file +26 -0

new file mode 100644
index 0000000..0edf3b2
@@ -0,0 +1,343 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * (C) Copyright 2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */

board/keymile/km_arm/km_arm.c new file +44 -0

+
+	/*
+	 * arch number of board
+	 */
+	gd->bd->bi_arch_number = MACH_TYPE_SUEN3;
+
+	/* address of boot parameters */
+	gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
+
+#if defined(CONFIG_KIRKWOOD_GPIO)
+	/* init the GPIO for I2C Bitbang driver */
+	kw_gpio_set_valid(SUEN3_SDA_PIN, 1);
+	kw_gpio_set_valid(SUEN3_SCL_PIN, 1);
+	kw_gpio_direction_output(SUEN3_SDA_PIN, 0);
+	kw_gpio_direction_output(SUEN3_SCL_PIN, 0);
+#endif
+	return 0;
+}
+
+#if defined(CONFIG_CMD_SF)
+int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	u32 tmp;
+	if (argc < 2) {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+
+	if ((strcmp(argv[1], "off") == 0)) {
+		printf("SPI FLASH disabled, NAND enabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_NF_IO2;
+		kwmpp_config[1] = MPP1_NF_IO3;
+		kwmpp_config[2] = MPP2_NF_IO4;
+		kwmpp_config[3] = MPP3_NF_IO5;
+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
+
+		nand_init();
+	} else if ((strcmp(argv[1], "on") == 0)) {
+		printf("SPI FLASH enabled, NAND disabled\n");
+		/* Multi-Purpose Pins Functionality configuration */

board/keymile/km_arm/km_arm.c new file +22 -0

+	} else {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+
+	return 0;
+}
+
+U_BOOT_CMD(
+	spitoggle,	2,	0,	do_spi_toggle,
+	"En-/disable SPI FLASH access",
+	"<on|off> - Enable (on) or disable (off) SPI FLASH access\n"
+	);
+#endif
+
+int dram_init(void)
+{
+	int i;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		gd->bd->bi_dram[i].start = kw_sdram_bar(i);
+		gd->bd->bi_dram[i].size = get_ram_size((long 

*)kw_sdram_bar(i),

board/keymile/km_arm/km_arm.c new file +51 -0

+						       kw_sdram_bs(i));
+	}
+	return 0;
+}
+
+/* Configure and enable MV88E1118 PHY */
+void reset_phy(void)
+{
+	char *name = "egiga0";
+
+	if (miiphy_set_current_dev(name))
+		return;
+
+	/* reset the phy */
+	miiphy_reset(name, CONFIG_PHY_BASE_ADR);
+}
+
+#if defined(CONFIG_HUSH_INIT_VAR)
+int hush_init_var (void)
+{
+	ivm_read_eeprom ();
+	return 0;
+}
+#endif
+
+#if defined(CONFIG_BOOTCOUNT_LIMIT)
+void bootcount_store (ulong a)
+{
+	volatile ulong *save_addr;
+	volatile ulong size = 0;
+	int i;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		size += gd->bd->bi_dram[i].size;
+	}
+	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	writel(a, save_addr);
+	writel(BOOTCOUNT_MAGIC, &save_addr[1]);
+}
+
+ulong bootcount_load (void)
+{
+	volatile ulong *save_addr;
+	volatile ulong size = 0;
+	int i;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		size += gd->bd->bi_dram[i].size;
+	}
+	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	if (readl(&save_addr[1]) != BOOTCOUNT_MAGIC)
+		return 0;
+	else

+int eeprom_reg_value (unsigned dev_addr, uchar reg, uchar reg_mask, int value)

board/keymile/km_arm/km_arm.c new file +3 -0

+{
+	uchar buf;
+	if (i2c_read (dev_addr, reg, 1, &buf, 1) != 0)

board/keymile/km_arm/sdramregs.txt new file +5 -0

+0xFFD10000 0x01112222
+0xFFD10008 0x00001100
+0xFFD100E0 0x1B1B1B1B
+0xFFD20134 0xFFFFFFFF
+0xFFD20138 0x009FFFFF

board/keymile/km_arm/sdramregs_v1.txt new file +2 -0

+0xFFD10000 0x01111111
+0xFFD10008 0x00001100

+0x0 0x0

include/configs/suen3_p1b_p1c.h new file +27 -0

new file mode 100644
index 0000000..cd8bf01
@@ -0,0 +1,110 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * (C) Copyright 2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+

Review

Quoted 2 lines

(quoted diff) +2 -0

+/* include common defines/options for all arm based Keymile boards */
+#include "km-arm.h"

Further includes are not allowed in board config header. May be Wolfgang can comment on this..

First of all sorry for delayed feedback

Quoted 29 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, February 01, 2010 1:07 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

Signed-off-by Holger Brunck <[email protected]>

Signed-off-by Stefan Roese <[email protected]>

Signed-off-by Heiko Schocher <[email protected]>

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)
- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

Quoted 11 lines

 MAINTAINERS                           |    2 +
 MAKEALL                               |    4 +
 Makefile                              |    8 +
 board/keymile/common/common.c         |   23 ++-
 board/keymile/km_arm/Makefile         |   51 +++++
 board/keymile/km_arm/config.mk        |   25 +++
 board/keymile/km_arm/km_arm.c         |  343 
+++++++++++++++++++++++++++++++++
 board/keymile/km_arm/sdramregs.txt    |   31 +++
 board/keymile/km_arm/sdramregs_v1.txt |   28 +++
 include/configs/km-arm.h              |  189 ++++++++++++++++++

The associated board name and c file is named as kw_arm, pls sync on this This file name should be km_arm.h

Quoted 4 lines

 include/configs/mgcoge2_arm_p1a.h     |   96 +++++++++
 include/configs/suen3.h               |  103 ++++++++++
 include/configs/suen3_p1a.h           |   82 ++++++++
 include/configs/suen3_p1b_p1c.h       |  110 +++++++++++

...snip...

the include/config files indicates that there are five board supports. Please provide one patch for each board, may be first will be master one.

...snip...

Quoted 76 lines

board/keymile/common/common.c +16 -3

index ec27bda..33857c7 100644
@@ -35,6 +35,7 @@
 #include <libfdt.h>
 #endif
 
+#include "../common/common.h"
 #if defined(CONFIG_HARD_I2C) || defined(CONFIG_SOFT_I2C)
 #include <i2c.h>
 

@@ -395,7 +396,12 @@ static void setports (int gpio)
 #endif
 #endif
 
-#if defined(CONFIG_KM8XX)
+#if (defined(CONFIG_MACH_SUEN3) && defined(CONFIG_HARD_I2C))
+#error I2C bus resetsequence not implemented yet.
+#endif
+
+#if defined(CONFIG_KM8XX) || \
+	(defined(CONFIG_MACH_SUEN3) && defined(CONFIG_SOFT_I2C))
 static void set_sda (int state)
 {
 	I2C_SDA(state);

@@ -411,6 +417,12 @@ static int get_sda (void)
 	return I2C_READ;
 }
 
+#if defined(CONFIG_MACH_SUEN3)
+static int get_scl (void)
+{
+	return (kw_gpio_get_value(SUEN3_SCL_PIN) ? 1 : 0);
+}
+#else
 static int get_scl (void)
 {
 	int	val;

@@ -421,10 +433,11 @@ static int get_scl (void)
 
 	return ((val & SCL_BIT) == SCL_BIT);
 }
+#endif
 
 #endif
 
-#if !defined(CONFIG_KMETER1)
+#if !defined(CONFIG_KMETER1) && !defined(CONFIG_SUVD3)
 static void writeStartSeq (void)
 {
 	set_sda (1);

@@ -483,7 +496,7 @@ static int i2c_make_abort (void)
  */
 void i2c_init_board(void)
 {
-#if defined(CONFIG_KMETER1)
+#if defined(CONFIG_KMETER1) || defined(CONFIG_SUVD3)
 	struct fsl_i2c *dev;
 	dev = (struct fsl_i2c *) (CONFIG_SYS_IMMR + 
 CONFIG_SYS_I2C_OFFSET);

board/keymile/common/common.c +1 -1

 	uchar	dummy;

@@ -500,7 +513,7 @@ void i2c_init_board(void)
 	out_8 (&dev->cr, (I2C_CR_MEN));
 
 #else
-#if defined(CONFIG_HARD_I2C)
+#if defined(CONFIG_HARD_I2C) && !defined(CONFIG_MACH_SUEN3)
 	volatile immap_t *immap = (immap_t *)CONFIG_SYS_IMMR ;
 	volatile i2c8260_t *i2c	= (i2c8260_t *)&immap->im_i2c;
 

@@ -578,10 +591,12 @@ int fdt_get_node_and_value (void *blob,
 }
 #endif
 

board/keymile/common/common.c int fdt_get_node_and_value (void *blob, · line 600

Quoted 8 lines

board/keymile/common/common.c +2 -0

+#if !defined(CONFIG_MACH_SUEN3)
 int ethernet_present (void)
 {
 	return (in_8((u8 *)CONFIG_SYS_PIGGY_BASE + 
 CONFIG_SYS_SLOT_ID_OFF) & 0x80);
 }
+#endif
 

In general common file should have code common to all, but the patch for this file looks like the code is ifdefed for specific boards. You can keep such code in km_arm.c

Quoted 35 lines

board/keymile/common/common.c +0 -0

 int board_eth_init (bd_t *bis)

{

board/keymile/km_arm/km_arm.c new file +26 -0

new file mode 100644
index 0000000..0edf3b2
@@ -0,0 +1,343 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * (C) Copyright 2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */

...snip...

board/keymile/km_arm/km_arm.c line 154

Quoted 8 lines

board/keymile/km_arm/km_arm.c new file +8 -0

+
+	str = getenv("mach_type");
+	if (str != NULL) {
+		mach_type = simple_strtoul(str, NULL, 10);
+		printf("Overwriting MACH_TYPE with %d!!!\n", mach_type);
+		gd->bd->bi_arch_number = mach_type;
+	}
+	return 0;

Pls avoid this, the machine types should be predefined and registered first for the board support that you are adding. Why do you need this in environment?.

Quoted 7 lines

board/keymile/km_arm/km_arm.c new file +7 -0

+}
+
+int board_init(void)
+{
+	u32 tmp;
+
+	kirkwood_mpp_conf(kwmpp_config);

board/keymile/km_arm/km_arm.c line 167

Quoted 6 lines

board/keymile/km_arm/km_arm.c new file +6 -0

+
+	tmp = readl(KW_GPIO0_BASE);
+	writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
+	tmp = readl(KW_GPIO0_BASE + 4);
+	writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE + 4);
+	printf("KM: setting NAND mode\n");

Any explaination about what you are doing above? Any comments will help.

Quoted 48 lines

board/keymile/km_arm/km_arm.c new file +48 -0

+
+	/*
+	 * arch number of board
+	 */
+	gd->bd->bi_arch_number = MACH_TYPE_SUEN3;
+
+	/* address of boot parameters */
+	gd->bd->bi_boot_params = kw_sdram_bar(0) + 0x100;
+
+#if defined(CONFIG_KIRKWOOD_GPIO)
+	/* init the GPIO for I2C Bitbang driver */
+	kw_gpio_set_valid(SUEN3_SDA_PIN, 1);
+	kw_gpio_set_valid(SUEN3_SCL_PIN, 1);
+	kw_gpio_direction_output(SUEN3_SDA_PIN, 0);
+	kw_gpio_direction_output(SUEN3_SCL_PIN, 0);
+#endif
+	return 0;
+}
+
+#if defined(CONFIG_CMD_SF)
+int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
+{
+	u32 tmp;
+	if (argc < 2) {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+
+	if ((strcmp(argv[1], "off") == 0)) {
+		printf("SPI FLASH disabled, NAND enabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_NF_IO2;
+		kwmpp_config[1] = MPP1_NF_IO3;
+		kwmpp_config[2] = MPP2_NF_IO4;
+		kwmpp_config[3] = MPP3_NF_IO5;
+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
+
+		nand_init();
+	} else if ((strcmp(argv[1], "on") == 0)) {
+		printf("SPI FLASH enabled, NAND disabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_SPI_SCn;
+		kwmpp_config[1] = MPP1_SPI_MOSI;
+		kwmpp_config[2] = MPP2_SPI_SCK;
+		kwmpp_config[3] = MPP3_SPI_MISO;

board/keymile/km_arm/km_arm.c line 221

Quoted 6 lines

board/keymile/km_arm/km_arm.c new file +6 -0

+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE);
+
+		nand_init();

What do you need nand_init for disabled nand operation?

Quoted 78 lines

board/keymile/km_arm/km_arm.c new file +22 -0

+	} else {
+		cmd_usage(cmdtp);
+		return 1;
+	}
+
+	return 0;
+}
+
+U_BOOT_CMD(
+	spitoggle,	2,	0,	do_spi_toggle,
+	"En-/disable SPI FLASH access",
+	"<on|off> - Enable (on) or disable (off) SPI FLASH access\n"
+	);
+#endif
+
+int dram_init(void)
+{
+	int i;
+
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		gd->bd->bi_dram[i].start = kw_sdram_bar(i);
+		gd->bd->bi_dram[i].size = get_ram_size((long 

*)kw_sdram_bar(i),

board/keymile/km_arm/km_arm.c new file +55 -0

+						       kw_sdram_bs(i));
+	}
+	return 0;
+}
+
+/* Configure and enable MV88E1118 PHY */
+void reset_phy(void)
+{
+	char *name = "egiga0";
+
+	if (miiphy_set_current_dev(name))
+		return;
+
+	/* reset the phy */
+	miiphy_reset(name, CONFIG_PHY_BASE_ADR);
+}
+
+#if defined(CONFIG_HUSH_INIT_VAR)
+int hush_init_var (void)
+{
+	ivm_read_eeprom ();
+	return 0;
+}
+#endif
+
+#if defined(CONFIG_BOOTCOUNT_LIMIT)
+void bootcount_store (ulong a)
+{
+	volatile ulong *save_addr;
+	volatile ulong size = 0;
+	int i;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		size += gd->bd->bi_dram[i].size;
+	}
+	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	writel(a, save_addr);
+	writel(BOOTCOUNT_MAGIC, &save_addr[1]);
+}
+
+ulong bootcount_load (void)
+{
+	volatile ulong *save_addr;
+	volatile ulong size = 0;
+	int i;
+	for (i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
+		size += gd->bd->bi_dram[i].size;
+	}
+	save_addr = (ulong*)(size - BOOTCOUNT_ADDR);
+	if (readl(&save_addr[1]) != BOOTCOUNT_MAGIC)
+		return 0;
+	else
+		return readl(save_addr);
+}
+#endif
+

board/keymile/km_arm/km_arm.c line 304

Quoted 6 lines

board/keymile/km_arm/km_arm.c new file +6 -0

+#if defined(CONFIG_SYS_EEPROM_WREN)
+#define BOCOADDR	0x10
+#define DIRECT		0x04
+#define DIRECTMASK	0x04
+#define GPRT		0x08
+#define GPRTMASK	0x04

Better if you provide defination on the top or in header file

Quoted 10 lines

+int eeprom_reg_value (unsigned dev_addr, uchar reg, uchar reg_mask, int value)

board/keymile/km_arm/km_arm.c new file +8 -0

+{
+	uchar buf;
+	if (i2c_read (dev_addr, reg, 1, &buf, 1) != 0)
+		return 1;
+	if (value)
+		buf |= reg_mask;
+	else
+		buf &= ~reg_mask;

board/keymile/km_arm/km_arm.c line 318

Quoted 5 lines

board/keymile/km_arm/km_arm.c new file +5 -0

+	if (i2c_write (dev_addr, reg, 1, &buf, 1) != 0)
+		return 1;
+	return 0;
+}
+

It would be nice if you can abstract eeprom related code to separate driver or use existing eeprom driver Any way keep it out side of board files, that can be shared by others too

Quoted 30 lines

board/keymile/km_arm/km_arm.c new file +14 -0

+int eeprom_write_enable (unsigned dev_addr, int state)
+{
+	uchar direction = state;
+	uchar gpio_value = !state;
+	uchar addr = BOCOADDR;
+	uchar direct = DIRECT;
+	uchar direct_mask = DIRECTMASK;
+	uchar gprt = GPRT;
+	uchar gprt_mask = GPRTMASK;
+
+	/* state 0: transition from write enabled to write disable */
+	/* state 1: transition from write disabled to write enable */
+
+	if (!state && eeprom_reg_value (addr, gprt, gprt_mask, 

gpio_value))

board/keymile/km_arm/km_arm.c new file +6 -0

+		return 1;
+
+	if (eeprom_reg_value (addr, direct, direct_mask, direction))
+		return 1;
+
+	if (state && eeprom_reg_value (addr, gprt, gprt_mask, 

gpio_value))

board/keymile/km_arm/km_arm.c new file +5 -0

+		return 1;
+
+	return 0;
+}
+#endif

board/keymile/km_arm/sdramregs.txt new file +0 -0

new file mode 100644

board/keymile/km_arm/sdramregs.txt

Quoted 4 lines

index 0000000..68c53a7

board/keymile/km_arm/sdramregs.txt new file +0 -0

@@ -0,0 +1,31 @@

What is this file?
Which license?
Who is using it?

Quoted 5 lines

board/keymile/km_arm/sdramregs.txt new file +5 -0

+0xFFD10000 0x01112222
+0xFFD10008 0x00001100
+0xFFD100E0 0x1B1B1B1B
+0xFFD20134 0xFFFFFFFF
+0xFFD20138 0x009FFFFF

...snip..

board/keymile/km_arm/sdramregs_v1.txt

Quoted 9 lines

+0x0 0x0

board/keymile/km_arm/sdramregs.txt new file +1 -0

+

board/keymile/km_arm/sdramregs_v1.txt new file +0 -0

new file mode 100644
index 0000000..6778a9b
@@ -0,0 +1,28 @@

Ditto...

Quoted 2 lines

board/keymile/km_arm/sdramregs_v1.txt new file +2 -0

+0xFFD10000 0x01111111
+0xFFD10008 0x00001100

..snip...

Quoted 1 line

+0x0 0x0

...snip...

Quoted 39 lines

include/configs/suen3_p1b_p1c.h new file +32 -0

new file mode 100644
index 0000000..cd8bf01
@@ -0,0 +1,110 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Prafulla Wadaskar <[email protected]>
+ *
+ * (C) Copyright 2009
+ * Stefan Roese, DENX Software Engineering, sr at denx.de.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+/*
+ * for linking errors see
+ * http://lists.denx.de/pipermail/u-boot/2009-July/057350.html
+ */
+

include/configs/suen3_p1b_p1c.h line 37

Quoted 5 lines

include/configs/suen3_p1b_p1c.h new file +5 -0

+#ifndef _CONFIG_SUEN3_H
+#define _CONFIG_SUEN3_H
+
+/* include common defines/options for all arm based Keymile boards */
+#include "km-arm.h"

Further includes are not allowed in board config header. May be Wolfgang can comment on this..

Quoted 4 lines

Quoted 4 lines

board/keymile/km_arm/km_arm.c new file +4 -0

+
+	str = getenv("mach_type");
+	if (str != NULL) {
+		mach_type = simple_strtoul(str, NULL, 10);

Quoted 8 lines

board/keymile/km_arm/km_arm.c line 154

Quoted 4 lines

board/keymile/km_arm/km_arm.c new file +4 -0

+		printf("Overwriting MACH_TYPE with %d!!!\n", mach_type);
+		gd->bd->bi_arch_number = mach_type;
+	}
+	return 0;

Pls avoid this, the machine types should be predefined and registered first for the board support that you are adding. Why do you need this in environment?.

Stefan, can you answer this?

Quoted 20 lines

Quoted 20 lines

board/keymile/km_arm/km_arm.c new file +20 -0

+	if ((strcmp(argv[1], "off") == 0)) {
+		printf("SPI FLASH disabled, NAND enabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_NF_IO2;
+		kwmpp_config[1] = MPP1_NF_IO3;
+		kwmpp_config[2] = MPP2_NF_IO4;
+		kwmpp_config[3] = MPP3_NF_IO5;
+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
+
+		nand_init();
+	} else if ((strcmp(argv[1], "on") == 0)) {
+		printf("SPI FLASH enabled, NAND disabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_SPI_SCn;
+		kwmpp_config[1] = MPP1_SPI_MOSI;
+		kwmpp_config[2] = MPP2_SPI_SCK;
+		kwmpp_config[3] = MPP3_SPI_MISO;

Quoted 8 lines

board/keymile/km_arm/km_arm.c line 221

Quoted 6 lines

board/keymile/km_arm/km_arm.c new file +6 -0

+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE);
+
+		nand_init();

What do you need nand_init for disabled nand operation?

With it, the nand subsystem knows, that there is no longer the nand availiable.

Quoted 27 lines · Heiko Schocher

Quoted 27 lines

Quoted 16 lines

board/keymile/km_arm/km_arm.c new file +16 -0

+	if ((strcmp(argv[1], "off") == 0)) {
+		printf("SPI FLASH disabled, NAND enabled\n");
+		/* Multi-Purpose Pins Functionality configuration */
+		kwmpp_config[0] = MPP0_NF_IO2;
+		kwmpp_config[1] = MPP1_NF_IO3;
+		kwmpp_config[2] = MPP2_NF_IO4;
+		kwmpp_config[3] = MPP3_NF_IO5;
+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
+
+		nand_init();
+	} else if ((strcmp(argv[1], "on") == 0)) {
+		printf("SPI FLASH enabled, NAND disabled\n");
+		/* Multi-Purpose Pins Functionality configuration */

board/keymile/km_arm/km_arm.c line 221

Quoted 10 lines

board/keymile/km_arm/km_arm.c new file +10 -0

+		kwmpp_config[0] = MPP0_SPI_SCn;
+		kwmpp_config[1] = MPP1_SPI_MOSI;
+		kwmpp_config[2] = MPP2_SPI_SCK;
+		kwmpp_config[3] = MPP3_SPI_MISO;
+
+		kirkwood_mpp_conf(kwmpp_config);
+		tmp = readl(KW_GPIO0_BASE);
+		writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE);
+
+		nand_init();

What do you need nand_init for disabled nand operation?

Quoted 2 lines

With it, the nand subsystem knows, that there is no longer the nand availiable.

That's not how nand_init() is meant to be used. It is meant to be called once on system init. There is probably at least a memory leak here, e.g. chip->buffers.

Even as a hack, it looks like these boards use the kirkwood nand controller, and its board_nand_init() will unconditionally return 0, telling

nand_init_chip that it does indeed have NAND available. Or is there a patch somewhere changing that?

Quoted 3 lines · Scott Wood

That's not how nand_init() is meant to be used. It is meant to be called once on system init. There is probably at least a memory leak here, e.g. chip->buffers.

Oh, Ok. How could/should this then be solved?

(Some weak function, maybe: int nand_available(void)?, that board specific
code can overwrite, and this function is checked before a nand command is executed?)

In the First step, I don;t call nand_init() again, there is also a
warning message, that NAND is disabled, so the user should know, that he don;t have longer access to it, is this Okay for you?

Quoted 2 lines

Even as a hack, it looks like these boards use the kirkwood nand controller, and its board_nand_init() will unconditionally return 0, telling

Yep, but ...

Quoted 2 lines

nand_init_chip that it does indeed have NAND available. Or is there a patch somewhere changing that?

... nand_get_flash_type() returns -ENODEV, if no manufacturer or/and id could be read from nand (And if using this u-boot command, the nand is not longer visible, because the nand is disabled, and the pins are used to access a SPI Flash) -> nand_scan_ident returns this error, and so nand_scan ...

Quoted 40 lines · Prafulla Wadaskar

Quoted 40 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, February 01, 2010 1:07 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

This patch adds support for the Keymile SUEN3 board variants which are based on the Marvell Kirkwood (88F6281) SoC. All variants uses common code stored in board/keymile/km_arm/km_arm.c

mgcoge2_arm_p1a board:
This adds support for the ARM part of the mgcoge2. The suen3 target was moved to the correct suen3 p1b version. There is a difference between the GPIO configuration between suen3 and mgcoge2.

Signed-off-by Holger Brunck <[email protected]>

Signed-off-by Stefan Roese <[email protected]>

Signed-off-by Heiko Schocher <[email protected]>

---
- changes since v1:
added comments from Wolfgang Denk:
get rid of flash_info_t define in board config (to get this working patch 1/2 is introduced/needed)
- changes since v2:
added comments from Wolfgang Denk
- rearranged if/else in do_spi_toggle()
- added I/O accessor functions for bootcounter

 MAINTAINERS                           |    2 +
 MAKEALL                               |    4 +
 Makefile                              |    8 +
 board/keymile/common/common.c         |   23 ++-
 board/keymile/km_arm/Makefile         |   51 +++++
 board/keymile/km_arm/config.mk        |   25 +++
 board/keymile/km_arm/km_arm.c         |  343 
+++++++++++++++++++++++++++++++++
 board/keymile/km_arm/sdramregs.txt    |   31 +++
 board/keymile/km_arm/sdramregs_v1.txt |   28 +++
 include/configs/km-arm.h              |  189 ++++++++++++++++++

Quoted 6 lines

Quoted 4 lines

 include/configs/mgcoge2_arm_p1a.h     |   96 +++++++++
 include/configs/suen3.h               |  103 ++++++++++
 include/configs/suen3_p1a.h           |   82 ++++++++
 include/configs/suen3_p1b_p1c.h       |  110 +++++++++++

...snip...

Quoted 2 lines

the include/config files indicates that there are five board supports. Please provide one patch for each board, may be first will be master one.

This question also asked Tom, see:

http://lists.denx.de/pipermail/u-boot/2010-January/067182.html

But if you prefer to split this in 5 patches, I can do it.

Quoted 10 lines

board/keymile/km_arm/sdramregs.txt

Quoted 7 lines

board/keymile/km_arm/sdramregs.txt new file +0 -0

new file mode 100644
index 0000000..68c53a7
@@ -0,0 +1,31 @@

What is this file?
Which license?
Who is using it?

Ok, you are right, some comments are here necessary.

On this boards is a preloader, which initializes the RAM. Therefore the preloader reads the RAM settings from the image he should load, through an header. This header is created with a tool doimage (I think it is from marvell), and this tool needs this file ...

So, I have no idea where to put this files, and think they are in the board directory on the right place ...

I found something similiar in current mainline:

board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt

This file is also without comments, license info ... Maybe this tool don;t accept comments?

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Wednesday, February 10, 2010 12:39 PM
To: Prafulla Wadaskar
Cc: U-Boot user list
Subject: Re: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

Hello Prafulla,

do you have some comments on the following 2 points? (If they are clarified, I can post v4 of the patch ...)

Quoted 7 lines · Heiko Schocher

Quoted 6 lines · Prafulla Wadaskar

Quoted 6 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, February 01, 2010 1:07 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1,

mgcoge2_arm_p1a support

Quoted 1 line

Quoted 1 line

the include/config files indicates that there are five

board supports.

Quoted 1 line

Quoted 1 line

Please provide one patch for each board, may be first will

be master one.

Quoted 1 line

Quoted 5 lines

This question also asked Tom, see:

http://lists.denx.de/pipermail/u-boot/2010-January/067182.html

But if you prefer to split this in 5 patches, I can do it.

Is it OK in one patch, or should I split it in 4 patches?

[...]

Quoted 11 lines

Quoted 10 lines

board/keymile/km_arm/sdramregs.txt

Quoted 7 lines

board/keymile/km_arm/sdramregs.txt new file +0 -0

new file mode 100644
index 0000000..68c53a7
@@ -0,0 +1,31 @@

What is this file?
Which license?
Who is using it?

Quoted 7 lines

Ok, you are right, some comments are here necessary.

On this boards is a preloader, which initializes the RAM. Therefore the preloader reads the RAM settings from the image he should load, through an hear. This header is created with a tool doimage (I think it is from marvell), and this tool needs this file ...

Quoted 3 lines

So, I have no idea where to put this files, and think they are in the board directory on the right place ...

Quoted 4 lines

I found something similiar in current mainline:

board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt

Quoted 3 lines

This file is also without comments, license info ... Maybe this tool don;t accept comments?

What should I do with this file?

bye
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Quoted 22 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Wednesday, February 10, 2010 12:39 PM
To: Prafulla Wadaskar
Cc: U-Boot user list
Subject: Re: [PATCH 2/2 v3] arm: suen3, suen3_v1, mgcoge2_arm_p1a support

Hello Prafulla,

do you have some comments on the following 2 points? (If they are clarified, I can post v4 of the patch ...)

Quoted 7 lines · Heiko Schocher

Quoted 6 lines · Prafulla Wadaskar

Quoted 6 lines

-----Original Message-----
From: Heiko Schocher [mailto:hs at denx.de]
Sent: Monday, February 01, 2010 1:07 PM
To: U-Boot user list
Cc: Wolfgang Denk; Prafulla Wadaskar; Tom
Subject: [PATCH 2/2 v3] arm: suen3, suen3_v1,

mgcoge2_arm_p1a support

...snip...

Quoted 6 lines

Quoted 1 line

Quoted 1 line

the include/config files indicates that there are five

board supports.

Quoted 1 line

Quoted 1 line

Please provide one patch for each board, may be first will

be master one.

Quoted 2 lines

This question also asked Tom, see:

Quoted 4 lines

Quoted 3 lines

http://lists.denx.de/pipermail/u-boot/2010-January/067182.html

But if you prefer to split this in 5 patches, I can do it.

Is it OK in one patch, or should I split it in 4 patches?

Dear Heiko

You should split it in patches as per boards supported, if you are supporting four board then there should be four different patches.

Quoted 11 lines

[...]

Quoted 10 lines

Quoted 10 lines

board/keymile/km_arm/sdramregs.txt

Quoted 7 lines

board/keymile/km_arm/sdramregs.txt new file +0 -0

new file mode 100644
index 0000000..68c53a7
@@ -0,0 +1,31 @@

What is this file?
Which license?
Who is using it?

Quoted 7 lines

Quoted 7 lines

Ok, you are right, some comments are here necessary.

On this boards is a preloader, which initializes the RAM. Therefore the preloader reads the RAM settings from the image he should load, through an hear. This header is created with a tool doimage (I think it is from marvell), and this tool needs this file ...

Marvell Kirkwood has internal bootROM and it may be active through h/w configuration on you board. In such case bootROM tries to read Kirkwood boot image (i.e. kwbimage) from boot media (i.e. NAND/SPI/Sata etc).

So kwbimage.cfg (the above file that you have created) should be present in board folder and this will be used by mkimage tool if you create u-boot.kwb target.

Quoted 2 lines

Quoted 2 lines

So, I have no idea where to put this files, and think they are in the board directory on the right place ...

Please refer docs/README.kwbimage

Quoted 3 lines

Quoted 3 lines

I found something similiar in current mainline:

board/Marvell/mv88f6281gtw_ge/dramregs_333h.txt

There is kwbimage.cfg and not dramregs_333h.txt, may be you are referring very early post