latest git pull changed drivers/scsi/lpfc/lpfc_hw4.h to executable
At latest pull, lpfs_hw4.h got set to executable...
git show def9c7a994f194377a23e687e6fd39b46c3ce631 --summary
states:
commit def9c7a994f194377a23e687e6fd39b46c3ce631
Author: James Smart <[email protected]> Date: Mon Dec 21 17:02:28 2009 -0500
[SCSI] lpfc 8.3.7: Fix hardware/SLI relates issues
Fix hardware/SLI relates issues:
- Fix CNA uses more than one EQ when in INTx interrupt mode.
- Fix driver tries to process failed read FCF record mailbox request.
- Fix allocating single receive buffer breaks FCoE receive queue.
- Support new read FCF record mailbox error case.
mode change 100644 => 100755 drivers/scsi/lpfc/lpfc_hw4.h
While looking at the same tree, I also noticed that:drivers/scsi/lpfc/lpfc_hbadisc.c is also executable.
I guess they should be fixed.
--
Thomas
Quoted 21 lines · Thomas Backlund
At latest pull,
lpfs_hw4.hgot set to executable...git show
def9c7a994f194377a23e687e6fd39b46c3ce631--summarystates:
commit
def9c7a994f194377a23e687e6fd39b46c3ce631Author: James Smart <[email protected]> Date: Mon Dec 21 17:02:28 2009 -0500[SCSI] lpfc 8.3.7: Fix hardware/SLI relates issues
Fix hardware/SLI relates issues:
- Fix CNA uses more than one EQ when in INTx interrupt mode.
- Fix driver tries to process failed read FCF record mailbox request.
- Fix allocating single receive buffer breaks FCoE receive queue.
- Support new read FCF record mailbox error case.Signed-off-by James Smart <[email protected]>Signed-off-by James Bottomley <[email protected]>
Quoted 7 lines
mode change 100644 => 100755
drivers/scsi/lpfc/lpfc_hw4.hWhile looking at the same tree, I also noticed that:
drivers/scsi/lpfc/lpfc_hbadisc.cis also executable.I guess they should be fixed.
I'll remove the x flag for both. I suppose a commit check that warns on executables might be in order, since adding them to the tree is a rare exception rather than a usual occurrence.
James
Thank You James. Sorry for the disruption. This is what I get for moving to a git-derived patch, instead of my own diff scripts which ignore things like this. Don't know what changed it in the first place.
-- james s
Quoted 37 lines · James Bottomley
Quoted 21 lines · Thomas Backlund
At latest pull,
lpfs_hw4.hgot set to executable...git show
def9c7a994f194377a23e687e6fd39b46c3ce631--summarystates:
commit
def9c7a994f194377a23e687e6fd39b46c3ce631Author: James Smart <[email protected]> Date: Mon Dec 21 17:02:28 2009 -0500[SCSI] lpfc 8.3.7: Fix hardware/SLI relates issues
Fix hardware/SLI relates issues:
- Fix CNA uses more than one EQ when in INTx interrupt mode.
- Fix driver tries to process failed read FCF record mailbox request.
- Fix allocating single receive buffer breaks FCoE receive queue.
- Support new read FCF record mailbox error case.Signed-off-by James Smart <[email protected]>Signed-off-by James Bottomley <[email protected]>Quoted 7 lines
mode change 100644 => 100755
drivers/scsi/lpfc/lpfc_hw4.hWhile looking at the same tree, I also noticed that:
drivers/scsi/lpfc/lpfc_hbadisc.cis also executable.I guess they should be fixed.
I'll remove the x flag for both. I suppose a commit check that warns on executables might be in order, since adding them to the tree is a rare exception rather than a usual occurrence.
James