Skip to contentSkip to conversation

musb: Test always evaluates to false

PATCH In review Roel Kluin 2 participants 2 messages Jan 9, 2010 – Jan 29, 2010

Subsystems (2)
USB MUSB multipoint high speed dual-role controller
lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 musb: Test always evaluates to false

The removed part always evaluates to false.

Signed-off-by Roel Kluin <[email protected]>
---
 drivers/usb/musb/musb_gadget.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Was a different test intended?

drivers/usb/musb/musb_gadget.c +1 -2
index cbcf14a..1a19203 100644
@@ -1697,8 +1697,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
 		return -EINVAL;
 
 	/* driver must be initialized to support peripheral mode */
-	if (!musb || !(musb->board_mode == MUSB_OTG
-				|| musb->board_mode != MUSB_OTG)) {
+	if (!musb) {
 		DBG(1, "%s, no dev??\n", __func__);
 		return -ENODEV;
 	}