Skip to contentSkip to conversation

1-wire: make PCI device id constant

PATCH New Németh Márton 1 participant 1 message Jan 10, 2010 W1 dallas's 1-wire bus

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 1-wire: make PCI device id constant

From: Márton Németh <[email protected]>

The id_table field of the struct pci_driver is constant in <linux/pci.h> so it is worth to make matrox_w1_tbl also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@

	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};

@s@
identifier r.I1, y;
identifier r.x, E;
@@

	struct I1 y = {
	  .x = E,
	};

@c@
identifier r.I2;
identifier s.E;
@@

	const struct I2 E[] = ... ;

@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const

	struct I2 E[] = ...;

// </smpl>

---

drivers/w1/masters/matrox_w1.c 2010-01-08 07:52:22.000000000 +0100 renamed from drivers/w1/masters/matrox_w1.c 2009-12-03 04:51:21.000000000 +0100 +1 -1
diff -u -p a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c
@@ -42,7 +42,7 @@ MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Evgeniy Polyakov <[email protected]>");
 MODULE_DESCRIPTION("Driver for transport(Dallas 1-wire prtocol) over VGA DDC(matrox gpio).");
 
-static struct pci_device_id matrox_w1_tbl[] = {
+static const struct pci_device_id matrox_w1_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_MATROX, PCI_DEVICE_ID_MATROX_G400) },
 	{ },
 };