bluetooth: make USB device id constant
PATCH 1/1 bluetooth: make USB device id constant
From: Márton Németh <[email protected]>
The id_table field of the struct usb_device_id is constant in <linux/usb.h> so it is worth to make bcm203x_table also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
---
drivers/bluetooth/bcm203x.c 2010-01-08 11:29:05.000000000 +0100 renamed from drivers/bluetooth/bcm203x.c 2009-12-03 04:51:21.000000000 +0100 +1 -1
@@ -39,7 +39,7 @@ #define VERSION "1.2" -static struct usb_device_id bcm203x_table[] = { +static const struct usb_device_id bcm203x_table[] = { /* Broadcom Blutonium (BCM2033) */ { USB_DEVICE(0x0a5c, 0x2033) },
Marcel Holtmann
maintainerHi Marton,
Quoted 4 lines
From: Márton Németh <[email protected]>
The
id_tablefield of the structusb_device_idis constant in <linux/usb.h> so it is worth to makebcm203x_tablealso constant.
patch has been applied to my tree. Thanks.
Regards
Marcel