Skip to contentSkip to conversation

why it not follow kernel codingstyle?

staging/hv Figo.zhang 3 participants 4 messages Jan 12, 2010 – Jan 15, 2010 1 message not in the archive

lore
Share & tools
lore

Figo.zhang

author
#0 lore raw

hi all,

i read the driver/staging/hv code, why it will apply into kernel tree that it not fellow the kernel codingstyle?

it ruin the kernel tree, it had better let the author rewrite it fellow the "linux kernel CodingStyle".

see Documentation/CodingStyle.

Best,
Figo.zhang

author
#1 lore raw

hi all,

i read the driver/staging/hv code, why it will apply into kernel tree that it not follow the kernel codingstyle? it all of "Hungarian notation".

see Documentation/CodingStyle. In this document,(line 254) it says: "Encoding the type of a function into the name (so-called Hungarian notation) is brain damaged".

so it ruin the kernel tree, it had better let the author rewrite it follow the "linux kernel CodingStyle".

Best,
Figo.zhang

#2 lore raw
Quoted 3 lines · Figo.zhang

hi all,

i read the driver/staging/hv code, why it will apply into kernel tree that it not follow the kernel codingstyle?

Drivers in the staging/ tree are there because they aren't clean and neat enough for the rest of the kernel tree. By the time it gets promoted to /virt (or where ever) it will have been fixed.

If the state of hv worries you, send patches!

	--Ben.