Skip to contentSkip to conversation

xfstests: fix up mkfs.gfs2 args for test 032

PATCH In review Eric Sandeen 2 participants 2 messages Jan 14, 2010 – Jan 15, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: fix up mkfs.gfs2 args for test 032

Looks like gfs2 (recently?) needs more arguments for the mkfs overwrite test.

---

032 +1 -1
index f81196c..5db89ad 100755
@@ -58,7 +58,7 @@ do
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
 	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
-	[ $fs = gfs2 ] && preop="echo y |"
+	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Eric Sandeen

Looks like gfs2 (recently?) needs more arguments for the mkfs overwrite test.

Looks good.

Quoted 2 lines

---

Quoted 14 lines
032 +1 -1
index f81196c..5db89ad 100755
@@ -58,7 +58,7 @@ do
 	# these folks prompt before writing
 	[ $fs = jfs ] && preop="echo Y |"
 	[ $fs = gfs ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
-	[ $fs = gfs2 ] && preop="echo y |"
+	[ $fs = gfs2 ] && preop="echo y |" && preargs="-p lock_nolock -j 1"
 	[ $fs = reiserfs ] && preop="echo y |" && preargs="-f"
 	# cramfs mkfs requires a directory argument
 	[ $fs = cramfs ] && preargs=/proc/fs/xfs
Quoted 4 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs