Skip to contentSkip to conversation

CRIS v32: Typo in crisv32_arbiter_unwatch()?

PATCH In review Roel Kluin 2 participants 2 messages Jan 17, 2010 – Jan 18, 2010

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 CRIS v32: Typo in crisv32_arbiter_unwatch()?

With id 1 the wrong bp was unwatched.

Signed-off-by Roel Kluin <[email protected]>

---
I guess it should be this?

arch/cris/arch-v32/mach-fs/arbiter.c +1 -1
index 84d31bd..82ef293 100644
@@ -332,7 +332,7 @@ int crisv32_arbiter_unwatch(int id)
 	if (id == 0)
 		intr_mask.bp0 = regk_marb_no;
 	else if (id == 1)
-		intr_mask.bp2 = regk_marb_no;
+		intr_mask.bp1 = regk_marb_no;
 	else if (id == 2)
 		intr_mask.bp2 = regk_marb_no;
 	else if (id == 3)
#1 lore raw

Yes, thank you!

Best Regards
/Mikael

-----Original Message-----
From: Roel Kluin [mailto:[email protected]]
Sent: den 17 januari 2010 19:04
To: Mikael Starvik; Jesper Nilsson; linux-cris-kernel; Andrew Morton; LKML
Subject: [PATCH] CRIS v32: Typo in crisv32_arbiter_unwatch()?

With id 1 the wrong bp was unwatched.

Signed-off-by Roel Kluin <[email protected]>

---
I guess it should be this?

arch/cris/arch-v32/mach-fs/arbiter.c +1 -1
index 84d31bd..82ef293 100644
@@ -332,7 +332,7 @@ int crisv32_arbiter_unwatch(int id)
 	if (id == 0)
 		intr_mask.bp0 = regk_marb_no;
 	else if (id == 1)
-		intr_mask.bp2 = regk_marb_no;
+		intr_mask.bp1 = regk_marb_no;
 	else if (id == 2)
 		intr_mask.bp2 = regk_marb_no;
 	else if (id == 3)