bfa: comparison with wrong msgtag in bfa_pport_isr()
Subsystems (2)
PATCH 1/1 bfa: comparison with wrong msgtag in bfa_pport_isr()
Compare it with the disable msgtag.
Signed-off-by Roel Kluin <[email protected]>
---
Was this maybe intended? otherwise in case BFI_PPORT_I2H_ENABLE_RSP:
the same code is executed. Please review.
drivers/scsi/bfa/bfa_fcport.c +1 -1
@@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)break ;case BFI_PPORT_I2H_DISABLE_RSP : -if (pport->msgtag == i2hmsg.enable_rsp->msgtag) +if (pport->msgtag == i2hmsg.disable_rsp->msgtag)bfa_sm_send_event (pport,BFA_PPORT_SM_FWRSP );break ;
Quoted 2 lines
Was this maybe intended? otherwise in case
BFI_PPORT_I2H_ENABLE_RSP:
the same code is executed. Please review.
Making this change alone will break compilation since bfa_pport_disable_rsp_s is not defined. To fix this, we should also replace it with bfa_pport_generic_rsp_s in bfi_pport_i2h_msg_u.
But please keep this as it is for now since I am working on resubmitting 2.1.2.1 patch, and there are a lot of changes in this area.
Thanks
Jing
Quoted 15 lines
drivers/scsi/bfa/bfa_fcport.c +1
-1@@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)break ;case BFI_PPORT_I2H_DISABLE_RSP : -if (pport->msgtag == i2hmsg.enable_rsp->msgtag) +if (pport->msgtag == i2hmsg.disable_rsp->msgtag)bfa_sm_send_event (pport,BFA_PPORT_SM_FWRSP );break ;